Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Mikko Rapeli
Hi, On Thu, Feb 09, 2023 at 12:42:09PM +0100, Alexander Kanavin wrote: > On Thu, 9 Feb 2023 at 12:12, Mikko Rapeli wrote: > > select() returns with any data, even single character. Fancy readers > > will read larger chunks but will read more data than is available and thus > > block for ever. Pla

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Alexander Kanavin
On Thu, 9 Feb 2023 at 12:12, Mikko Rapeli wrote: > select() returns with any data, even single character. Fancy readers > will read larger chunks but will read more data than is available and thus > block for ever. Plain read() will read the data which is available from > select() and thus really

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Mikko Rapeli
Hi, On Thu, Feb 09, 2023 at 11:53:00AM +0100, Alexander Kanavin wrote: > On Thu, 9 Feb 2023 at 10:36, Mikko Rapeli wrote: > > I think sleep() is ok in this case to reduce busy looping over serial > > console and read() more data than what select() initially saw. Reading > > single character at a

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Richard Purdie
On Thu, 2023-02-09 at 11:53 +0100, Alexander Kanavin wrote: > On Thu, 9 Feb 2023 at 10:36, Mikko Rapeli wrote: > > I think sleep() is ok in this case to reduce busy looping over serial > > console and read() more data than what select() initially saw. Reading > > single character at a time is a bi

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Alexander Kanavin
On Thu, 9 Feb 2023 at 10:36, Mikko Rapeli wrote: > I think sleep() is ok in this case to reduce busy looping over serial > console and read() more data than what select() initially saw. Reading > single character at a time is a bit silly and just wastes CPU time when > we don't need ms level accur

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Richard Purdie
On Thu, 2023-02-09 at 12:35 +0200, Mikko Rapeli wrote: > Hi, > > On Thu, Feb 09, 2023 at 10:20:36AM +, Richard Purdie wrote: > > On Thu, 2023-02-09 at 10:09 +0200, Mikko Rapeli wrote: > > > When qemu machine hangs, the ssh commands done by tests > > > are not timing out. do_testimage() task ha

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Mikko Rapeli
Hi, On Thu, Feb 09, 2023 at 10:20:36AM +, Richard Purdie wrote: > On Thu, 2023-02-09 at 10:09 +0200, Mikko Rapeli wrote: > > When qemu machine hangs, the ssh commands done by tests > > are not timing out. do_testimage() task has last logs like this: > > > > DEBUG: time: 1673531086.3155053, en

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Richard Purdie
On Thu, 2023-02-09 at 10:09 +0200, Mikko Rapeli wrote: > When qemu machine hangs, the ssh commands done by tests > are not timing out. do_testimage() task has last logs like this: > > DEBUG: time: 1673531086.3155053, endtime: 1673531686.315502 > > The test process is stuck for hours, or for ever

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Mikko Rapeli
Hi, On Thu, Feb 09, 2023 at 09:15:10AM +, Richard Purdie wrote: > On Thu, 2023-02-09 at 10:09 +0200, Mikko Rapeli wrote: > > When qemu machine hangs, the ssh commands done by tests > > are not timing out. do_testimage() task has last logs like this: > > > > DEBUG: time: 1673531086.3155053, en

Re: [OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Richard Purdie
On Thu, 2023-02-09 at 10:09 +0200, Mikko Rapeli wrote: > When qemu machine hangs, the ssh commands done by tests > are not timing out. do_testimage() task has last logs like this: > > DEBUG: time: 1673531086.3155053, endtime: 1673531686.315502 > > The test process is stuck for hours, or for ever

[OE-core] [PATCH v2 2/8] oeqa ssh.py: fix hangs in run()

2023-02-09 Thread Mikko Rapeli
When qemu machine hangs, the ssh commands done by tests are not timing out. do_testimage() task has last logs like this: DEBUG: time: 1673531086.3155053, endtime: 1673531686.315502 The test process is stuck for hours, or for ever if the executing command or test case did not set a timeout correct