Re: [OE-core] [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV

2013-05-03 Thread Richard Purdie
On Thu, 2013-05-02 at 18:46 +0200, Martin Jansa wrote: > On Thu, May 02, 2013 at 05:11:28PM +0100, Burton, Ross wrote: > > On 2 May 2013 16:39, Martin Jansa wrote: > > >> -PV = "0.10+git${SRCPV}" > > >> +PV = "0.10+git${SRCREV}" > > > > As the git revision is the 0.10 tag, wouldn't it be clearer

Re: [OE-core] [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV

2013-05-02 Thread Martin Jansa
On Thu, May 02, 2013 at 05:11:28PM +0100, Burton, Ross wrote: > On 2 May 2013 16:39, Martin Jansa wrote: > >> -PV = "0.10+git${SRCPV}" > >> +PV = "0.10+git${SRCREV}" > > As the git revision is the 0.10 tag, wouldn't it be clearer to not set > PV as the git revision is a detail of the fetcher - th

Re: [OE-core] [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV

2013-05-02 Thread Burton, Ross
On 2 May 2013 16:39, Martin Jansa wrote: >> -PV = "0.10+git${SRCPV}" >> +PV = "0.10+git${SRCREV}" As the git revision is the 0.10 tag, wouldn't it be clearer to not set PV as the git revision is a detail of the fetcher - this *is* 0.10. Ross ___ Opene

Re: [OE-core] [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV

2013-05-02 Thread Martin Jansa
On Thu, May 02, 2013 at 05:56:32PM +0300, Jukka Rissanen wrote: > > Signed-off-by: Jukka Rissanen > --- > meta/recipes-connectivity/neard/neard_0.10.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-connectivity/neard/neard_0.10.bb > b/meta/recipes-connec

[OE-core] [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV

2013-05-02 Thread Jukka Rissanen
Signed-off-by: Jukka Rissanen --- meta/recipes-connectivity/neard/neard_0.10.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-connectivity/neard/neard_0.10.bb b/meta/recipes-connectivity/neard/neard_0.10.bb index dc43f7e..b9198af 100644 --- a/meta/recipes-conn