Re: [OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs

2021-02-26 Thread kai
On 2/26/21 7:02 PM, Richard Purdie wrote: On Fri, 2021-02-26 at 09:57 +0800, Kai wrote: On 2/25/21 11:29 PM, Christopher Larson wrote: Are we sure we want to completely override it rather than adding to it? I'd be rather irritated if this blows away my prompt without my asking for it. I thin

Re: [OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs

2021-02-26 Thread Richard Purdie
On Fri, 2021-02-26 at 09:57 +0800, Kai wrote: > On 2/25/21 11:29 PM, Christopher Larson wrote: >   > > Are we sure we want to completely override it rather than adding  > > to it? I'd be rather irritated if this blows away my prompt  > > without my asking for it. I think either it should append or 

Re: [OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs

2021-02-25 Thread Christopher Larson
There is no way with this patch to prevent it from mucking with the prompt at all. Setting that variable to the empty string will just empty the prompt instead. > On Feb 25, 2021, at 6:57 PM, Kai wrote: > >  > On 2/25/21 11:29 PM, Christopher Larson wrote: >> Are we sure we want to completely

Re: [OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs

2021-02-25 Thread kai
On 2/25/21 11:29 PM, Christopher Larson wrote: Are we sure we want to completely override it rather than adding to it? I'd be rather irritated if this blows away my prompt without my asking for it. I think either it should append or have a variable controlling whether this is enabled when build

Re: [OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs

2021-02-25 Thread Christopher Larson
Are we sure we want to completely override it rather than adding to it? I'd be rather irritated if this blows away my prompt without my asking for it. I think either it should append or have a variable controlling whether this is enabled when building the SDK. On Wed, Feb 24, 2021 at 10:59 PM kai

[OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs

2021-02-24 Thread kai
From: Kai Kang Introduce a new variable SDK_PS1 to customize prompt string for SDKs when source script environment-setup-script. The default prompt string of SDKs looks like: SDK-poky-glibc-x86_64--cortexa57-qemuarm64$ Signed-off-by: Kai Kang --- v2: not set PS1 for buildtools-tarball meta/