Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Alejandro Hernandez
Thanks Ross, Acked-by: Alejandro Enedino Hernandez Samaniego On 9/14/2018 6:06 AM, Burton, Ross wrote: On 14 September 2018 at 00:49, Burton, Ross wrote: On 14 September 2018 at 00:30, Burton, Ross wrote: I suspect simply adding python3.5/*/test/ will catch the bulk of this now and in the

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Alexander Kanavin
2018-09-14 19:36 GMT+02:00 Andrew Geissler : >> We should probably do another dig at ridding oe-core of py2 :) > > Uh-oh! Guess we better get the Py3 update on our list. I meant that oe-core will not depend on py2 for anything. The py2 recipe will be provided in oe-core for quite a while yet, but

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Andrew Geissler
On Fri, Sep 14, 2018 at 11:48 AM Alexander Kanavin wrote: > > We should probably do another dig at ridding oe-core of py2 :) Uh-oh! Guess we better get the Py3 update on our list. > > Alex > > 2018-09-14 18:35 GMT+02:00 Alejandro Hernandez > : > > Hey Ross, > > > > > > I believe that if we want

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Andrew Geissler
On Fri, Sep 14, 2018 at 11:05 AM Burton, Ross wrote: > > On 14 September 2018 at 16:13, Andrew Geissler wrote: > > Nice, thanks Ross! Looks good to me. Will you be back-porting to > > python2 as well? > > Struggling to be motivated for Py2 to be honest. Do you fancy > duplicating the changes fo

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Alejandro Hernandez
To be fair, I have also not had a chance to update the py2 manifest script with the latest changes I made to py3 either, but I think applying these to create_manifest2 should be trivial. Alejandro On 9/14/2018 9:05 AM, Burton, Ross wrote: On 14 September 2018 at 16:13, Andrew Geissler wrot

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Alexander Kanavin
We should probably do another dig at ridding oe-core of py2 :) Alex 2018-09-14 18:35 GMT+02:00 Alejandro Hernandez : > Hey Ross, > > > I believe that if we want to go with this approach we would need to add > these packages as "special_packages" on the manifest script, that way the > script will

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Alejandro Hernandez
Sorry about the last email, I just saw this after sending the other one, yes I believe this might work, it would give us more control on how we handle packaging, although in a way it assumes the user knows what its doing which is not always the case :) Cheers, Alejandro On 9/14/2018 8:13 AM

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Alejandro Hernandez
Hey Ross, I believe that if we want to go with this approach we would need to add these packages as "special_packages" on the manifest script, that way the script will simply avoid checking dependencies for them and will pass them without modifications, this will also cause these packages to

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Burton, Ross
On 14 September 2018 at 16:13, Andrew Geissler wrote: > Nice, thanks Ross! Looks good to me. Will you be back-porting to > python2 as well? Struggling to be motivated for Py2 to be honest. Do you fancy duplicating the changes for Py2? Alternatively I'll get around to doing it next week. Ross

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Andrew Geissler
On Fri, Sep 14, 2018 at 8:06 AM Burton, Ross wrote: > > On 14 September 2018 at 00:49, Burton, Ross wrote: > > On 14 September 2018 at 00:30, Burton, Ross wrote: > >> I suspect simply adding python3.5/*/test/ will catch the bulk of this > >> now and in the future. > > > > Gave this a go and anno

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-14 Thread Burton, Ross
On 14 September 2018 at 00:49, Burton, Ross wrote: > On 14 September 2018 at 00:30, Burton, Ross wrote: >> I suspect simply adding python3.5/*/test/ will catch the bulk of this >> now and in the future. > > Gave this a go and annoyingly the manifest generation must sort the > list because the glo

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-13 Thread Burton, Ross
On 14 September 2018 at 00:30, Burton, Ross wrote: > I suspect simply adding python3.5/*/test/ will catch the bulk of this > now and in the future. Gave this a go and annoyingly the manifest generation must sort the list because the glob works for everything apart from packages after tests alphab

Re: [OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-13 Thread Burton, Ross
A little oe-pkgdata-util[1] managed to give me a good review of some missing entries here. python3-asyncio: /usr/lib/python3.5/asyncio/test_utils.py python3-2to3: /usr/lib/python3.5/lib2to3/tests/test_*.py python3-tkinter: /usr/lib/python3.5/tkinter/test/ python3-unittest: /usr/lib/python3.5/unitt

[OE-core] [PATCH v2] python/python3: Move test files to test package

2018-09-13 Thread Andrew Geissler
A quick search in the python package shows the following test directories being included in the python image: ./Python-2.7.14/Lib/bsddb/test ./Python-2.7.14/Lib/sqlite3/test ./Python-2.7.14/Lib/ctypes/test ./Python-2.7.14/Lib/unittest/test ./Python-2.7.14/Lib/lib-tk/test ./Python-2.7.14/Lib/email/t