Re: [OE-core] [PATCH 4/4] target/ssh: Ensure exit code set for commands

2023-07-29 Thread Richard Purdie
On Fri, 2023-07-28 at 08:02 -0600, Joshua Watt wrote: > On Fri, Jul 28, 2023 at 8:01 AM Joshua Watt wrote: > > > > On Fri, Jul 28, 2023 at 5:13 AM Richard Purdie > > wrote: > > > > > > As spotted by Joshua Watt, the returncode isn't set until .poll() or > > > .wait() > > > is called so we need

Re: [OE-core] [PATCH 4/4] target/ssh: Ensure exit code set for commands

2023-07-28 Thread Joshua Watt
On Fri, Jul 28, 2023 at 8:01 AM Joshua Watt wrote: > > On Fri, Jul 28, 2023 at 5:13 AM Richard Purdie > wrote: > > > > As spotted by Joshua Watt, the returncode isn't set until .poll() or .wait() > > is called so we need to call this after the .kill() call. > > > > This fixes return code reportin

Re: [OE-core] [PATCH 4/4] target/ssh: Ensure exit code set for commands

2023-07-28 Thread Joshua Watt
On Fri, Jul 28, 2023 at 5:13 AM Richard Purdie wrote: > > As spotted by Joshua Watt, the returncode isn't set until .poll() or .wait() > is called so we need to call this after the .kill() call. > > This fixes return code reporting so that timeouts for example now return an > exit code when they d

[OE-core] [PATCH 4/4] target/ssh: Ensure exit code set for commands

2023-07-28 Thread Richard Purdie
As spotted by Joshua Watt, the returncode isn't set until .poll() or .wait() is called so we need to call this after the .kill() call. This fixes return code reporting so that timeouts for example now return an exit code when they didn't before. Signed-off-by: Richard Purdie --- meta/lib/oeqa/c