Re: [OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-22 Thread Khem Raj
I have sent few patches to meta oe to fix similar issues earlier found with clang I think changes to code to define the macros in compliant way are better and upstreamable On Tue, Aug 22, 2017 at 10:21 AM Martin Jansa wrote: > Nothing special on my build host, just gcc 7.1 from gentoo. But the o

Re: [OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-22 Thread Martin Jansa
Nothing special on my build host, just gcc 7.1 from gentoo. But the option was introduced probably only in gcc-7, on 5.4.0 used in Ubuntu 16.04 it's also missing: OE qemux86@ ~/oe/world/shr-core $ gcc --help=warnings | grep expansion-to-defined OE qemux86@ ~/oe/world/shr-core $ gcc --version gcc (

Re: [OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-22 Thread Khem Raj
On Tue, Aug 22, 2017 at 3:22 AM, Richard Purdie wrote: > On Mon, 2017-08-21 at 22:57 +0200, Martin Jansa wrote: >> * build with gcc-7 fails with: >> | ./config-util.h:1504:48: error: this use of "defined" may not >> be portable [-Werror=expansion-to-defined] >> | || (defined _FO

Re: [OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-22 Thread Richard Purdie
On Tue, 2017-08-22 at 11:26 +0100, Martin Jansa wrote: > I'm sorry for the issues caused by this, can you share config.log > from that build? Maybe the native compiler on that build host doesn't > support this option? The one I linked to was a debian9 system, config.log says: gcc: error: unrecogn

Re: [OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-22 Thread Martin Jansa
I'm sorry for the issues caused by this, can you share config.log from that build? Maybe the native compiler on that build host doesn't support this option? On Tue, Aug 22, 2017 at 11:22 AM, Richard Purdie < richard.pur...@linuxfoundation.org> wrote: > On Mon, 2017-08-21 at 22:57 +0200, Martin Ja

Re: [OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-22 Thread Richard Purdie
On Mon, 2017-08-21 at 22:57 +0200, Martin Jansa wrote: > * build with gcc-7 fails with: >   | ./config-util.h:1504:48: error: this use of "defined" may not > be   portable [-Werror=expansion-to-defined] >   |  || (defined _FORTIFY_SOURCE && 0 < _FORTIFY_SOURCE \ >   |   

Re: [OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-21 Thread Khem Raj
On Mon, Aug 21, 2017 at 1:57 PM, Martin Jansa wrote: > * build with gcc-7 fails with: > | ./config-util.h:1504:48: error: this use of "defined" may not be > portable [-Werror=expansion-to-defined] > | || (defined _FORTIFY_SOURCE && 0 < _FORTIFY_SOURCE \ > |

[OE-core] [PATCH 2/2] grub2: fix build with gcc-7

2017-08-21 Thread Martin Jansa
* build with gcc-7 fails with: | ./config-util.h:1504:48: error: this use of "defined" may not be portable [-Werror=expansion-to-defined] | || (defined _FORTIFY_SOURCE && 0 < _FORTIFY_SOURCE \ | ^~~ and we're not bu