Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-29 Thread Enrico Scholz
Paul Eggleton writes: >> >> 1. set some defaults on distribution base ... >> >> 2. allow to override these defaults on a per-project base fwiw, I am using now _EXT_PROJECT_FEATURES = "\ largefile nfsroot modules ld-is-gold ${PROJECT_FEATURES} \ ${DISTRO_FEATURES_INITMAN} ${DISTRO_FEATURES_L

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Paul Eggleton
On Monday 28 January 2013 17:23:40 Enrico Scholz wrote: > Paul Eggleton writes: > >> 1. set some defaults on distribution base ... > >> 2. allow to override these defaults on a per-project base > >> ... > >> afaik, DISTRO_FEATURES_BACKFILL + _CONSIDERED exist to allow the first > >> two point with

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Enrico Scholz
Paul Eggleton writes: >> 1. set some defaults on distribution base ... >> 2. allow to override these defaults on a per-project base >> ... >> afaik, DISTRO_FEATURES_BACKFILL + _CONSIDERED exist to allow the first >> two point without an '-=' operator which lacks in bitbake. > > No they don't. The

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Phil Blundell
On Mon, 2013-01-28 at 16:44 +0100, Enrico Scholz wrote: > afaik, DISTRO_FEATURES_BACKFILL + _CONSIDERED exist to allow the first > two point without an '-=' operator which lacks in bitbake. That wasn't really the intention. The original purpose of DISTRO_FEATURES_BACKFILL was to allow behaviour t

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Paul Eggleton
On Monday 28 January 2013 16:44:15 Enrico Scholz wrote: > Phil Blundell writes: > > This does seem rather like an abuse of DISTRO_FEATURES_BACKFILL. Can > > you explain why you are doing it this way rather than just setting > > DISTRO_FEATURES directly to what you wanted? > > I need a way to: >

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Enrico Scholz
Phil Blundell writes: > This does seem rather like an abuse of DISTRO_FEATURES_BACKFILL. Can > you explain why you are doing it this way rather than just setting > DISTRO_FEATURES directly to what you wanted? I need a way to: 1. set some defaults on distribution base and avoid nasty details li

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Phil Blundell
On Mon, 2013-01-28 at 15:52 +0100, Enrico Scholz wrote: > There are some implicit relations between features (e.g. when selecting > 'usbhost' I *usually* want 'vfat' or 'ext2' support too). So I have > > DISTRO_FEATURES_BACKFILL = "\ > largefile nfsroot modules ld-is-gold ${PROJECT_FEATURES}

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Enrico Scholz
Paul Eggleton writes: > Why are you assigning *_FEATURES_BACKFILL at all? There are some implicit relations between features (e.g. when selecting 'usbhost' I *usually* want 'vfat' or 'ext2' support too). So I have DISTRO_FEATURES_BACKFILL = "\ largefile nfsroot modules ld-is-gold ${PROJEC

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Paul Eggleton
On Monday 28 January 2013 14:55:05 Enrico Scholz wrote: > Richard Purdie writes: > >> > Backfilling DISTRO_FEATURES and MACHINE_FEATURES with _append > >> > statements > >> > happens too late to use those variables with conditional inherits, like > >> > >> > this: > >> This causes regressions for

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Enrico Scholz
Richard Purdie writes: >> > Backfilling DISTRO_FEATURES and MACHINE_FEATURES with _append statements >> > happens too late to use those variables with conditional inherits, like >> > this: >> >> This causes regressions for setups where DISTRO_FEATURES_BACKFILL uses >> the override mechanism. E.g

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-28 Thread Richard Purdie
On Fri, 2013-01-25 at 19:06 +0100, Enrico Scholz wrote: > Ross Burton > writes: > > > Backfilling DISTRO_FEATURES and MACHINE_FEATURES with _append statements > > happens too late to use those variables with conditional inherits, like > > this: > > This causes regressions for setups where DISTRO

Re: [OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-25 Thread Enrico Scholz
Ross Burton writes: > Backfilling DISTRO_FEATURES and MACHINE_FEATURES with _append statements > happens too late to use those variables with conditional inherits, like > this: This causes regressions for setups where DISTRO_FEATURES_BACKFILL uses the override mechanism. E.g. I have | DISTRO_FE

[OE-core] [PATCH 2/2] base: make feature backfilling happen earlier

2013-01-24 Thread Ross Burton
From: Richard Purdie Backfilling DISTRO_FEATURES and MACHINE_FEATURES with _append statements happens too late to use those variables with conditional inherits, like this: inherit ${@base_contains('DISTRO_FEATURES','sysvinit','update-rc.d_real','',d)} Instead, do the backfilling at ConfigParse