Re: [OE-core] [PATCH 1/3] systemd: Fix build with gcc8

2018-06-01 Thread Khem Raj
On 6/1/18 7:01 AM, Martin Jansa wrote: > No change in PACKAGECONFIG, just default nodistro qemux86 with added > systemd and debug build: > DISTRO_FEATURES_append = " systemd" > DEBUG_BUILD = "1" > hmm so must be some code which is eliminated by compiler optimizations with -O2 since with debug bui

Re: [OE-core] [PATCH 1/3] systemd: Fix build with gcc8

2018-06-01 Thread Martin Jansa
It fails when -O1 or -Os is being used, builds ok with -O0, -O2, -O3. Checking a bit more shows that it doesn't fail when -ftree-vrp is used, probably because this check is removed as the documentation for -ftree-vrp says: -ftree-vrp Perform Value Range Propagation on trees. This is similar to th

Re: [OE-core] [PATCH 1/3] systemd: Fix build with gcc8

2018-06-01 Thread Martin Jansa
No change in PACKAGECONFIG, just default nodistro qemux86 with added systemd and debug build: DISTRO_FEATURES_append = " systemd" DEBUG_BUILD = "1" On Thu, May 31, 2018 at 6:17 PM Khem Raj wrote: > On Thu, May 31, 2018 at 9:05 AM, Martin Jansa > wrote: > > Unlike the previous version you had i

Re: [OE-core] [PATCH 1/3] systemd: Fix build with gcc8

2018-05-31 Thread Khem Raj
On Thu, May 31, 2018 at 9:05 AM, Martin Jansa wrote: > Unlike the previous version you had in your RFT branch (which added > -Wno-error=format-truncation) this doesn't seem to be complete fix. > > In qemux86 build which already includes this change I'm seeing: > ../git/src/basic/time-util.c: In fu

Re: [OE-core] [PATCH 1/3] systemd: Fix build with gcc8

2018-05-31 Thread Martin Jansa
Unlike the previous version you had in your RFT branch (which added -Wno-error=format-truncation) this doesn't seem to be complete fix. In qemux86 build which already includes this change I'm seeing: ../git/src/basic/time-util.c: In function 'format_timespan': ../git/src/basic/time-util.c:508:46:

[OE-core] [PATCH 1/3] systemd: Fix build with gcc8

2018-05-28 Thread Khem Raj
Signed-off-by: Khem Raj --- ...ange-the-default-device-timeout-to-2.patch | 9 +- ...ation-compile-failure-by-typecasting.patch | 173 ++ meta/recipes-core/systemd/systemd_237.bb | 1 + 3 files changed, 177 insertions(+), 6 deletions(-) create mode 100644 meta/recipes-c