Re: [OE-core] [PATCH 1/2] base: improve PACKAGECONFIG handling logic

2013-09-11 Thread Saul Wold
On 09/11/2013 11:17 AM, Ross Burton wrote: The existing code for handling PACKAGECONFIG lists wasn't the cleanest Python around. Instead of diving into the list directly using indices and lengths, use pop() to iterate through the list. I started to get some strange behaviour with building wor

[OE-core] [PATCH 1/2] base: improve PACKAGECONFIG handling logic

2013-09-11 Thread Ross Burton
The existing code for handling PACKAGECONFIG lists wasn't the cleanest Python around. Instead of diving into the list directly using indices and lengths, use pop() to iterate through the list. Signed-off-by: Ross Burton --- meta/classes/base.bbclass | 23 --- 1 file change

Re: [OE-core] [PATCH 1/2] base: improve PACKAGECONFIG handling logic

2013-09-10 Thread Martin Jansa
On Tue, Sep 10, 2013 at 06:17:27PM +0100, Burton, Ross wrote: > On 10 September 2013 18:15, Ross Burton wrote: > > -if num >= 3 and items[2]: > > -extradeps.append(items[2]) > > -if num >= 4 and items[3]: > > -extrardeps.appen

Re: [OE-core] [PATCH 1/2] base: improve PACKAGECONFIG handling logic

2013-09-10 Thread Burton, Ross
On 10 September 2013 18:15, Ross Burton wrote: > -if num >= 3 and items[2]: > -extradeps.append(items[2]) > -if num >= 4 and items[3]: > -extrardeps.append(items[3]) > -if num >= 1 and items[0]: > -

[OE-core] [PATCH 1/2] base: improve PACKAGECONFIG handling logic

2013-09-10 Thread Ross Burton
The existing code for handling PACKAGECONFIG lists wasn't the cleanest Python around. Instead of diving into the list directly using indices and lengths, use pop() to iterate through the list. Signed-off-by: Ross Burton --- meta/classes/base.bbclass | 17 ++--- 1 file changed, 10