Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-05-12 Thread Andre McCurdy
On Tue, May 12, 2015 at 1:40 AM, Paul Eggleton wrote: > Hi Andre, > > On Monday 11 May 2015 17:34:45 Andre McCurdy wrote: >> On Wed, Feb 25, 2015 at 7:15 AM, Cristian Iorga >> >> wrote: >> > oe.utils.both_contain() just does a find() on the value >> > rather than splitting the value and then look

Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-05-12 Thread Paul Eggleton
Hi Andre, On Monday 11 May 2015 17:34:45 Andre McCurdy wrote: > On Wed, Feb 25, 2015 at 7:15 AM, Cristian Iorga > > wrote: > > oe.utils.both_contain() just does a find() on the value > > rather than splitting the value and then looking in the > > list of split items. The result is that if you ad

Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-05-11 Thread Andre McCurdy
On Wed, Feb 25, 2015 at 7:15 AM, Cristian Iorga wrote: > oe.utils.both_contain() just does a find() on the value > rather than splitting the value and then looking in the > list of split items. The result is that if you add a > feature to MACHINE_FEATURES that itself has a substring > that matches

Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-02-26 Thread Burton, Ross
On 26 February 2015 at 22:35, Paul Eggleton wrote: > Genuine question, which I should have asked last time those files were > touched > - how do those tests relate to oe-selftest tests? > Looks like they're unrelated. As they're standard unittest modules it should be fairly simple to teach oe-s

Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-02-26 Thread Paul Eggleton
On Thursday 26 February 2015 20:34:36 Burton, Ross wrote: > On 26 February 2015 at 20:19, Iorga, Cristian > > wrote: > > Can you point me to a tutorial in this kind of test suites? > > I sure can, see meta/lib/oe/tests/test_utils.py. Should be fairly obvious. Genuine question, which I should h

Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-02-26 Thread Burton, Ross
On 26 February 2015 at 20:19, Iorga, Cristian wrote: > Can you point me to a tutorial in this kind of test suites? > > I sure can, see meta/lib/oe/tests/test_utils.py. Should be fairly obvious. Ross -- ___ Openembedded-core mailing list Openembedded-

Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-02-26 Thread Iorga, Cristian
Hi Ross, Can you point me to a tutorial in this kind of test suites? /Cristian From: Burton, Ross [mailto:ross.bur...@intel.com] Sent: Thursday, February 26, 2015 10:08 PM To: Iorga, Cristian Cc: OE-core Subject: Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain

Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-02-26 Thread Burton, Ross
On 25 February 2015 at 15:15, Cristian Iorga wrote: > oe.utils.both_contain() just does a find() on the value > rather than splitting the value and then looking in the > list of split items. The result is that if you add a > feature to MACHINE_FEATURES that itself has a substring > that matches o

[OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

2015-02-25 Thread Cristian Iorga
oe.utils.both_contain() just does a find() on the value rather than splitting the value and then looking in the list of split items. The result is that if you add a feature to MACHINE_FEATURES that itself has a substring that matches one of the values looked for when building COMBINED_FEATURES, you