Re: [OE-core] [PATCH 02/11] grub: Backport fix for largefile detection/use

2016-01-25 Thread Khem Raj
> On Jan 25, 2016, at 1:35 PM, Burton, Ross wrote: > > > On 25 January 2016 at 21:33, Khem Raj > wrote: > Remember my other email about how we cache sizeof_off_t to > openemebedded-architecture ? > this to insulate against that change. Because by caching that varia

Re: [OE-core] [PATCH 02/11] grub: Backport fix for largefile detection/use

2016-01-25 Thread Burton, Ross
On 25 January 2016 at 21:33, Khem Raj wrote: > Remember my other email about how we cache sizeof_off_t to > openemebedded-architecture ? > this to insulate against that change. Because by caching that variable in > our site files we defeat AC_CHECK_SIZEOF macro. > Let's remove it from the site

Re: [OE-core] [PATCH 02/11] grub: Backport fix for largefile detection/use

2016-01-25 Thread Khem Raj
> On Jan 25, 2016, at 1:14 PM, Burton, Ross wrote: > > > On 25 January 2016 at 18:32, Khem Raj > wrote: > +EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', > '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}" > > Why do you

Re: [OE-core] [PATCH 02/11] grub: Backport fix for largefile detection/use

2016-01-25 Thread Burton, Ross
On 25 January 2016 at 18:32, Khem Raj wrote: > +EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', > '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}" > Why do you need to pass ac_cv_sizeof_off_t? Surely that's what AC_CHECK_SIZEOF is for? Ross -- _

[OE-core] [PATCH 02/11] grub: Backport fix for largefile detection/use

2016-01-25 Thread Khem Raj
This is inspired by musl porting, where grub's configure is enabling largefile support based on glibc versions, instead an upstream patch turns it into autoconf check Update git version recipe arm platforms use this recipe to provide grub and it needed fixes from upstream so upgrade to latest tip