Re: [OE-core] [PATCH] wic: update test case test_qemu

2019-01-13 Thread Kang Kai
On 2019/1/11 下午9:15, Burton, Ross wrote: I'm wondering what the point of checking the output of mount is.  If we're just checking that the image booted then the grep is sufficient right? If just checking the wic image has been booted successfully, I think grep /boot is sufficient. V2 will be

Re: [OE-core] [PATCH] wic: update test case test_qemu

2019-01-11 Thread Burton, Ross
I'm wondering what the point of checking the output of mount is. If we're just checking that the image booted then the grep is sufficient right? Ross On Fri, 11 Jan 2019 at 09:22, Kang Kai wrote: > On 2019/1/4 上午10:49, kai.k...@windriver.com wrote: > > From: Kai Kang > > > > It checks output

Re: [OE-core] [PATCH] wic: update test case test_qemu

2019-01-11 Thread Kang Kai
On 2019/1/4 上午10:49, kai.k...@windriver.com wrote: From: Kai Kang It checks output of mount in wic test case test_qemu. But the outputs are different between sysvinit and systemd. Add assertion for systemd. Signed-off-by: Kai Kang --- meta/lib/oeqa/selftest/cases/wic.py | 5 - 1 file c

[OE-core] [PATCH] wic: update test case test_qemu

2019-01-03 Thread kai.kang
From: Kai Kang It checks output of mount in wic test case test_qemu. But the outputs are different between sysvinit and systemd. Add assertion for systemd. Signed-off-by: Kai Kang --- meta/lib/oeqa/selftest/cases/wic.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/me