Re: [OE-core] [PATCH] wic: isoimage-isohybrid: implement grubefi menu logic

2016-04-20 Thread Ed Bartosh
On Wed, Apr 20, 2016 at 10:45:05AM +0300, Ioan-Adrian Ratiu wrote: > Hello Ed, > > I've looked a little at the wic rewrites in master and they're really really > awesome! > > Just to verify if I understood correctly: Now if I want custom menus in grub I > can specify them directly in a custom .c

Re: [OE-core] [PATCH] wic: isoimage-isohybrid: implement grubefi menu logic

2016-04-20 Thread Ioan-Adrian Ratiu
Hello Ed, I've looked a little at the wic rewrites in master and they're really really awesome! Just to verify if I understood correctly: Now if I want custom menus in grub I can specify them directly in a custom .cfg supplied in the wks by the "configfile" bootloader option, so there's no need

Re: [OE-core] [PATCH] wic: isoimage-isohybrid: implement grubefi menu logic

2016-04-19 Thread Ed Bartosh
Hi Ioan-Adrian, It's my fault as I've rewritten ks parser and missed --menu implementation. Let me know if you need my help with this. It would be great if you also add test case for this feature to wic oe-selftest suite. Regards, Ed On Tue, Apr 19, 2016 at 03:17:56PM +0300, Ioan-Adrian Ratiu

Re: [OE-core] [PATCH] wic: isoimage-isohybrid: implement grubefi menu logic

2016-04-19 Thread Ioan-Adrian Ratiu
Hello Ed, I've tested it on Jethro. Sorry about this. I'll look at the changes in wic's kickstart and redo/resubmit. Thank you, Ioan On Mon, 18 Apr 2016 16:24:11 +0300 Ed Bartosh wrote: > Hi Ioan-Adrian, > > Did you test if this patch works on master? > From the first look I'd say it will no

Re: [OE-core] [PATCH] wic: isoimage-isohybrid: implement grubefi menu logic

2016-04-18 Thread Ed Bartosh
Hi Ioan-Adrian, Did you test if this patch works on master? >From the first look I'd say it will not work as --menu bootloader option is not implemented there. On Mon, Apr 18, 2016 at 03:46:22PM +0300, Ioan-Adrian Ratiu wrote: > Right now isoimage-isohybrid creates a single boot menu entry "boot"

[OE-core] [PATCH] wic: isoimage-isohybrid: implement grubefi menu logic

2016-04-18 Thread Ioan-Adrian Ratiu
Right now isoimage-isohybrid creates a single boot menu entry "boot" and passes it the arguments supplied with "--append". There is logic for creating custom grub menus, but it is sadly not used. "boot" is hardcoded. This change makes isoimage use the wic bootloader "--menu" argument to create its