Re: [OE-core] [PATCH] tcp-wrappers: Fix build with clang

2018-03-23 Thread Khem Raj
On Fri, Mar 23, 2018 at 4:16 AM, Oleksiy Obitotskyy (cisco) wrote: > Hello, > > I would like to clarify your question. > Function fix_options has no prototype into tcpd.c and miscd.c and generate > warnings > 'warning: implicit declaration of function' but links fine. > So should I add prototype f

Re: [OE-core] [PATCH] tcp-wrappers: Fix build with clang

2018-03-23 Thread Oleksiy Obitotskyy (cisco)
Hello, I would like to clarify your question. Function fix_options has no prototype into tcpd.c and miscd.c and generate warnings 'warning: implicit declaration of function' but links fine. So should I add prototype for fix_options or leave it as is? Regards, Oleksiy On 23.03.18 07:21, Khem R

Re: [OE-core] [PATCH] tcp-wrappers: Fix build with clang

2018-03-22 Thread Khem Raj
On Thu, Mar 22, 2018 at 10:37 AM, Oleksiy Obitotskyy wrote: > Fix non-void function 'fix_options' should return a value. > this patch is ok. Can you also check if this function signature is needed in other source files as well ? > Signed-off-by: Oleksiy Obitotskyy > --- > .../0001-Fix-build-wi

[OE-core] [PATCH] tcp-wrappers: Fix build with clang

2018-03-22 Thread Oleksiy Obitotskyy
Fix non-void function 'fix_options' should return a value. Signed-off-by: Oleksiy Obitotskyy --- .../0001-Fix-build-with-clang.patch| 30 ++ .../tcp-wrappers/tcp-wrappers_7.6.bb | 1 + 2 files changed, 31 insertions(+) create mode 100644 meta/