Re: [OE-core] [PATCH] sdl2: fix sdl2.pc include paths

2019-01-14 Thread Andreas Müller
My two comments: 1. There is already an upgrade libsdl2 -> 2.09 pending so this patch needs rebase [1] 2. Removing CFLAGS is easier but potentially a risk of unwanted effects. My sdl2.pc contains -D_REENTRANT. This should be obsolete but who guarantees that there isn't some old application still r

Re: [OE-core] [PATCH] sdl2: fix sdl2.pc include paths

2019-01-14 Thread Burton, Ross
Would it be easier to just remove @SDL_CFLAGS@ from sdl.pc.in? Does that contain other values that are needed, or are they all spurious? Ross On Sat, 12 Jan 2019 at 08:43, Samuli Piippo wrote: > SDL2 dumps all cflags to the sdl2.pc, which might then contain paths > to the recipe sysroot includ

[OE-core] [PATCH] sdl2: fix sdl2.pc include paths

2019-01-12 Thread Samuli Piippo
SDL2 dumps all cflags to the sdl2.pc, which might then contain paths to the recipe sysroot include dirs. Signed-off-by: Samuli Piippo --- meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 4 1 file changed, 4 insertions(+) diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb b/meta/