Re: [OE-core] [PATCH] patch.bbclass: unset TMPDIR after use

2014-06-26 Thread Burton, Ross
I forgot to say that Robert sent almost exactly this patch last year but I nacked it because the TMPDIR assignment should happen when patch is exec'd. I'm not so sure now as that would cause an unnecessary overhead to patching. Ross On 26 June 2014 15:16, Ross Burton wrote: > GNU Patch < 2.6.1

[OE-core] [PATCH] patch.bbclass: unset TMPDIR after use

2014-06-26 Thread Ross Burton
GNU Patch < 2.6.1 has a race condition so we create a per-instance TMPDIR to avoid this. This was implemented by setting os.environ[TMPDIR] but at the end of do_patch the temporary directory is deleted but TMPDIR is not unset. In general this doesn't cause a problem but if do_patch is embedded in