Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support for python

2017-03-28 Thread Patel, Vedang
Hi Andre, Ross, On Thu, 2017-03-23 at 18:39 -0700, Andre McCurdy wrote: >  On Thu, Mar 23, 2017 at 5:00 PM, Vedang Patel m> wrote: > > > > Add support to enable python bindings for libxslt using > > PACKAGECONFIG. > > This will include --with-python argument while compiling the > > package. > >

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support for python

2017-03-23 Thread Andre McCurdy
On Thu, Mar 23, 2017 at 5:00 PM, Vedang Patel wrote: > Add support to enable python bindings for libxslt using PACKAGECONFIG. > This will include --with-python argument while compiling the package. > The support is disabled by default. > > Signed-off-by: Vedang Patel > --- > meta/recipes-suppor

[OE-core] [PATCH] libxslt: Add PACKAGECONFIG support for python

2017-03-23 Thread Vedang Patel
Add support to enable python bindings for libxslt using PACKAGECONFIG. This will include --with-python argument while compiling the package. The support is disabled by default. Signed-off-by: Vedang Patel --- meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 -- 1 file changed, 4 insertions

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-23 Thread Jussi Kukkonen
On 23 March 2017 at 09:37, Jussi Kukkonen wrote: > On 22 March 2017 at 22:17, Patel, Vedang wrote: > > > > Hi Jussi, > > > > Hi Vedang, > > ... and somehow I only received the rest of the discussion (where all my points were already handled) now: carry on, sorry for spam. Jussi --

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-23 Thread Jussi Kukkonen
On 22 March 2017 at 22:17, Patel, Vedang wrote: > > Hi Jussi, > Hi Vedang, If you can make your email client use ">" for quoting that would be great (so it's possible to see who's talking even in plain text). PACKAGECONFIG comments below. > On Tue, 2017-03-21 at 08:36 +, Kukkonen, Jussi wr

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-22 Thread Patel, Vedang
On Wed, 2017-03-22 at 22:18 +, Burton, Ross wrote: > > On 22 March 2017 at 22:16, Patel, Vedang > wrote: > > I got my mistake. Setting PACKAGECONFIG enabled all the features by > > default. Also, should I be including python as runtime dependency > > when > > --with-python is used? > > > No,

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-22 Thread Burton, Ross
On 22 March 2017 at 22:16, Patel, Vedang wrote: > I got my mistake. Setting PACKAGECONFIG enabled all the features by > default. Also, should I be including python as runtime dependency when > --with-python is used? > No, the rdepends will happen magically. You might want to package the python

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-22 Thread Patel, Vedang
Hi Ross, On Wed, 2017-03-22 at 20:19 +, Burton, Ross wrote: > > On 22 March 2017 at 20:17, Patel, Vedang > wrote: > > Can you elabore on your concern? I am not exactly following it. > > > > the configs won't be enabled unless the corresponding features are > > explicitly enabled in the imag

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-22 Thread Burton, Ross
On 22 March 2017 at 20:17, Patel, Vedang wrote: > Can you elabore on your concern? I am not exactly following it. > > the configs won't be enabled unless the corresponding features are > explicitly enabled in the image. I am using libxslt- prefix to make sure > someone does not inadvertently enab

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-22 Thread Patel, Vedang
Hi Jussi, On Tue, 2017-03-21 at 08:36 +, Kukkonen, Jussi wrote: On 21 March 2017 at 02:31, Vedang Patel mailto:vedang.pa...@intel.com>> wrote: Some options like python bindings, debug support, crypto are hardcoded inside the recipe. Change that to make those option configurable using PACKAGEC

Re: [OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-21 Thread Jussi Kukkonen
On 21 March 2017 at 02:31, Vedang Patel wrote: > Some options like python bindings, debug support, crypto are hardcoded > inside the recipe. Change that to make those option configurable using > PACKAGECONFIG. > > Signed-off-by: Vedang Patel > --- > meta/recipes-support/libxslt/libxslt_1.1.29.b

[OE-core] [PATCH] libxslt: Add PACKAGECONFIG support

2017-03-20 Thread Vedang Patel
Some options like python bindings, debug support, crypto are hardcoded inside the recipe. Change that to make those option configurable using PACKAGECONFIG. Signed-off-by: Vedang Patel --- meta/recipes-support/libxslt/libxslt_1.1.29.bb | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(