Re: [OE-core] [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11

2016-02-26 Thread Jonathan Liu
On 27 February 2016 at 01:43, wrote: >>> I'd call that a bug, and should be simple to resolve (pass expand=True >>> when >>> fetching getVarFlags in the PACKAGECONFIG handling code). >>> >>> Ross >> >> Feel free to submit a patch to handle the PACKAGECONFIG expansion and >> then I can update the

Re: [OE-core] [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11

2016-02-26 Thread alexander . kanavin
>> I'd call that a bug, and should be simple to resolve (pass expand=True >> when >> fetching getVarFlags in the PACKAGECONFIG handling code). >> >> Ross > > Feel free to submit a patch to handle the PACKAGECONFIG expansion and > then I can update the fix. I think you need to solve this in a diffe

Re: [OE-core] [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11

2016-02-26 Thread Jonathan Liu
On 26 February 2016 at 23:33, Burton, Ross wrote: > > On 26 February 2016 at 11:17, Jonathan Liu wrote: >> >> It doesn't work in PACKAGECONFIG. that is the first thing I tried. > > > I'd call that a bug, and should be simple to resolve (pass expand=True when > fetching getVarFlags in the PACK

Re: [OE-core] [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11

2016-02-26 Thread Burton, Ross
On 26 February 2016 at 11:17, Jonathan Liu wrote: > It doesn't work in PACKAGECONFIG. that is the first thing I tried. > I'd call that a bug, and should be simple to resolve (pass expand=True when fetching getVarFlags in the PACKAGECONFIG handling code). Ross -- ___

Re: [OE-core] [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11

2016-02-26 Thread Jonathan Liu
Hi Martin, It doesn't work in PACKAGECONFIG. that is the first thing I tried. Regards, Jonathan On 26 February 2016 at 22:04, Martin Jansa wrote: > On Fri, Feb 26, 2016 at 09:52:25PM +1100, Jonathan Liu wrote: >> If avdevice is enabled, libxv is used if it is detected by configure >> for th

Re: [OE-core] [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11

2016-02-26 Thread Martin Jansa
On Fri, Feb 26, 2016 at 09:52:25PM +1100, Jonathan Liu wrote: > If avdevice is enabled, libxv is used if it is detected by configure > for the XV outdev. However, we can't depend on libxv for avdevice when > DISTRO_FEATURES doesn't contain x11 as this will result in an error. > > Fix this by addin

[OE-core] [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11

2016-02-26 Thread Jonathan Liu
If avdevice is enabled, libxv is used if it is detected by configure for the XV outdev. However, we can't depend on libxv for avdevice when DISTRO_FEATURES doesn't contain x11 as this will result in an error. Fix this by adding a libxv dependency only when the avdevice PACKAGECONFIG is enabled and