Re: [OE-core] [PATCH] connman-gnome: fixed DHCP segfault

2013-05-17 Thread Ciobanu, Emilia Maria Silvia
: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] connman-gnome: fixed DHCP segfault On 17 May 2013 11:32, Emilia Ciobanu wrote: > +- if (g_str_equal(ipv4_config.method, "dhcp") == TRUE) > ++ if (!ipv4_config.method || g_str_equal(ipv4_config.method, &q

Re: [OE-core] [PATCH] connman-gnome: fixed DHCP segfault

2013-05-17 Thread Burton, Ross
On 17 May 2013 11:32, Emilia Ciobanu wrote: > +- if (g_str_equal(ipv4_config.method, "dhcp") == TRUE) > ++ if (!ipv4_config.method || g_str_equal(ipv4_config.method, "dhcp") == > TRUE) Is this really the right behaviour if IPv4.Method isn't set? Ross _

Re: [OE-core] [PATCH] connman-gnome: fixed DHCP segfault

2013-05-17 Thread Saul Wold
On 05/17/2013 01:32 PM, Emilia Ciobanu wrote: In networks that don't have a DHCP server configured, ipv4 address allocation fails and the ipv4 structure doesn't get populated. The patch checks this case also. [YOCTO #3945] Signed-off-by: Emilia Ciobanu --- .../connman-gnome/null_check_for_ip

[OE-core] [PATCH] connman-gnome: fixed DHCP segfault

2013-05-17 Thread Emilia Ciobanu
In networks that don't have a DHCP server configured, ipv4 address allocation fails and the ipv4 structure doesn't get populated. The patch checks this case also. [YOCTO #3945] Signed-off-by: Emilia Ciobanu --- .../connman-gnome/null_check_for_ipv4_config.patch | 26 .../