Re: [OE-core] [PATCH] cmake: Support Eclipse and other cmake generators

2019-04-08 Thread Burton, Ross
Can you put that in the commit message, because I tried googling and didn't find that list. Maybe also expand the comment. Ross On Mon, 8 Apr 2019 at 22:12, Douglas Royds wrote: > > On 9/04/19 9:04 AM, Burton, Ross wrote: > > On Mon, 8 Apr 2019 at 21:56, Douglas Royds > wrote: > > python() {

Re: [OE-core] [PATCH] cmake: Support Eclipse and other cmake generators

2019-04-08 Thread Douglas Royds
On 9/04/19 9:04 AM, Burton, Ross wrote: On Mon, 8 Apr 2019 at 21:56, Douglas Royds wrote: python() { generator = d.getVar("OECMAKE_GENERATOR") -if generator == "Unix Makefiles": -args = "-G 'Unix Makefiles' -DCMAKE_MAKE_PROGRAM=" + d.getVar("MAKE") +if "Unix Makefiles"

Re: [OE-core] [PATCH] cmake: Support Eclipse and other cmake generators

2019-04-08 Thread Burton, Ross
On Mon, 8 Apr 2019 at 21:56, Douglas Royds wrote: > python() { > generator = d.getVar("OECMAKE_GENERATOR") > -if generator == "Unix Makefiles": > -args = "-G 'Unix Makefiles' -DCMAKE_MAKE_PROGRAM=" + d.getVar("MAKE") > +if "Unix Makefiles" in generator: > +args = "-G

[OE-core] [PATCH] cmake: Support Eclipse and other cmake generators

2019-04-08 Thread Douglas Royds
From: Nikhil Pal Singh As per Generators information mentioned in the cmake --help file only "Unix Makefiles" and "Ninja" generators are supported as standard project files. With this change generic solution can be created for all the other supported generators such as CodeBlocks, CodeLite, Eclip