[OE-core] [PATCH] base: improve do_unpack[cleandirs] logic

2018-04-27 Thread Ross Burton
If a recipe sets S to ${WORKDIR}/ then the S != WORKDIR test doesn't work as expected. Use os.path.normpath() to normalise the paths so string comparison works. Signed-off-by: Ross Burton --- meta/classes/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/clas

Re: [OE-core] [PATCH] base: improve do_unpack[cleandirs] logic

2018-04-27 Thread Burton, Ross
enembedded.org] On Behalf Of >> Burton, Ross >> Sent: den 26 april 2018 12:46 >> To: OE-core >> Subject: Re: [OE-core] [PATCH] base: improve do_unpack[cleandirs] logic >> >> Retracting this, doesn't work on a clean build dir. >> >> Ross >>

Re: [OE-core] [PATCH] base: improve do_unpack[cleandirs] logic

2018-04-27 Thread Peter Kjellerstedt
> -Original Message- > From: openembedded-core-boun...@lists.openembedded.org > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of > Burton, Ross > Sent: den 26 april 2018 12:46 > To: OE-core > Subject: Re: [OE-core] [PATCH] base: improve do_un

Re: [OE-core] [PATCH] base: improve do_unpack[cleandirs] logic

2018-04-26 Thread Burton, Ross
Retracting this, doesn't work on a clean build dir. Ross On 25 April 2018 at 14:58, Ross Burton wrote: > If a recipe sets S to ${WORKDIR}/ then the S != WORKDIR test doesn't work as > expected. Use os.path.samefile() instead of string comparisons to do the > right > thing. > > Signed-off-by: R

[OE-core] [PATCH] base: improve do_unpack[cleandirs] logic

2018-04-25 Thread Ross Burton
If a recipe sets S to ${WORKDIR}/ then the S != WORKDIR test doesn't work as expected. Use os.path.samefile() instead of string comparisons to do the right thing. Signed-off-by: Ross Burton --- meta/classes/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/cl