Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-19 Thread McClintock Matthew-B29882
On Sat, Nov 19, 2011 at 1:36 PM, Otavio Salvador wrote: >> This will not work as a post rootfs hook as I've explained before. Let >> me give you a more concrete example: We have a root file stored in >> flash. We use it to boot from on a system with 4 serial ports. We use >> the same image again t

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-19 Thread Koen Kooi
Op 19 nov. 2011, om 19:59 heeft McClintock Matthew-B29882 het volgende geschreven: > On Sat, Nov 19, 2011 at 8:29 AM, Otavio Salvador > wrote: >>> It must be online though in this case? >> >> The code you add needs to be running on target and doesn't work at >> rootfs built time. This is bad a

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-19 Thread Otavio Salvador
On Sat, Nov 19, 2011 at 16:59, McClintock Matthew-B29882 wrote: > On Sat, Nov 19, 2011 at 8:29 AM, Otavio Salvador > wrote: >>> It must be online though in this case? >> >> The code you add needs to be running on target and doesn't work at >> rootfs built time. This is bad and adds more complicat

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-19 Thread McClintock Matthew-B29882
On Sat, Nov 19, 2011 at 1:12 PM, Phil Blundell wrote: >> This works *perfectly* with a read only fs. Each time it boots removes >> the non-working serial ports. One could argue that it does NOT work >> completely as expected with a writable file system. > > Um, the patch you sent seems to modify /

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-19 Thread Phil Blundell
On Sat, 2011-11-19 at 18:59 +, McClintock Matthew-B29882 wrote: > On Sat, Nov 19, 2011 at 8:29 AM, Otavio Salvador > wrote: > >> It must be online though in this case? > > > > The code you add needs to be running on target and doesn't work at > > rootfs built time. This is bad and adds more co

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-19 Thread McClintock Matthew-B29882
On Sat, Nov 19, 2011 at 8:29 AM, Otavio Salvador wrote: >> It must be online though in this case? > > The code you add needs to be running on target and doesn't work at > rootfs built time. This is bad and adds more complications to > read-only-fs support. This works *perfectly* with a read only

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-19 Thread Otavio Salvador
On Fri, Nov 18, 2011 at 00:32, McClintock Matthew-B29882 wrote: > On Thu, Nov 17, 2011 at 6:29 PM, Otavio Salvador > wrote: >> I see your point but add more "must be online" requirements is wrong >> IMO. > > It must be online though in this case? The code you add needs to be running on target an

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-18 Thread Phil Blundell
On Fri, 2011-11-18 at 17:54 +, McClintock Matthew-B29882 wrote: > On Fri, Nov 18, 2011 at 2:07 AM, Phil Blundell wrote: > > if [ true < /dev/ttyS0 ]; then > > This test returns 0 if the serial node is in my device tree or not > (e.g. there or not). That sounds like a shell bug to me. What s

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-18 Thread McClintock Matthew-B29882
On Fri, Nov 18, 2011 at 2:07 AM, Phil Blundell wrote: > if [ true < /dev/ttyS0 ]; then This test returns 0 if the serial node is in my device tree or not (e.g. there or not). -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.o

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-18 Thread Phil Blundell
On Fri, 2011-11-18 at 00:23 +, McClintock Matthew-B29882 wrote: > I'm mostly soliciting ideas for how we detect if a serial port is > actually present besides 'dmesg' I guess the obvious one is to try opening it. Something like: if [ true < /dev/ttyS0 ]; then echo present else echo not p

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-17 Thread McClintock Matthew-B29882
On Thu, Nov 17, 2011 at 6:29 PM, Otavio Salvador wrote: > I see your point but add more "must be online" requirements is wrong > IMO. It must be online though in this case? > This could be done with a specific package that could mangle the > image at first boot if really need but doing it by def

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-17 Thread Otavio Salvador
On Thu, Nov 17, 2011 at 22:23, McClintock Matthew-B29882 wrote: > On Thu, Nov 17, 2011 at 6:08 PM, Otavio Salvador > wrote: >> This enforces online use so won't work for read-only-fs. > > Online use is sort of the point here - I think it should be configurable > though. > >> Please use SERIAL_CO

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-17 Thread McClintock Matthew-B29882
On Thu, Nov 17, 2011 at 6:08 PM, Otavio Salvador wrote: > This enforces online use so won't work for read-only-fs. Online use is sort of the point here - I think it should be configurable though. > Please use SERIAL_CONSOLE value to write iniitab but supporting offline use Already done but some

Re: [OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-17 Thread Otavio Salvador
NACK! This enforces online use so won't work for read-only-fs. Please use SERIAL_CONSOLE value to write iniitab but supporting offline use On Thu, Nov 17, 2011 at 20:47, Matthew McClintock wrote: > This will prevent error message that pop up when the serial > port is not present > --- > This s

[OE-core] [PATCH] Remove ttyS* from /etc/inittab that are not present

2011-11-17 Thread Matthew McClintock
This will prevent error message that pop up when the serial port is not present --- This seems quite hacky to me, but we have an issue where if we remove a serial port from the device tree the serial port won't work. It seems link it's still in /dev/ttySN but it's not configured properly. I looked