Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-10 Thread Naresh Bhat
On 10 March 2015 at 14:42, Bernhard Reutner-Fischer wrote: > On March 9, 2015 9:11:29 AM GMT+01:00, Naresh Bhat > wrote: > > >today/tomorrow. Can we please continue the discussion on my next > >series. Probably you can give me few more points on my next patch > >series. > > Please CC me so i d

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-10 Thread Bernhard Reutner-Fischer
On March 9, 2015 9:11:29 AM GMT+01:00, Naresh Bhat wrote: >today/tomorrow. Can we please continue the discussion on my next >series. Probably you can give me few more points on my next patch >series. Please CC me so i do not overlook the new series, TIA. -- _

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-09 Thread Naresh Bhat
Hi Bernhard Reutner-Fischer, On 5 March 2015 at 21:48, Bernhard Reutner-Fischer wrote: > On 5 March 2015 at 15:06, Naresh Bhat wrote: > if d.getVar('TARGET_ARCH', True) == "aarch64": return Does it make sense ? >>> >>> At least the parser should grok it. >>> The c

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-05 Thread Bernhard Reutner-Fischer
On 5 March 2015 at 15:06, Naresh Bhat wrote: >>>if d.getVar('TARGET_ARCH', True) == "aarch64": >>> return >>> >>>Does it make sense ? >> >> At least the parser should grok it. >> The change itself does not make sense to me either way. > I did this change because it does not make any

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-05 Thread Naresh Bhat
On 4 March 2015 at 12:56, Bernhard Reutner-Fischer wrote: > On March 4, 2015 8:15:15 AM GMT+01:00, Naresh Bhat > wrote: >>On 3 March 2015 at 23:27, Bernhard Reutner-Fischer >> wrote: >>> On 3 March 2015 at 16:46, Naresh Bhat wrote: Build iso image required syslinux package. We have alread

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-05 Thread Naresh Bhat
On 5 March 2015 at 02:07, Burton, Ross wrote: > Hi Naresh, > > On 3 March 2015 at 15:46, Naresh Bhat wrote: >> >> +if [ "${TARGET_ARCH}" == "aarch64" ]: >> + return >> +else: >> +bb.build.exec_func('build_iso', d) > > > As Bernhard says, that isn't valid Python. W

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-04 Thread Burton, Ross
Hi Naresh, On 3 March 2015 at 15:46, Naresh Bhat wrote: > +if [ "${TARGET_ARCH}" == "aarch64" ]: > + return > +else: > +bb.build.exec_func('build_iso', d) > As Bernhard says, that isn't valid Python. Were these patches actually tested? Ross --

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-03 Thread Bernhard Reutner-Fischer
On March 4, 2015 8:15:15 AM GMT+01:00, Naresh Bhat wrote: >On 3 March 2015 at 23:27, Bernhard Reutner-Fischer > wrote: >> On 3 March 2015 at 16:46, Naresh Bhat wrote: >>> Build iso image required syslinux package. We have already skip the >syslinux >>> package. Hence just skip the iso image bu

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-03 Thread Naresh Bhat
On 3 March 2015 at 23:27, Bernhard Reutner-Fischer wrote: > On 3 March 2015 at 16:46, Naresh Bhat wrote: >> Build iso image required syslinux package. We have already skip the syslinux >> package. Hence just skip the iso image build too. >> >> Signed-off-by: Naresh Bhat >> Reviewed-by: Matt Fl

Re: [OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-03 Thread Bernhard Reutner-Fischer
On 3 March 2015 at 16:46, Naresh Bhat wrote: > Build iso image required syslinux package. We have already skip the syslinux > package. Hence just skip the iso image build too. > > Signed-off-by: Naresh Bhat > Reviewed-by: Matt Fleming > --- > meta/classes/bootimg.bbclass |6 +- > 1 fi

[OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

2015-03-03 Thread Naresh Bhat
Build iso image required syslinux package. We have already skip the syslinux package. Hence just skip the iso image build too. Signed-off-by: Naresh Bhat Reviewed-by: Matt Fleming --- meta/classes/bootimg.bbclass |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meta