Re: [OE-core] [PATCH v2] kernel.bbclass: Stop creating empty .scmversion files

2020-04-01 Thread Paul Burton via lists.openembedded.org
Hi Richard, On Wed, Apr 1, 2020 at 4:54 PM Richard Purdie wrote: > I get very nervous about patches like this that come in a day before > the final release build. Absolutely - I would too; I didn't realize a release was imminent & certainly had no expectation this would be part of it. > I'm not

[OE-core] [PATCH v2] kernel.bbclass: Stop creating empty .scmversion files

2020-04-01 Thread Paul Burton via lists.openembedded.org
The kernel_do_configure() task creates empty .scmversion files within both the source & build directories. The presence of these files causes the scm_version function within the kernel's scripts/setlocalversion to always output the empty string, breaking the kernel's CONFIG_LOCALVERSION_AUTO=y func

Re: [OE-core] [PATCH] kernel.bbclass: Stop creating empty .scmversion files

2020-04-01 Thread Paul Burton via lists.openembedded.org
Hi Martin & Bruce, Thanks for your responses & filling in some of the background here. On Tue, Mar 31, 2020 at 6:32 PM Bruce Ashfield wrote: > Also note that in 2017 Trevor Woerner tried exactly the same fix that > you are doing, but ended up retracting it when he found a test case > that was st

[OE-core] [PATCH] kernel.bbclass: Stop creating empty .scmversion files

2020-03-31 Thread Paul Burton via Lists.Openembedded.Org
The kernel_do_configure() function creates empty .scmversion files within both the source & build directories. The presence of these files causes the scm_version function within the kernel's scripts/setlocalversion to always output the empty string, breaking the kernel's CONFIG_LOCALVERSION_AUTO=y