EXTERNAL e-mail address]
>
>On Wed, 2022-06-29 at 16:10 -0400, Aryaman Gupta wrote:
>> Stop the scheduler from starting new tasks if the current cpu or io
>> pressure is above a certain threshold, specified through the
>> "BB_MAX_{CPU|IO}_SOME_PRESSURE" variables in
See my comments in-line below:
From: Jose Quaresma
Sent: Thursday, June 30, 2022 4:32 AM
To: Gupta, Aryaman
Cc: OE-core
Subject: Re: [OE-core] [PATCH] runqueue: add cpu/io pressure regulation
[Please note: This e-mail is from an EXTERNAL e-mail address]
Hi Aryaman,
Aryaman Gupta
#x27;-', 1)
ValueError: not enough values to unpack (expected 2, got 1)
Add an additional check to skip the reduced_proc_pressure directory.
Signed-off-by: Aryaman Gupta
---
meta/lib/oeqa/buildperf/base.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib
ch will have no impact on build times.
Arbitary lower limit of 1.0 results in a fatal error to avoid extremely
long builds. If the percentage limits are higher than 100, then the default
values are used and warnings are issued to inform users that the
specified limit is out of bounds.
Signed-off-by
u'>
Signed-off-by: Aryaman Gupta
---
meta/lib/buildstats.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/lib/buildstats.py b/meta/lib/buildstats.py
index 5d32a81906..99a8303d5e 100644
--- a/meta/lib/buildstats.py
+++ b/meta/lib/buildstats.py
@@ -23,8
Note that the delta total graphs may appear "spikey",
oscillating from high values to low. This behaviour is fixed in a
subsequent commit.
Signed-off-by: Aryaman Gupta
Signed-off-by: Randy MacLeod
---
scripts/pybootchartgui/pybootchartgui/draw.py | 77 +++
.../pybootchar
hence a small numerical difference. For example,
the CPU usage from /proc/stat is a running total of usage and taking the
difference between data collected 0.1 seconds apart would result in usage
appearing lower than it actually was.
Signed-off-by: Aryaman Gupta
Signed-off-by: Randy MacLeod
was collected,
and that the datastore should be updated.
- Expand and explain why min_seconds has a tolerance of 0.01 seconds.
While any testing is useful, it would be better if this change was
tested along with a patch that caused rebuilds to occur.
Regards,
Aryaman Gupta (3):
buildstats.py
ry}.log
mirroring the directory structure of /proc/pressure. If the /proc/pressure
directory does not exist or the resource files can't be read/opened, the
reduced_proc_pressure directory is not created.
Signed-off-by: Aryaman Gupta
Signed-off-by: Randy MacLeod
---
meta/lib/buildstats.py | 57
ry}.log
mirroring the directory structure of /proc/pressure. If the /proc/pressure
directory does not exist or the resource files can't be read/opened, the
reduced_proc_pressure directory is not created.
Signed-off-by: Aryaman Gupta
Signed-off-by: Randy MacLeod
---
meta/lib/buildstats.py | 57
Note that the delta total graphs may appear "spikey",
oscillating from high values to low. This behaviour is fixed in a
subsequent commit.
Signed-off-by: Aryaman Gupta
Signed-off-by: Randy MacLeod
---
scripts/pybootchartgui/pybootchartgui/draw.py | 77 +++
.../pybootchar
actually was.
Signed-off-by: Aryaman Gupta
Signed-off-by: Randy MacLeod
---
meta/classes/buildstats.bbclass | 3 ++-
meta/lib/buildstats.py | 7 ++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass
index
ween the current "total" and
the previous sample's "total" is logged, allowing the measurement of pressure
in between each polling interval, as was done for /proc/stat data. The log files
are stored in
/tmp/buildstats//reduced_proc_pressure/{cpu,io,
;s clear correspondence between the avg10 and delta total
graphs. If the reduced_proc_pressure data is not present in the
buildstats log, then the new charts are not shown at all rather than
being present but unpopulated.
Signed-off-by: Aryaman Gupta
Signed-off-by: Randy MacLeod
---
scripts/pybootc
Status updated but using the existing patch since it is functionally identical.
Signed-off-by: Aryaman Gupta
---
meta/recipes-devtools/e2fsprogs/e2fsprogs/extents.patch | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/extents.patch
b
15 matches
Mail list logo
