[OE-core] [dunfell][PATCH] cryptodev-module: fix build with 5.11+ kernels

2022-08-18 Thread Anuj Mittal
Backport patch to fix: | cryptodev-module/1.10-r0/git/ioctl.c:875:4: error: implicit declaration of function 'ksys_close'; did you mean 'ksys_chown'? [-Werror=implicit-function-declaration] | 875 |ksys_close(fd); | |^~ | |ksys_chown | cc1: some warnings being tr

Re: [OE-core] [PATCH v2] insane.bbclass: Skip patches not in oe-core by full path

2022-08-18 Thread Yang Xu via lists.openembedded.org
Hi Alexandre, Sorry for my neglience. Error caused by the last "/" was eaten by os.path.abspath. I have fixed and submitted PATCH v3. Thank you On Wed, 2022-08-17 at 19:24 +0200, Alexandre Belloni wrote: > Hello, > > This doesn't seem to work as expected: > > https://urldefense.com/v3/__http

[OE-core][kirkstone 26/26] lttng-modules: replace mips compaction fix with upstream change

2022-08-18 Thread Steve Sakoman
From: Bruce Ashfield lttng upstream had a different solution to the compaction build isses seen on mips. We switch our patch for a backport of the upstream solution. (From OE-Core rev: 459f746a198a8ae7840d783f5824fc14a44a8488) Signed-off-by: Bruce Ashfield Signed-off-by: Alexandre Belloni Si

[OE-core][kirkstone 24/26] lttng-modules: fix 5.19+ build

2022-08-18 Thread Steve Sakoman
From: Bruce Ashfield We need to backport three patches from the lttng upstream tree to fix the build against 5.19+. Obviously we'll drop these once the next lttng-modules release is available. (From OE-Core rev: dce3c772efab4e51a82fb9c8fb74bc614ee3a82e) Signed-off-by: Bruce Ashfield Signed-of

[OE-core][kirkstone 25/26] lttng-modules: fix build against mips and v5.19 kernel

2022-08-18 Thread Steve Sakoman
From: Bruce Ashfield When building against a v5.19 mips kernel, the following errors were triggered: | lttng-modules-2.13.4/src/probes/../../include/instrumentation/events/compaction.h:105:42: note: expected 'struct compact_control *' but argument is of type 'struct compact_control *' |

[OE-core][kirkstone 23/26] selftest/wic: Tweak test case to not depend on kernel size

2022-08-18 Thread Steve Sakoman
From: Richard Purdie The current test assumes the kernel size leaves a certain amount of whitespace in the output. Improve this constraint so a slightly larger kernel doesn't fail the test. Signed-off-by: Richard Purdie (cherry picked from commit bd60c44bef4a1b5d3c8fe77a9e6d3a8f43b0dea4) Signed

[OE-core][kirkstone 22/26] relocate_sdk.py: ensure interpreter size error causes relocation to fail

2022-08-18 Thread Steve Sakoman
From: Paul Eggleton If there is insufficent space to change the interpreter, we were printing an error here but the overall script did not return an error code, and thus the SDK installation appeared to succeed - but some of the binaries will not be in a working state. Allow the relocation to pro

[OE-core][kirkstone 21/26] nativesdk: Clear TUNE_FEATURES

2022-08-18 Thread Steve Sakoman
From: Richard Purdie Similarly to what native.bbclass does, clear TUNE_FEATURES since these aren't appropriate to the nativesdk build. This saves us having to change down signature issues due to data in this variable. Signed-off-by: Richard Purdie (cherry picked from commit 2e5079e434504a3a22b6

[OE-core][kirkstone 20/26] scripts/oe-setup-builddir: make it known where configurations come from

2022-08-18 Thread Steve Sakoman
From: Alexander Kanavin "with some default values" isn't clear; if the user wants to change or inspect the default values and their history, we should help them find where they are. This becomes especially important when using template configs other than poky's. Signed-off-by: Alexander Kanavin

[OE-core][kirkstone 19/26] cmake: remove CMAKE_ASM_FLAGS variable in toolchain file

2022-08-18 Thread Steve Sakoman
From: Martin Beeger As discussied in [YOCTO #14717] cmake contains a OEToolchainConfig.cmake file to configure the toolchain correctly in cross-compile build for recipes using cmake. The CMAKE_ASM_FLAGS are the configuration are meant for assembly, but the spelling is incorrect and the Flag is A

[OE-core][kirkstone 18/26] boost: fix install of fiber shared libraries

2022-08-18 Thread Steve Sakoman
From: Mikko Rapeli For fiber, only CMake modules were installed in boost 1.78.0. In 1.79.0 and versions before 1.78.0 also the shared libraries are installed. This upstream patch fixes the issue in 1.78.0. Note that boost git repo does not show changes in tools/build directory between 1.78.0 and

[OE-core][kirkstone 17/26] create-spdx: ignore packing control files from ipk and deb

2022-08-18 Thread Steve Sakoman
From: Jose Quaresma Otherwise spdx can have references for data that is not packed in the package delivered because this contol data is temporarly and only exist while the package is been write. During do_package_write_ipk task in do_package_ipk the control files is cleaned up at the end. This c

[OE-core][kirkstone 16/26] create-spdx: Fix supplier field

2022-08-18 Thread Steve Sakoman
From: Mihai Lindner The correct field name is "supplier" according to SPDX schema. The "supplier" field translates to "PackageSupplier", but that's for tag-value format. Signed-off-by: Mihai Lindner Signed-off-by: Richard Purdie (cherry picked from commit ca8db0e0a2860ac1e3f537471fa71b43c3be0a

[OE-core][kirkstone 15/26] archiver.bbclass: remove unsed do_deploy_archives[dirs]

2022-08-18 Thread Steve Sakoman
From: Jose Quaresma Remove as commit b3afe7d redifines it. https://git.openembedded.org/openembedded-core/commit/?id=b3afe7d9bd25a943e947de3ec064ea245173c5a8 Signed-off-by: Jose Quaresma Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie (cherry picked from commit cf5e155a9c76a6e

[OE-core][kirkstone 14/26] runqemu: Add missing space on default display option

2022-08-18 Thread Steve Sakoman
From: Mark Hatle Signed-off-by: Mark Hatle Signed-off-by: Mark Hatle Signed-off-by: Luca Ceresoli Signed-off-by: Richard Purdie (cherry picked from commit ee9428611fc38bc711b5b3e12cf0d3257b1b5680) Signed-off-by: Steve Sakoman --- scripts/runqemu | 2 +- 1 file changed, 1 insertion(+), 1 del

[OE-core][kirkstone 13/26] devtool/upgrade: catch bb.fetch2.decodeurl errors

2022-08-18 Thread Steve Sakoman
From: Alexander Kanavin Otherwise, workspace cleanup (removing bogus recipe and source tree) will not happen, leaving breakage behind. Signed-off-by: Alexander Kanavin Signed-off-by: Luca Ceresoli (cherry picked from commit 74774f9b67580a8c56f605dfd4cc7b856bbeeae8) Signed-off-by: Steve Sakoman

[OE-core][kirkstone 12/26] devtool/upgrade: correctly clean up when recipe filename isn't yet known

2022-08-18 Thread Steve Sakoman
From: Alexander Kanavin There is a coding error in the second invocation of _upgrade_error: rf is passed into it before it is initialized in the try: block. And so bogus recipes are left behind in the workspace, causing breakage. Instead, rewrite the functions to take the recipe directory name i

[OE-core][kirkstone 10/26] vim: update from 9.0.0063 to 9.0.0115

2022-08-18 Thread Steve Sakoman
From: Randy MacLeod Drop crosscompile.patch which was merged as part of: 509695c1c (tag: v9.0.0065) patch 9.0.0065: \ cross-compiling doesn't work because of timer_create check Also drop: racefix.patch which may have been fixed upstream and is being tracked by: https://github.com/vim

[OE-core][kirkstone 11/26] devtool: error out when workspace is using old override syntax

2022-08-18 Thread Steve Sakoman
From: Roland Hieber When the workspace bbappends are still using the old override syntax with EXTERNALSRC_pn-*, externalsrc_re will not match, and pn will never be assigned, leading to a nondescript UnboundLocalError being raised on the user's terminal. Try to detect that situation and give the u

[OE-core][kirkstone 09/26] zlib: CVE-2022-37434 a heap-based buffer over-read

2022-08-18 Thread Steve Sakoman
From: Hitendra Prajapati Source: https://github.com/madler/zlib MR: 120525 Type: Security Fix Disposition: Backport from https://github.com/madler/zlib/commit/eff308af425b67093bab25f80f1ae950166bece1 & https://github.com/madler/zlib/commit/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d ChangeID: 94d9

[OE-core][kirkstone 08/26] gnutls: CVE-2022-2509 Double free during gnutls_pkcs7_verify

2022-08-18 Thread Steve Sakoman
From: Hitendra Prajapati Source: https://gitlab.com/gnutls/gnutls MR: 120416 Type: Security Fix Disposition: Backport from https://gitlab.com/gnutls/gnutls/-/commit/ce37f9eb265dbe9b6d597f5767449e8ee95848e2 ChangeID: 703e01956915cf9543fdc47cfd5edb87403294f9 Description: CVE-2022-2509 gn

[OE-core][kirkstone 07/26] u-boot: fix CVE-2022-33103

2022-08-18 Thread Steve Sakoman
From: Sakib Sajal Backport patch to resolve CVE-2022-33103. Signed-off-by: Sakib Sajal Signed-off-by: Steve Sakoman --- ..._read-Prevent-arbitrary-code-executi.patch | 80 +++ meta/recipes-bsp/u-boot/u-boot_2022.01.bb | 1 + 2 files changed, 81 insertions(+) create mode

[OE-core][kirkstone 06/26] qemu: fix CVE-2022-0216

2022-08-18 Thread Steve Sakoman
From: Sakib Sajal Backport relevant patches to fix CVE-2022-0216. Signed-off-by: Sakib Sajal Signed-off-by: Steve Sakoman --- meta/recipes-devtools/qemu/qemu.inc | 2 + .../qemu/qemu/CVE-2022-0216_1.patch | 42 +++ .../qemu/qemu/CVE-2022-0216_2.patch

[OE-core][kirkstone 05/26] qemu: fix CVE-2022-0358

2022-08-18 Thread Steve Sakoman
From: Sakib Sajal Backport patch to fix CVE-2022-0358. Signed-off-by: Sakib Sajal Signed-off-by: Steve Sakoman --- meta/recipes-devtools/qemu/qemu.inc | 1 + .../qemu/qemu/CVE-2022-0358.patch | 106 ++ 2 files changed, 107 insertions(+) create mode 100

[OE-core][kirkstone 04/26] qemu: fix CVE-2021-4158

2022-08-18 Thread Steve Sakoman
From: Sakib Sajal Backport patch to fix CVE-2021-4158. Signed-off-by: Sakib Sajal Signed-off-by: Steve Sakoman --- meta/recipes-devtools/qemu/qemu.inc | 1 + .../qemu/qemu/CVE-2021-4158.patch | 46 +++ 2 files changed, 47 insertions(+) create mode 10064

[OE-core][kirkstone 03/26] qemu: fix CVE-2021-3929

2022-08-18 Thread Steve Sakoman
From: Sakib Sajal Backport patch to fix CVE-2021-3929. Signed-off-by: Sakib Sajal Signed-off-by: Steve Sakoman --- meta/recipes-devtools/qemu/qemu.inc | 1 + .../qemu/qemu/CVE-2021-3929.patch | 70 +++ 2 files changed, 71 insertions(+) create mode 10064

[OE-core][kirkstone 02/26] qemu: fix CVE-2021-3507

2022-08-18 Thread Steve Sakoman
From: Sakib Sajal Backport relevant patches to fix CVE-2021-3507. Signed-off-by: Sakib Sajal Signed-off-by: Steve Sakoman --- meta/recipes-devtools/qemu/qemu.inc | 2 + .../qemu/qemu/CVE-2021-3507_1.patch | 92 ++ .../qemu/qemu/CVE-2021-3507_2.patch

[OE-core][kirkstone 01/26] gdk-pixbuf: CVE-2021-46829 a heap-based buffer overflow

2022-08-18 Thread Steve Sakoman
From: Hitendra Prajapati Source: https://gitlab.gnome.org/GNOME/gdk-pixbuf MR: 120379 Type: Security Fix Disposition: Backport from https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/5398f04d772f7f8baf5265715696ed88db0f0512 ChangeID: 37f962b51bdb0c522b2a991c549fd29e3d2e58d7 Description:

[OE-core][kirkstone 00/26] Patch review

2022-08-18 Thread Steve Sakoman
Please review this set of patches for kirkstone and have comments back by end of day Monday. Passed a-full on autobuilder: https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/4106 The following changes since commit 2cafa6ed5f0aa9df5a120b6353755d56c7c7800d: build-appliance-image:

[OE-core] [PATCH] binutils: Disable gprofng on musl systems

2022-08-18 Thread Khem Raj
disable gprofng, as it depends on few glibc apis | ../../../gprofng/libcollector/../src/collector_module.h:78:13: error: duplicate member 'pwrite' |78 | ssize_t (*pwrite64)(); | | ^~~~ | ../../../gprofng/libcollector/dispatcher.c: In function 'collector_timer_create':

Re: [OE-core] [PATCH] vulkan-samples: enable network during do_unpack

2022-08-18 Thread Alexander Kanavin
The ticket is RESOLVED/FIXED, which is surely not the case here? Alex On Thu, 18 Aug 2022 at 21:45, Martin Jansa wrote: > > There is ticket about this already, see > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14283 > > On Thu, Aug 18, 2022 at 9:02 AM Julien STEPHAN wrote: >> >> >> >> Le

Re: [OE-core] [PATCH] vulkan-samples: enable network during do_unpack

2022-08-18 Thread Martin Jansa
There is ticket about this already, see https://bugzilla.yoctoproject.org/show_bug.cgi?id=14283 On Thu, Aug 18, 2022 at 9:02 AM Julien STEPHAN wrote: > > > Le mer. 17 août 2022 à 22:33, Alexander Kanavin > a écrit : > >> I reproduced. This happens if all three are true: >> - recipe is using git

[OE-core] [PATCH] musl: Update to tip

2022-08-18 Thread Khem Raj
brings in these fixes * 37e18b7b freopen: reset stream orientation (byte/wide) and encoding rule * bf992585 ldso: process RELR only for non-FDPIC archs * d32dadd6 ldso: support DT_RELR relative relocation format * 2404d9d6 use syscall_arg_t and __scc macro for arguments to __alt_socketcall Signed

[OE-core] [PATCH] webkitgtk: Upgrade to 2.36.6 minor update

2022-08-18 Thread Khem Raj
Signed-off-by: Khem Raj --- .../webkit/{webkitgtk_2.36.5.bb => webkitgtk_2.36.6.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta/recipes-sato/webkit/{webkitgtk_2.36.5.bb => webkitgtk_2.36.6.bb} (98%) diff --git a/meta/recipes-sato/webkit/webkitgtk_2.36.5.bb b/meta

Re: [OE-core][PATCH 2/2] openssh: add support for config snippet includes to ssh and sshd

2022-08-18 Thread Khem Raj
On Thu, Aug 18, 2022 at 4:21 AM Jan Luebbe wrote: > > This makes it simpler to set specific ssh/sshd config options by adding > snippet files to /etc/ssh/ssh_config.d/ or /etc/ssh/sshd_config.d/ > instead of modifying a copy of the full configuration file. As new > snippets can be added from separ

Re: [OE-core][PATCH] rng-tools: Change "Requires" to "WantedBy" for dev-hwrng.device

2022-08-18 Thread Alexander Kanavin
I am definitely seeing a serious regression where qemu images get stuck for 4 minutes on boot waiting for /dev/hwrng, so if this is fixing the issue, I'd appreciate getting it in! Alex On Mon, 15 Aug 2022 at 20:48, Khem Raj wrote: > > On Mon, Aug 15, 2022 at 11:30 AM Drew Moseley wrote: > > > >

[OE-core][dunfell 11/11] initscripts: run umountnfs as a KILL script

2022-08-18 Thread Steve Sakoman
From: Shruthi Ravichandran `rc` runs all the KILL scripts in a runlevel before the START scripts. The umountnfs script is currently configured as a START script, and runs after the networking KILL script. During shutdown, this causes a ~3 minute timeout after networking is shutdown when the syste

[OE-core][dunfell 10/11] rootfs-postcommands.bbclass: move host-user-contaminated.txt to ${S}

2022-08-18 Thread Steve Sakoman
From: Ming Liu This is to ensure host-user-contaminated.txt would be removed before do_rootfs runs, since ${S} is in cleandirs of do_rootfs, otherwise, a host-user-contaminated.txt file that generated from previous builds could be used which is wrong. Signed-off-by: Ming Liu Signed-off-by: Alex

[OE-core][dunfell 09/11] bin_package: install into base_prefix

2022-08-18 Thread Steve Sakoman
From: Pascal Bach This makes the bin_package.bbclass work properly with the native class. Signed-off-by: Pascal Bach Signed-off-by: Richard Purdie (cherry picked from commit ad330b6d4b6e2ba051b5c6c437e07a183831f757) Signed-off-by: Steve Sakoman --- meta/classes/bin_package.bbclass | 3 ++- 1

[OE-core][dunfell 08/11] kernel-arch: Fix buildpaths leaking into external module compiles

2022-08-18 Thread Steve Sakoman
From: Richard Purdie Building external kernel modules like lttng-modules was showing build paths inside the debug symbols for the modules and breaking build reproducibility. Fix this by adding in the mapping needed to map the kernel build directory to something more approriate on target. Signed

[OE-core][dunfell 07/11] linux-firwmare: restore WHENCE_CHKSUM variable

2022-08-18 Thread Steve Sakoman
From: Dmitry Baryshkov Restore WHENCE_CHKSUM variable which is used to hold the WHENCE file checksum. It is necessary to allow easily overriding it from local.conf if the devupstream version is selected: PREFERRED_VERSION_linux-firmware = "1:20220708+git%" SRCREV:class-devupstream = "${AUTOREV}"

[OE-core][dunfell 06/11] linux-firmware: update 20220610 -> 20220708

2022-08-18 Thread Steve Sakoman
From: Alexander Kanavin License-Update: a few obsolete firmware were dropped (particularly i2400m and tda7706), file list updates. Signed-off-by: Alexander Kanavin Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie (cherry picked from commit e89fb37e13fcb832ee7d35e7d92d45eaca20689

[OE-core][dunfell 05/11] vim: update from 9.0.0063 to 9.0.0115

2022-08-18 Thread Steve Sakoman
From: Randy MacLeod Drop crosscompile.patch which was merged as part of: 509695c1c (tag: v9.0.0065) patch 9.0.0065: \ cross-compiling doesn't work because of timer_create check Also drop: racefix.patch which may have been fixed upstream and is being tracked by: https://github.com/vim

[OE-core][dunfell 04/11] vim: Upgrade 9.0.0021 -> 9.0.0063

2022-08-18 Thread Steve Sakoman
From: Richard Purdie Pulls in several CVE fixes. Added a patch to avoid timer_create cross compile issue (and submitted upstream). Also submit the race fix upstream. We disable timer_create in the native case since some systems have it and some don't so this makes us consistent. Signed-off-by:

[OE-core][dunfell 03/11] zlib: CVE-2022-37434 a heap-based buffer over-read

2022-08-18 Thread Steve Sakoman
From: Hitendra Prajapati Source: https://github.com/madler/zlib MR: 120531 Type: Security Fix Disposition: Backport from https://github.com/madler/zlib/commit/eff308af425b67093bab25f80f1ae950166bece1 & https://github.com/madler/zlib/commit/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d ChangeID: 364c

[OE-core][dunfell 02/11] gnutls: CVE-2022-2509 Double free during gnutls_pkcs7_verify

2022-08-18 Thread Steve Sakoman
From: Hitendra Prajapati Source: https://gitlab.com/gnutls/gnutls MR: 120421 Type: Security Fix Disposition: Backport from https://gitlab.com/gnutls/gnutls/-/commit/ce37f9eb265dbe9b6d597f5767449e8ee95848e2 ChangeID: f0c84c6aa8178582ac9838c453dacdf2c7cae0e5 Description: CVE-2022-2509 gn

[OE-core][dunfell 01/11] qemu: CVE-2020-27821 heap buffer overflow in msix_table_mmio_write

2022-08-18 Thread Steve Sakoman
From: Hitendra Prajapati Source: https://git.qemu.org/?p=qemu.git; MR: 107558 Type: Security Fix Disposition: Backport from https://git.qemu.org/?p=qemu.git;a=commit;h=4bfb024bc76973d40a359476dc0291f46e435442 ChangeID: c5d25422f43edb7d8728118eb482eba09474ef2c Description: CVE-2020-2782

[OE-core][dunfell 00/11] Patch review

2022-08-18 Thread Steve Sakoman
Please review this set of patches for dunfell and have comments back by end of day Sunday. This is the final patch set for the 3.1.19 release. Passed a-full on autobuilder: https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/4098 The following changes since commit ac6ea1a96645d2a4

Re: [OE-core] [PATCH] distrooverrides.bbclass: use IMAGE_CLASSES

2022-08-18 Thread Richard Purdie
On Thu, 2022-08-18 at 09:54 +0800, kai wrote: > On 8/16/22 22:55, Christopher Larson wrote: >   > > This class functionality isn't limited to images. > If not, it may need to move to classes-global. Otherwise it fails to > parse: > ERROR: ParseError in configuration INHERITs: Could not inherit file

[OE-core][PATCH 1/2] openssh: sync local ssh_config + sshd_config files with upstream 8.7p1

2022-08-18 Thread Jan Luebbe
Changes are caused by the removal of deprecated options. ChallengeResponseAuthentication was replaced by KbdInteractiveAuthentication in the SSHv2 protocol, see https://www.openssh.com/txt/release-8.7 Signed-off-by: Jan Luebbe --- .../openssh/openssh/ssh_config| 4 ++-- ...

[OE-core][PATCH 2/2] openssh: add support for config snippet includes to ssh and sshd

2022-08-18 Thread Jan Luebbe
This makes it simpler to set specific ssh/sshd config options by adding snippet files to /etc/ssh/ssh_config.d/ or /etc/ssh/sshd_config.d/ instead of modifying a copy of the full configuration file. As new snippets can be added from separate recipes, targeted changes can be done in multiple layers.

Re: [OE-core] [PATCH 2/5] meta/files: add layer setup JSON schema and example

2022-08-18 Thread Richard Purdie
On Thu, 2022-08-18 at 10:24 +0200, Alexander Kanavin wrote: > On Thu, 18 Aug 2022 at 00:27, Richard Purdie > wrote: > > > It does, thanks. I'm just not sure we're quite in the right place with > > things. I know in your other reply you say we have to start somewhere > > and we can change things.

[OE-core][kirkstone][PATCH] python3-pip: Fix RDEPENDS after the update

2022-08-18 Thread Jose Quaresma
From: Daiane Angolini Fix the following error messages: ModuleNotFoundError: No module named 'distutils' ModuleNotFoundError: No module named 'colorsys' Signed-off-by: Daiane Angolini Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie (cherry picked from commit 8beef93e6e3

Re: [OE-core] [PATCH 2/5] meta/files: add layer setup JSON schema and example

2022-08-18 Thread Alexander Kanavin
On Thu, 18 Aug 2022 at 00:27, Richard Purdie wrote: > It does, thanks. I'm just not sure we're quite in the right place with > things. I know in your other reply you say we have to start somewhere > and we can change things. I also know the screaming if we try and > remove something later... Rig

[OE-core][PATCH] docs: add a comment to ensure CONNECTIVITY_CHECK_URIS is correct

2022-08-18 Thread Shubham Kulkarni
In sanity.bbclass, in function check_connectivity : Connectivity is tested by fetching URIs in variable CONNECTIVITY_CHECK_URIS. If none is accessible, the status error is ambiguous. It says to ensure the host's network is correctly configured but never if the remote is available. Signed-off-by:

Re: [OE-core] [PATCH] vulkan-samples: enable network during do_unpack

2022-08-18 Thread Julien STEPHAN
Le mer. 17 août 2022 à 22:33, Alexander Kanavin a écrit : > I reproduced. This happens if all three are true: > - recipe is using gitsm:// > - one of the submodules contains lfs objects > - git-lfs is installed on the host (that's why it's not seen on the AB) > > Nice! I figured out the first two