Re: [OE-core] backfill mechanism

2017-12-01 Thread Peter Kjellerstedt
Be careful with the _remove operator in common configuration files. Once it has been used there is absolutely no way of getting the removed value back in, for testing or for real. E.g., if you were to change the: DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit" in poky-tiny.conf to: DISTRO

Re: [OE-core] [PATCH 4/5] musl: Update to 1.1.18

2017-12-01 Thread Andre McCurdy
On Fri, Dec 1, 2017 at 4:37 PM, Khem Raj wrote: > On Fri, Dec 1, 2017 at 4:31 PM, Andre McCurdy wrote: >> On Wed, Nov 8, 2017 at 5:58 PM, Khem Raj wrote: >>> Rich Felker (9): >>> fix access by setjmp and longjmp to __hwcap on arm built as thumb2 >>> for executing init array functions

Re: [OE-core] [PATCH 4/5] musl: Update to 1.1.18

2017-12-01 Thread Khem Raj
On Fri, Dec 1, 2017 at 4:31 PM, Andre McCurdy wrote: > On Wed, Nov 8, 2017 at 5:58 PM, Khem Raj wrote: >> Rich Felker (9): >> fix access by setjmp and longjmp to __hwcap on arm built as thumb2 >> for executing init array functions, use function type with prototype >> fix read-af

[OE-core] [morty][RESEND][PATCH] gnutls_3.5.3.bb: Fix native build on distro with kernel < 3.4.17

2017-12-01 Thread Martin Jansa
From: Khem Raj When using distros which use old kernels gnutls fails to build due to missing SYS_getrandom, therefore we need to check for this before using it. Fixes errorr e.g. | ../../../gnutls-3.5.3/lib/nettle/rnd-linux.c: In function 'have_getrandom': | ../../../gnutls-3.5.3/lib/nettle/rnd-

Re: [OE-core] [PATCH 4/5] musl: Update to 1.1.18

2017-12-01 Thread Andre McCurdy
On Wed, Nov 8, 2017 at 5:58 PM, Khem Raj wrote: > Rich Felker (9): > fix access by setjmp and longjmp to __hwcap on arm built as thumb2 > for executing init array functions, use function type with prototype > fix read-after-free type error in pthread_detach > fix incorrect

Re: [OE-core] ✗ patchtest: failure for initramfs-framework installation improvements (rev4)

2017-12-01 Thread Martin Jansa
Is it trying to apply whole series (including the 2 patches which were already merged to master and actually introduced the issue I was trying to fix)? Does it mean that I cannot send a fix into the e-mail thread where the issue was introduced and discussed? Regards, On Fri, Dec 1, 2017 at 11:02

Re: [OE-core] [PATCH 3/3 V2] initramfs-framework: add install module

2017-12-01 Thread Cal Sullivan
My bad. I was using initramfs-module-install-efi as a template when I shouldn't have. I see you already sent a patch addressing the issue. Looks good, and thanks for that. --- Cal On 12/01/2017 01:01 PM, Martin Jansa wrote: Why does it inherit allarch when it depends on TUNE_PKGARCH grub and

[OE-core] ✗ patchtest: failure for initramfs-framework installation improvements (rev4)

2017-12-01 Thread Patchwork
== Series Details == Series: initramfs-framework installation improvements (rev4) Revision: 4 URL : https://patchwork.openembedded.org/series/9783/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have

[OE-core] [PATCH] initramfs-module-install: Remove allarch and FILESEXTRAPATHS

2017-12-01 Thread Martin Jansa
* files is already included in default FILESPATH * it cannot inherit allarch as it RDEPENDS on bunch of TUNE_PKGARCH packages * use the same COMPATIBLE_HOST restrictions as grub has to prevent ERRORs in bitbake world ERROR: Nothing RPROVIDES 'grub' (but oe-core/meta/recipes-core/initrdscripts/

Re: [OE-core] [PATCH] musl: prevent errors if do_install is run more than once

2017-12-01 Thread Khem Raj
On Fri, Dec 1, 2017 at 1:22 PM Matthew McClintock wrote: > On Fri, Dec 1, 2017 at 2:13 PM, Khem Raj wrote: > > On Fri, Dec 1, 2017 at 11:30 AM, Andre McCurdy > wrote: > >> On Fri, Dec 1, 2017 at 3:07 AM, Burton, Ross > wrote: > >>> Extend lnr to have a --force option? > >> > >> Is there ever a

Re: [OE-core] [PATCH] musl: prevent errors if do_install is run more than once

2017-12-01 Thread Matthew McClintock
On Fri, Dec 1, 2017 at 2:13 PM, Khem Raj wrote: > On Fri, Dec 1, 2017 at 11:30 AM, Andre McCurdy wrote: >> On Fri, Dec 1, 2017 at 3:07 AM, Burton, Ross wrote: >>> Extend lnr to have a --force option? >> >> Is there ever a case where we want lnr to fail if the target already exists? >> >> There a

Re: [OE-core] [PATCH 5/5] lib/oe/package.py: is_elf: Make it less prone to false positives

2017-12-01 Thread Olof Johansson
On 17-12-01 11:43 -0600, Mark Hatle wrote: > The original implementation did not include the ',' options because different > versions of file (as well as different architectures) would return different > strings. > > They all contains the same information, but order and inclusion of ',' changed >

Re: [OE-core] [PATCH 3/3 V2] initramfs-framework: add install module

2017-12-01 Thread Martin Jansa
Why does it inherit allarch when it depends on TUNE_PKGARCH grub and other packages? Also it should repect the restrictions which are in grub recipe: COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*)-(linux.*|freebsd.*)' COMPATIBLE_HOST_armv7a = 'null' COMPATIBLE_HOST_armv7ve = 'null' because

Re: [OE-core] [PATCH] musl: prevent errors if do_install is run more than once

2017-12-01 Thread Khem Raj
On Fri, Dec 1, 2017 at 11:30 AM, Andre McCurdy wrote: > On Fri, Dec 1, 2017 at 3:07 AM, Burton, Ross wrote: >> Extend lnr to have a --force option? > > Is there ever a case where we want lnr to fail if the target already exists? > > There are plenty of existing examples in oe-core where rm is run

Re: [OE-core] [PATCH] bitbake.conf: set more conservative default for IMAGE_FSTYPES_DEBUGFS

2017-12-01 Thread Andre McCurdy
On Tue, Nov 7, 2017 at 2:35 PM, Andre McCurdy wrote: > On Fri, Oct 27, 2017 at 2:50 PM, Andre McCurdy wrote: >> Setting IMAGE_FSTYPES_DEBUGFS to the same value as IMAGE_FSTYPES can >> lead to creating a large number of DEBUGFS filesystem images, many of >> which may not make much sense (or may no

Re: [OE-core] [PATCH] musl: prevent errors if do_install is run more than once

2017-12-01 Thread Andre McCurdy
On Fri, Dec 1, 2017 at 3:07 AM, Burton, Ross wrote: > Extend lnr to have a --force option? Is there ever a case where we want lnr to fail if the target already exists? There are plenty of existing examples in oe-core where rm is run before lnr (and in the cases where it's not, it's perhaps just

Re: [OE-core] [PATCH 5/5] lib/oe/package.py: is_elf: Make it less prone to false positives

2017-12-01 Thread Mark Hatle
On 12/1/17 9:50 AM, Olof Johansson wrote: > Avoid matching substrings that are picked up from paths, for instance. > Do this by anchoring the tokens we look for (e.g "executable" or "not > stripped") with whitespace and punctuation. > > Submitted with this patch series is a change that adds the us

[OE-core] [PATCH 3/3] utils: qemurunner.py: cleanup grammar and ensure consistency

2017-12-01 Thread Mark Asselstine
Minor grammar correction along with making the term 'login banner' consistent throughout to make searching logs easier. Signed-off-by: Mark Asselstine --- meta/lib/oeqa/utils/qemurunner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oeqa/utils/qemurunner.py b/me

[OE-core] [PATCH 2/3] utils: qemurunner.py: Log both 'failed to reach login banner" reasons

2017-12-01 Thread Mark Asselstine
The current logging always assumes the boot timeout has expired yet there is a second reason we might have ended up in a position where no login banner was found, that being a socket disconnect. Add logging for the disconnect case and make the timeout expiration conditional on the timeout being exh

[OE-core] [PATCH 1/3] utils: qemurunner.py: Add wall clock to 'timeout' logging

2017-12-01 Thread Mark Asselstine
When debugging issues when timeouts are involved it is always best to have wall clock times included. This helps give confidence that the timeout is in fact run down at the right rate and that no unexpected events were the true cause of a premature running down of the timeout. Having these times in

Re: [OE-core] [PATCH 1/1] ltp: add runtime depends ltp-staticdev

2017-12-01 Thread Burton, Ross
On 1 December 2017 at 14:51, Khem Raj wrote: > On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du > wrote: > > The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in > > ltp-staticdev package. > > > > perhaps its better to create a packaging exception to include this static > library to be

Re: [OE-core] [PATCH 1/1] ltp: add runtime depends ltp-staticdev

2017-12-01 Thread Tim Orling
On Fri, Dec 1, 2017 at 6:52 AM Khem Raj wrote: > On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du > wrote: > > The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in > > ltp-staticdev package. > > > > perhaps its better to create a packaging exception to include this static > library to

[OE-core] [PATCH 1/5] lib/oe/package.py: Expose is_elf

2017-12-01 Thread Olof Johansson
is_elf/isELF had copies in both staging.bbclass and package.bbclass. After recent refactoring in staging.bbclass (involving breaking out the isELF function to is_elf in lib/oe/package.py), the implementions diverged. It would be beneficial to make everybody use this one implementation, so let's exp

[OE-core] [PATCH 2/5] package.bbclass: Make use of common is_elf function

2017-12-01 Thread Olof Johansson
The isELF and is_elf function share a common ancestry, but have diverged. Let's use the implementation from oe.package. Signed-off-by: Olof Johansson --- meta/classes/package.bbclass | 40 +--- 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/met

[OE-core] [PATCH 4/5] lib/oe/package.py: is_elf: Disallow shell specials to be expanded

2017-12-01 Thread Olof Johansson
By using single quotes instead of double quotes, we don't have to worry about escaping dangerous characters, other than ' itself. Signed-off-by: Olof Johansson --- meta/lib/oe/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oe/package.py b/meta/lib/oe/pack

[OE-core] [PATCH 0/5] Improve isELF, gets triggered by ELF anywhere in pathname

2017-12-01 Thread Olof Johansson
If the substring "ELF" is found anywhere in the pathname, the isELF function would identify the file as an ELF file. The function could also be used to execute arbitrary shell commands as the user running bitbake, since the file execution allows processing of shell meta characters like variable exp

[OE-core] [PATCH 5/5] lib/oe/package.py: is_elf: Make it less prone to false positives

2017-12-01 Thread Olof Johansson
Avoid matching substrings that are picked up from paths, for instance. Do this by anchoring the tokens we look for (e.g "executable" or "not stripped") with whitespace and punctuation. Submitted with this patch series is a change that adds the use of --brief to file. This removes the path prefix t

[OE-core] [PATCH 3/5] lib/oe/package.py: is_elf: Don't let filename influence filetype

2017-12-01 Thread Olof Johansson
The is_elf function is simply looking for the substring ELF in the output from file. But file, by default, prefixes the outut with the filename. If the filename containts the substring ELF anywhere, is_elf would identify it as a ELF. The --brief (or -b) flag of GNU's file utility makes file not pr

Re: [OE-core] [PATCH 1/1] ltp: add runtime depends ltp-staticdev

2017-12-01 Thread Khem Raj
On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du wrote: > The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in > ltp-staticdev package. > perhaps its better to create a packaging exception to include this static library to be packaged into ${PN} > Signed-off-by: Dengke Du > --- > met

[OE-core] [PATCH] xserver-xf86-config: remove last trace of 10-preload-modules.conf

2017-12-01 Thread Ross Burton
This file has been removed but the CONFFILES assignment for it wasn't. Signed-off-by: Ross Burton --- meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb | 1 - 1 file changed, 1 deletion(-) diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb b/meta/recipes-gra

[OE-core] [PATCH] initramfs-framework: Add exec module

2017-12-01 Thread Otavio Salvador
This new module allow for easy execution of external scripts or applications. It runs anything found in /exec.d directory in order and in case of no scripts to be available, it opens a shell. Signed-off-by: Otavio Salvador --- .../initrdscripts/initramfs-framework/exec | 29

[OE-core] [PATCH 1/3] grub-efi: Rework GRUB_BUILTIN variable as it is too long

2017-12-01 Thread Otavio Salvador
As we will add new values here, it is better to split it in multiple lines. Signed-off-by: Otavio Salvador --- Changes in v2: - rebase on top of master meta/recipes-bsp/grub/grub-efi_2.02.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/recipes-bsp/grub/grub-efi_2

[OE-core] [PATCH 3/3] grub: Move grub-editenv packaging to grub2.inc

2017-12-01 Thread Otavio Salvador
The editenv utility must be available on grub and grub-efi so we better have it inside the grub2.inc file to avoid the duplication of metadata. Signed-off-by: Otavio Salvador --- Changes in v2: None meta/recipes-bsp/grub/grub2.inc| 6 ++ meta/recipes-bsp/grub/grub_2.02.bb | 6 +- 2

[OE-core] [PATCH 2/3] grub-efi: Add loadenv and test as default built-in

2017-12-01 Thread Otavio Salvador
To allow scripting and environment changes, the loadenv and test must be enabled. This adds those to the default set. Signed-off-by: Otavio Salvador --- Changes in v2: None meta/recipes-bsp/grub/grub-efi_2.02.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-b

Re: [OE-core] [PATCH] musl: prevent errors if do_install is run more than once

2017-12-01 Thread Burton, Ross
Extend lnr to have a --force option? Ross On 30 November 2017 at 22:59, Andre McCurdy wrote: > On Thu, Nov 30, 2017 at 1:51 PM, Khem Raj wrote: > > On Thu, Nov 30, 2017 at 12:20 PM, Andre McCurdy > wrote: > >> Signed-off-by: Andre McCurdy > >> --- > >> meta/recipes-core/musl/musl_git.bb | 3

Re: [OE-core] [PATCH 4/5] webkitgtk: fix compile error when len(TMPDIR) == 410

2017-12-01 Thread Alexander Kanavin
On 12/01/2017 10:26 AM, Alexander Kanavin wrote: On 12/01/2017 03:46 AM, Robert Yang wrote: The flags.make is generated by cmake, and as I said in the commit message: "The cmake doesn't support relative path, so we have to edit flags.make to fix the problem" I'm not familiar with cmake, ple

Re: [OE-core] [PATCH 4/5] webkitgtk: fix compile error when len(TMPDIR) == 410

2017-12-01 Thread Alexander Kanavin
On 12/01/2017 03:46 AM, Robert Yang wrote: The flags.make is generated by cmake, and as I said in the commit message: "The cmake doesn't support relative path, so we have to edit flags.make to fix the problem" I'm not familiar with cmake, please let me know if there is a way to make it genera

Re: [OE-core] [PATCH 1/5] go-native: fix PATH issue when len(TMPDIR) == 410

2017-12-01 Thread Alexander Kanavin
On 12/01/2017 03:40 AM, Robert Yang wrote: So I don't think that it is worth to use malloc here, the similar to 2 3 5. And we had used a few similar ways to fix this kinds of issues before. Okay, that's fair. If there is an upper limit defined somewhere else (kernel, glibc) and upstream doesn'