https://bugs.kde.org/show_bug.cgi?id=322662
Bug ID: 322662
Summary: Okular freezes when trying to print PDF
Classification: Unclassified
Product: okular
Version: 0.16.5
Platform: Archlinux Packages
OS: Linux
Sta
https://bugs.kde.org/show_bug.cgi?id=322662
--- Comment #3 from Milian Wolff ---
This is my zlib version:
core/zlib 1.2.8-1 [installed]
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular
https://bugs.kde.org/show_bug.cgi?id=322662
--- Comment #2 from Milian Wolff ---
On ArchLinux? I doubt it - but well, what is "new"? Here's what I have:
milian@minime:~$ okular --version
Qt: 4.8.5
KDE Development Platform: 4.10.5
Okular: 0.16.5
milian@minime:~$ pacman -Ss
mwolff added inline comments.
INLINE COMMENTS
> generator.cpp:407
> +{
> +request->page()->setPixmap( request->observer(), new QPixmap(
> QPixmap::fromImage( image ) ), request->normalizedRect() );
> +
is `setPixmap` old API? Why create a QPixmap on the heap? That should not be
done, pass
mwolff added inline comments.
INLINE COMMENTS
> aacid wrote in generator.h:581
> Are you asking for a reword? i see both my and your sentence basically say
> the same?
well, mine is shorted. Your's probably refers to going through the event loop
or something? It boils down to the same thing. A
mwolff accepted this revision.
mwolff added a comment.
lgtm from my side
INLINE COMMENTS
> generator_pdf.cpp:920
> +
> +// Since the timer lives in a thread without even loop we need to stop
> it ourselves
> +// when the remaining time has reached 0
typo: "without _an_ even_t_ loop"
mwolff added a comment.
In https://phabricator.kde.org/D8379#163631, @rkflx wrote:
> @aacid In general I notice the changes you are making, sorry I'm not always
able test immediately. I'll try to have another look in the next couple of days.
>
> (That said, more people testing by actu
mwolff added a comment.
I started with a cursory glance at the changes, but the change set is huge,
which makes it really hard to review, especially for people who have no
extensive prior experience with okular. I think some of my comments could be
"solved" by adding a comment here or there,
mwolff added inline comments.
INLINE COMMENTS
> aacid wrote in documenttest.cpp:112
> i don't understand why we would use QEXECTED_FAIL here, yes the annotations
> have been migrated so we compare docdata migration to false, at most we could
> use a qverify since one could argue qcompare with
https://bugs.kde.org/show_bug.cgi?id=478141
--- Comment #17 from Milian Wolff ---
I agree that this is a duplicate of https://bugs.kde.org/show_bug.cgi?id=477700
and is not okular specific.
Albert, see also https://bugs.kde.org/show_bug.cgi?id=477700#c22 - it really
seems to be hidpi/fractional
10 matches
Mail list logo
