ervin created this revision.
ervin added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
This is implemented using the Purpose framework.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.or
ervin updated this revision to Diff 20598.
ervin added a comment.
Making the purpose dependency optional
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8244?vs=20588&id=20598
REVISION DETAIL
https://phabricator.kde.org/D8244
AFFECTED FILES
CMakeLists.t
ervin updated this revision to Diff 20601.
ervin added a comment.
Address aacid's comments
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8244?vs=20598&id=20601
REVISION DETAIL
https://phabricator.kde.org/D8244
AFFECTED FILES
CMakeLists.txt
config-ok
ervin updated this revision to Diff 20605.
ervin added a comment.
Addressing extra comment
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8244?vs=20601&id=20605
REVISION DETAIL
https://phabricator.kde.org/D8244
AFFECTED FILES
CMakeLists.txt
config-ok
ervin created this revision.
ervin added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8263
AFFECTED FILES
doc/index.docbook
To: ervin, aacid
Cc: #ok
ervin added a comment.
This is introduced by another patch which is through review as well.
The "Share" menu will show up and will always contain at least a couple of
actions, but the exact list of actions is unknown, it depends on which plugins
for KPurpose are available in the system and
ervin added a comment.
Wasn't sure mentioning a technology like KPurpose directly wouldn't be
considered like jargon... I can change it indeed.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8263
To: ervin, aacid, kde-doc-english, yurchor
Cc: ostroffjh, #okular, aac
ervin updated this revision to Diff 20848.
ervin added a comment.
Trying to address Jack Ostroff's comment.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8263?vs=20634&id=20848
REVISION DETAIL
https://phabricator.kde.org/D8263
AFFECTED FILES
doc/index
https://bugs.kde.org/show_bug.cgi?id=173896
Kevin Ottens changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:a5da013a4da2: Add a "share" menu to Okular
(authored by ervin).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8244?vs=20605&id=20948
REVISION DETAIL
https://phab
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:43199ae48116: Mention the share menu in the documentation
(authored by ervin).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8263?vs=20848&id=20949
REVISION DETAIL
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Couple of smaller issues. Otherwise I didn't spot anything which looked very
wrong to me, admittedly I don't know much about okular though.
INLINE COMMENTS
> document.cpp:3269
> +
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R223 Okular
BRANCH
cancellable (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid, ervin
Cc: ervin, michaelweghorn, ngraham, #okular, gassaf, aacid
https://bugs.kde.org/show_bug.cgi?id=454693
Kevin Ottens changed:
What|Removed |Added
Latest Commit||https://invent.kde.org/fram
https://bugs.kde.org/show_bug.cgi?id=454693
Kevin Ottens changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
https://bugs.kde.org/show_bug.cgi?id=478276
--- Comment #9 from Kevin Ottens ---
I can indeed confirm it. Now I don't have much bandwidth at the moment, so
don't hold your breath... in any case, at first glance, it looks like it might
be something in Poppler/Qt rather than Oku
https://bugs.kde.org/show_bug.cgi?id=488612
Kevin Ottens changed:
What|Removed |Added
CC||er...@kde.org
--- Comment #1 from Kevin Ottens
17 matches
Mail list logo
