D7382: add markdown supportBUG: 360603

progwolff created this revision. Restricted Application added a project: Okular. REVISION SUMMARY Adds support for Markdown documents TEST PLAN Open a Markdown (.md) document in Okular REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D7382 AFFECTED FI

D7382: add markdown support

progwolff retitled this revision from "add markdown support BUG: 360603" to "add markdown support". progwolff edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7382 To: progwolff, #okular Cc: aacid

D7382: add markdown support

progwolff added a comment. F3867164: okularmd.png REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7382 To: progwolff, #okular Cc: aacid

D7382: add markdown support

progwolff added inline comments. INLINE COMMENTS > aacid wrote in FindDiscount.cmake:22 > So the library is called discount but installs itself as libmarkdown? > > Doesn't it have a pkg-config file? At least the Arch Linux package (which is called "discount") does not install a pkg-config. Th

D7382: add markdown support

progwolff updated this revision to Diff 18379. progwolff added a comment. - Simplify markdown conversion - Drop translations - Fix file name encoding REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7382?vs=18328&id=18379 BRANCH master REVISION DETAIL

D7431: Add RTF support to Okular

progwolff created this revision. Restricted Application added a project: Calligra: 3.0. REVISION SUMMARY Adds RTF support to Okular BUG: 339835 TEST PLAN Okular correctly renders RTF documents. RTF is added to Okular's mime filter REPOSITORY R8 Calligra BRANCH master REVISION DETAI

D7431: Add RTF support to Okular

progwolff added a comment. Right, this would have been my next patch. Thanks for fixing this! REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D7431 To: progwolff, #calligra:_3.0, #okular Cc: ltoscano, vandenoever

D7431: Add RTF support to Okular

progwolff updated this revision to Diff 18437. progwolff added a comment. - Merge branch 'master' of git://anongit.kde.org/calligra - fix desktop file REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7431?vs=18430&id=18437 BRANCH master REVISION DETAIL

D7431: Add RTF support to Okular

progwolff added a comment. In https://phabricator.kde.org/D7431#138583, @aacid wrote: > Is there actually no code? I.e. is it just loading an exising plugin that knows how to use rtf but wasn't told about it? Exactly. The needed filter and converter were already implemented. REPO

D7382: add markdown support

progwolff added a comment. In https://phabricator.kde.org/D7382#138593, @aacid wrote: > It doesn't build on Ubuntu 17.04 In this revision unknown flags are defined to 0. This should allow us to build with older versions of discount. I also set the minimum version to 2.

D7382: add markdown support

progwolff updated this revision to Diff 18577. progwolff added a comment. - fix build with discount < 2.2.2 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7382?vs=18379&id=18577 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7382 AFFECTED

D7382: add markdown support

progwolff updated this revision to Diff 18578. progwolff added a comment. - fix typo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7382?vs=18577&id=18578 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7382 AFFECTED FILES cmake/modules/F

D7431: Add RTF support to Okular

progwolff added a comment. Thanks! REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D7431 To: progwolff, #calligra:_3.0, #okular Cc: kossebau, aacid, ltoscano, vandenoever

D7431: Add RTF support to Okular

progwolff updated this revision to Diff 18651. progwolff added a comment. - update README.PACKAGERS REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7431?vs=18437&id=18651 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7431 AFFECTED FILES

[okular] [Bug 339835] okular incorrectly opens .rft files

https://bugs.kde.org/show_bug.cgi?id=339835 Julian Wolff changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit

D7431: Add RTF support to Okular

This revision was automatically updated to reflect the committed changes. Closed by commit R8:4e15d65ff0ea: Add RTF support to Okular (authored by progwolff). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7431?vs=18651&id=18652 REVISION DETAIL https://phabr

D7382: add markdown support

progwolff updated this revision to Diff 18653. progwolff added a comment. - fix browse action width - use system provided icon - enable internal settings REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7382?vs=18578&id=18653 BRANCH master REVISION DET

D7382: add markdown support

progwolff marked an inline comment as done. progwolff added a comment. Okay, now using system provided icons. The width of the browse actions is also fixed. X-KDE-okularHasInternalSettings is set to true. Thanks for your help and patience! INLINE COMMENTS > aacid wrote in converter.c

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

https://bugs.kde.org/show_bug.cgi?id=384185 Julian Wolff changed: What|Removed |Added CC||wo...@julianwolff.de --- Comment #5 from Julian

D7671: Fix automatic reload of files saved with QSaveFile

progwolff created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY Files saved with QSaveFile don't get dirty. The are deleted and replaced. Thus, inotify and KDirWatch don't emit a "dirty" signal (wich is the co

D7671: Fix automatic reload of files saved with QSaveFile

progwolff edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7671 To: progwolff, aacid Cc: #okular, aacid

D7671: Fix automatic reload of files saved with QSaveFile

progwolff added a comment. In https://phabricator.kde.org/D7671#142826, @aacid wrote: > I don't know who told you this is the correct behaviour of kdirwatch, but i kind of disagree. > > Since we're not watching the file but *also* the folder. From the KDirWatch class reference

D7671: Fix automatic reload of files saved with QSaveFile

progwolff added a comment. In https://phabricator.kde.org/D7671#143118, @aacid wrote: > No, the code doesn't wait *only* for a dirty for path/file, read Part::slotFileDirty better > > The problem here is that dirty for the path is not being emitted, https://mail.kde.org/pipermail/kde

D7671: Fix automatic reload of files saved with QSaveFile

progwolff added a comment. Okay, I modified KDirWatch so we actually get a dirty signal for the directory. Now a new problem arised. QSaveFile does not delete and recreate the file as we thought. It just moves the swap file to the old file's location. On move, KDirWatch still sends

D7671: Fix automatic reload of files saved with QSaveFile

progwolff added a comment. In https://phabricator.kde.org/D7671#143269, @aacid wrote: > Have you read my email? There clearly says what happens and what the documentation says it should happen (at least to my understanding of reading it). Sure, I read your mail. But I still don't

D7671: Fix automatic reload of files saved with QSaveFile

This revision was automatically updated to reflect the committed changes. Closed by commit R223:e3747ca3fd9b: Fix automatic reload of files saved with QSaveFile (authored by progwolff). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7671?vs=19119&id=19269 REVI

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

https://bugs.kde.org/show_bug.cgi?id=384185 Julian Wolff changed: What|Removed |Added Resolution|--- |FIXED Latest Commit

D8415: Soften correctness of image file open check

progwolff added a comment. In https://phabricator.kde.org/D8415#158800, @trufanov wrote: > Also I heard I can add > Differential Revision: https://phabricator.kde.org/D8415 > in commit message to automatically close phabricator review. Is it so? This is true, but it must be t

D8415: Soften correctness of image file open check

progwolff added a comment. In https://phabricator.kde.org/D8415#158804, @aacid wrote: > Wouldn't it make more sense to fix this in QImageReader and not in every user of QImageReader ? From my perspective the behaviour of QImageReader is correct. QImage::read docs: > Read

[okular] [Bug 386600] Okularpart renders markdown as regular text

https://bugs.kde.org/show_bug.cgi?id=386600 Julian Wolff changed: What|Removed |Added CC||wo...@julianwolff.de --- Comment #1 from Julian

[okular] [Bug 386600] Okularpart renders markdown as regular text

https://bugs.kde.org/show_bug.cgi?id=386600 Julian Wolff changed: What|Removed |Added CC||kosse...@kde.org --- Comment #2 from Julian

[okular] [Bug 386600] Okularpart renders markdown as regular text

https://bugs.kde.org/show_bug.cgi?id=386600 Julian Wolff changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

D8690: Fix use of OpenUrlArguments

progwolff created this revision. progwolff added a reviewer: aacid. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY BUG: 386600 Applications using Okular as a KPart might set a file's mime type in the OpenUrlArguments. O

D8690: Fix use of OpenUrlArguments

progwolff edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

progwolff updated this revision to Diff 22028. progwolff added a comment. - add autotest REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8690?vs=22020&id=22028 BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D8690 AFFECTED FILES

D8690: Fix use of OpenUrlArguments

progwolff added a comment. Right, this might be worth a test too. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > part.cpp:1400 > { > -mimes << pathMime << argMime; > +mimes << argMime << pathMime; > } I changed the order here. Now mime types defined by OpenUrlArguments are prefered. This allows opening files with

D8690: Fix use of OpenUrlArguments

progwolff updated this revision to Diff 22039. progwolff added a comment. - prefer mime type given by OpenUrlArguments - add test for choosing backend by mime type REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8690?vs=22028&id=22039 BRANCH Applications

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1400 > I don't think this is a good idea, do you have an actual case in which this > helps or is it just a guess? > > Also have you tried that this doesn't break the fixes that > https://phabricator.kde.org/R223:fba9067

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > progwolff wrote in part.cpp:1400 > Sorry for the delay... > > From my understanding of that commit, my changes won't break it. > argMime is only set, if an external application sets the mimeType via > OpenUrlArguments. So, the order in 1355 is

D8690: Fix use of OpenUrlArguments

progwolff added a comment. @aacid Can we agree to revert to https://phabricator.kde.org/D8690?id=22028 and land this to get the bug fixed? I'll set the test case you requested on my todo list. We will need to define the prefered behaviour first and would need to do some changes to Oku

D8690: Fix use of OpenUrlArguments

progwolff added a comment. I would like to revert to Diff 22028. See my message from Nov 7 2017, 15:11 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, michaelweghorn, ngraham, aacid

D8690: Fix use of OpenUrlArguments

progwolff closed this revision. progwolff added a comment. Thanks! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, michaelweghorn, ngraham, aacid

[okular] [Bug 384070] Text based genertors need reloading the file after font size change

https://bugs.kde.org/show_bug.cgi?id=384070 Julian Wolff changed: What|Removed |Added CC||codestr...@posteo.org --- Comment #1 from

[okular] [Bug 393868] Markdown backend: Configure: Change font size does not update number of pages

https://bugs.kde.org/show_bug.cgi?id=393868 Julian Wolff changed: What|Removed |Added Resolution|--- |DUPLICATE CC