[okular] [Bug 363776] Text selection begins prematurely following change to tool

2017-02-14 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=363776 --- Comment #2 from Jonathan --- Created attachment 104034 --> https://bugs.kde.org/attachment.cgi?id=104034&action=edit PDF that demonstrates bug -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 363776] Text selection begins prematurely following change to tool

2017-02-14 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=363776 --- Comment #3 from Jonathan --- Created attachment 104035 --> https://bugs.kde.org/attachment.cgi?id=104035&action=edit Screen capture video demonstrating bug -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 363776] Text selection begins prematurely following change to tool

2017-02-14 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=363776 --- Comment #4 from Jonathan --- I just reproduced the problem once again using Okular from Debian/unstable. I've attached a copy of the PDF and a screen capture video to demonstrate. The important bit to notice is at 0:22 after I choose

[okular] [Bug 363776] Text selection begins prematurely following change to tool

2017-02-14 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=363776 --- Comment #5 from Jonathan --- Created attachment 104037 --> https://bugs.kde.org/attachment.cgi?id=104037&action=edit Patch to fix problem It's not very elegant, but this patch solves the problem. It does this by creatin

[okular] [Bug 363776] Text selection begins prematurely following change to tool

2017-03-07 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=363776 --- Comment #8 from Jonathan --- Comment on attachment 104443 --> https://bugs.kde.org/attachment.cgi?id=104443 Alberts patch to fix the problem Sure that is a simple and effective solution to this bug. However it does nothing for two identif

[okular] [Bug 363776] Text selection begins prematurely following change to tool

2017-03-08 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=363776 --- Comment #11 from Jonathan --- I beg to differ. The failure to set d->mousePressPos is a direct consequence of handling this particular click differently from every other one. So although the patch removes one obvious malfunction, it is one m

[okular] [Bug 419394] New: Provide an easy way to extract an image from a pdf

2020-03-29 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=419394 Bug ID: 419394 Summary: Provide an easy way to extract an image from a pdf Product: okular Version: 1.9.3 Platform: Other OS: Linux Status: REPORTED Severity: wi

[okular] [Bug 419394] Provide an easy way to extract an image from a pdf

2020-03-29 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=419394 --- Comment #1 from Jonathan --- Created attachment 127096 --> https://bugs.kde.org/attachment.cgi?id=127096&action=edit pdf containing an image -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 361538] Text selection misses some characters

2020-11-23 Thread Jonathan
https://bugs.kde.org/show_bug.cgi?id=361538 --- Comment #6 from Jonathan --- Still happens to me, at least with Okular version 1.11.3 -- You are receiving this mail because: You are the assignee for the bug.

[Okular-devel] [okular] [Bug 314981] New: active-documentviewer desktop files are installed even if app is not built

2013-02-12 Thread Jonathan Marten
https://bugs.kde.org/show_bug.cgi?id=314981 Bug ID: 314981 Summary: active-documentviewer desktop files are installed even if app is not built Classification: Unclassified Product: okular Version: 0.16.60 Platform: Comp

[Okular-devel] [okular] [Bug 155515] Switch to tabbed interface

2013-03-28 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=155515 Jonathan Doman changed: What|Removed |Added CC||jonathan.do...@gmail.com --- Comment #57 from

[Okular-devel] [okular] [Bug 155515] Switch to tabbed interface

2013-03-29 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=155515 --- Comment #62 from Jonathan Doman --- Thank you for your feedback. I had not considered the case presented in #58. I will take these comments into consideration and open a review request when I think the tabs behave reasonably. -- You are receiving

[Okular-devel] Review Request 110914: Tabbed interface

2013-06-09 Thread Jonathan Doman
://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-03 Thread Jonathan Doman
1708501daaef817a1ce35fa5d96701a66ab66983 shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: http://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-03 Thread Jonathan Doman
stals Cid wrote: > Hello? Is anyone there? Sorry, I thought you meant nobody was going to look at it for six months. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://git

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-16 Thread Jonathan Doman
f. But basically, I had to do this for it to work on my computer. I'll go back again to see if it works without changing the names. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewb

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-16 Thread Jonathan Doman
; > people where using. It seems my experiences were caused by a bug/feature in qdbusviewer (https://bugreports.qt-project.org/browse/QTBUG-6943). So, while technically it's okay to keep the interface names how they are, it makes more sense

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-17 Thread Jonathan Doman
1708501daaef817a1ce35fa5d96701a66ab66983 shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: http://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-18 Thread Jonathan Doman
t we're trying to add good practices :-) Do you want everything as const as possible? For example, there are places I can do "const Type* const" but I think "Type*" or "const Type*" is cleaner. How about function parameters (int vs const int)? - Jonathan ---

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-18 Thread Jonathan Doman
1708501daaef817a1ce35fa5d96701a66ab66983 shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: http://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-18 Thread Jonathan Doman
to open as a new tab in an existing window. So without --new, the Detach Tab feature wouldn't work. Unless you want to change the default behavior, --new has to come in at the same time. - Jonathan ---

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-23 Thread Jonathan Doman
gt; for anything other than for calling unregisterObject, is this something > > stale from old changes? > > Jonathan Doman wrote: > I accidentally removed the initialization in the last update. I believe > it's necessary so that closed tabs don't show up in DBus. > &g

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-23 Thread Jonathan Doman
1708501daaef817a1ce35fa5d96701a66ab66983 shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: http://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-23 Thread Jonathan Doman
gt; > "if (part)" instead of "if (part != 0)" > > > > and > > > > "if (!part)" instead of "if (part == 0)" Is there a coding guidelines document that you follow? It seems many of my preferences are contrary

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-25 Thread Jonathan Doman
gt; for anything other than for calling unregisterObject, is this something > > stale from old changes? > > Jonathan Doman wrote: > I accidentally removed the initialization in the last update. I believe > it's necessary so that closed tabs don't show up in DBus. > &g

[Okular-devel] [okular] [Bug 155515] Switch to tabbed interface

2013-09-08 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=155515 --- Comment #67 from Jonathan Doman --- The code is ready to merge from my perspective, but we are still working through the review stage. Unfortunately, we have not really gotten into any discussion about the UI design decisions yet, and I suspect the

[Okular-devel] [okular] [Bug 325745] EPS file does not scale

2013-10-07 Thread Jonathan Riddell
https://bugs.kde.org/show_bug.cgi?id=325745 --- Comment #1 from Jonathan Riddell --- Created attachment 82703 --> https://bugs.kde.org/attachment.cgi?id=82703&action=edit the eps file -- You are receiving this mail because: You are the assignee for

[Okular-devel] [okular] [Bug 325745] New: EPS file does not scale

2013-10-07 Thread Jonathan Riddell
https://bugs.kde.org/show_bug.cgi?id=325745 Bug ID: 325745 Summary: EPS file does not scale Classification: Unclassified Product: okular Version: unspecified Platform: unspecified OS: Linux Status: UNCONFIRMED

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-10-16 Thread Jonathan Doman
ndows, and it would still be possible in this code to manually open the same document to get it in another tab. Is that going to be blocked in the future? If not, I don't see how duplication causes any additional problems. Do you agree with the logic t

[Okular-devel] [okular] [Bug 327958] New: okular-gv.png wrong size

2013-11-22 Thread Jonathan Riddell
https://bugs.kde.org/show_bug.cgi?id=327958 Bug ID: 327958 Summary: okular-gv.png wrong size Classification: Unclassified Product: okular Version: unspecified Platform: unspecified OS: Linux Status: UNCONFIRMED

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-12-15 Thread Jonathan Doman
://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-02 Thread Jonathan Doman
/jrmrjnck/okular-tabbed Diffs (updated) - shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 Diff: https://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-02 Thread Jonathan Doman
n that okularpart knows the > > mimetype once it opens the file, i'd prefer a signal beign emmited instead > > another KMimeType call. Is KMimeType expensive? Are you suggesting that I add a new signal to Okular::Part? - Jonathan --

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-07 Thread Jonathan Doman
t; > setting so people were not forced to use tabs if they don't like them > > Jonathan Doman wrote: > Where should the interface for this setting be? > > Albert Astals Cid wrote: > Settings -> Configure -> General -> Program features looks good to me.

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-08 Thread Jonathan Doman
/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: https://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-08 Thread Jonathan Doman
t; > setting so people were not forced to use tabs if they don't like them > > Jonathan Doman wrote: > Where should the interface for this setting be? > > Albert Astals Cid wrote: > Settings -> Configure -> General -> Program features looks good to me.

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-11 Thread Jonathan Doman
/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: https://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Jonathan Doman
might be some kind of policy. > On Jan. 12, 2014, 9:57 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 256 > > <https://git.reviewboard.kde.org/r/110914/diff/9/?file=233820#file233820line256> > > > > space here Are you sure? Most config keys (in

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Jonathan Doman
/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: https://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Jonathan Doman
> you want one check there shouldn't you be doing something like > > activeTab < m_tabs.size? > > > > But this can't happen, no? > > Jonathan Doman wrote: > Yes, you are right. I was specifically trying to change the code as > litt

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-15 Thread Jonathan Doman
and hidden. For some reason, the static initialization is necessary. If I can figure out how to build kdelibs, I can dig deeper, but this isn't directly related to my tabs code. - Jonathan --- This is an automatical

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-17 Thread Jonathan Doman
o tab 1 > > * Go to tab 2 > > * Press Esc > > * Search bar does not close > > > > Jonathan Doman wrote: > As you may have noticed, the problem is that the Part::m_closeFindBar > action loses its shortcut (Key_Escape) after switching tabs. However, I can

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-19 Thread Jonathan Doman
/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 Diff: https://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-27 Thread Jonathan Doman
> > > > - > > + > > > >&Help > > > > > > fixes the settings menubar jumping issue? Yeah, that seems to keep everything in order. Should I add that to this patch? - Jonathan

[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

2014-02-03 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=219121 Jonathan Doman changed: What|Removed |Added CC||jonathan.do...@gmail.com --- Comment #11 from

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-02-08 Thread Jonathan Doman
93fbc417588312792bab39b693c65e5d414c87c6 Diff: https://git.reviewboard.kde.org/r/110914/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-02-08 Thread Jonathan Doman
> On Feb. 8, 2014, 3:14 p.m., Christoph Feck wrote: > > Thanks for this feature, Jonathan! > > > > I just tried Okular from master, and noticed that QTabWidget adds a frame > > around the page view. Is using QTabWidget::setDocumentMode(false) an > > option,

[Okular-devel] Review Request 115636: Set tabWidget's documentMode

2014-02-10 Thread Jonathan Doman
: https://git.reviewboard.kde.org/r/115636/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115636: Set tabWidget's documentMode

2014-02-13 Thread Jonathan Doman
remove the frame. Diffs - shell/shell.cpp 822615351a91386c51dad4f4afe67db53c3ec97d Diff: https://git.reviewboard.kde.org/r/115636/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https

[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-03-09 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=331872 Jonathan Doman changed: What|Removed |Added CC||jonathan.do...@gmail.com --- Comment #1 from

[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-03-09 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=331872 --- Comment #3 from Jonathan Doman --- Okay, I'm not an official developer but I'll try to implement this and get it reviewed. How would you expect this to behave when there are multiple okular windows already opened? Should it open a new

[Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-10 Thread Jonathan Doman
27608e5 shell/shell.h 3b9aae061cd6be0c7a86c885fc06d00d9275bd50 shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4 Diff: https://git.reviewboard.kde.org/r/116700/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330991] Unable to select table for a second time (without restarting Okular)

2014-03-12 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=330991 Jonathan Doman changed: What|Removed |Added CC||jonathan.do...@gmail.com --- Comment #4 from

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-17 Thread Jonathan Doman
> On March 17, 2014, 4:29 p.m., Albert Astals Cid wrote: > > Does this also solve drag&drop as described in > > https://bugs.kde.org/show_bug.cgi?id=332238 ? No, I have avoided modifying the part/pageview. - Jonathan ---

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-17 Thread Jonathan Doman
> On March 17, 2014, 4:29 p.m., Albert Astals Cid wrote: > > Does this also solve drag&drop as described in > > https://bugs.kde.org/show_bug.cgi?id=332238 ? > > Jonathan Doman wrote: > No, I have avoided modifying the part/pageview. > > Albert Astals

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-17 Thread Jonathan Doman
gt; > traverse all the dbus services. > > Measurements on my computer shows that the search (querying up to 5 open windows) takes only 2-5 ms total. The second half (calling openDocument) takes at least 50 ms per doc since it waits for everything to load. That could be made asynchr

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-17 Thread Jonathan Doman
> On March 17, 2014, 4:29 p.m., Albert Astals Cid wrote: > > Does this also solve drag&drop as described in > > https://bugs.kde.org/show_bug.cgi?id=332238 ? > > Jonathan Doman wrote: > No, I have avoided modifying the part/pageview. > > Albert Astals

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-17 Thread Jonathan Doman
llows a window that was originally non-tabbed to change that setting and then handle multiple docs without restarting (or the other way around). I think the current logic results in more intuitive behavior, but you may disagree. - Jonathan -

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-18 Thread Jonathan Doman
0d9275bd50 part.cpp 4ce7e28e1071772921e6292e61a88c905a62d7f6 part.h 010e9de1f2b5c27531a48b943d821ccc3f3f7205 Diff: https://git.reviewboard.kde.org/r/116700/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-19 Thread Jonathan Doman
30940b27b727608e5 shell/shell.h 3b9aae061cd6be0c7a86c885fc06d00d9275bd50 part.cpp 4ce7e28e1071772921e6292e61a88c905a62d7f6 shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4 Diff: https://git.reviewboard.kde.org/r/116700/diff/ Testing --- Thanks, Jonathan Doman ___

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-03-20 Thread Jonathan Doman
pageview.cpp dd4199450672c18ebfa146327d8e9b7eb034ddc8 ui/sidebar.h 036d7788096366d6bab7d7f2a41d55b7a31d303a ui/pageview.h 577b908633bd0778df33d0a15961ab16071a1500 ui/thumbnaillist.cpp 72b557e6624e8229cf1e5e4c5dc69ed77fec54cb Diff: https://git.reviewboa

Re: [Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

2014-04-09 Thread Jonathan Doman
debar.h 036d7788096366d6bab7d7f2a41d55b7a31d303a ui/pageview.h 577b908633bd0778df33d0a15961ab16071a1500 ui/thumbnaillist.cpp 72b557e6624e8229cf1e5e4c5dc69ed77fec54cb Diff: https://git.reviewboard.kde.org/r/116700/diff/ Testing --- Thanks, Jonathan Doman ___ Okular-dev

[Okular-devel] [okular] [Bug 334019] Okular should warn if closing with multiple tabs opened

2014-04-28 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334019 --- Comment #2 from Jonathan Doman --- I'm happy to implement this, but it may be a month before I have time to do it. -- You are receiving this mail because: You are the assignee for the bug. ___ O

[Okular-devel] [okular] [Bug 334018] Tabs should be rearrangeable

2014-04-28 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334018 --- Comment #1 from Jonathan Doman --- I'm happy to implement this, but it may be a month before I have time to do it. It's really just one line of code, but there are a few other tab improvements I'd like to do at the same time. -- Yo

[Okular-devel] [okular] [Bug 334100] --page being ignored

2014-04-29 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334100 Jonathan Doman changed: What|Removed |Added CC||jonathan.do...@gmail.com --- Comment #1 from

[Okular-devel] [okular] [Bug 334251] New: Tools don't work if any tab is in review mode

2014-05-02 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334251 Bug ID: 334251 Summary: Tools don't work if any tab is in review mode Classification: Unclassified Product: okular Version: 0.19.0 Platform: Archlinux Packages OS: Linux

[Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-06-11 Thread Jonathan Doman
://git.reviewboard.kde.org/r/118685/diff/ Testing --- Tested that the GUI remains coherent when moving two tabs around many times. As before, the tool selections aren't quite coherent, but that's for another patch. Thanks, Jonathan Doman ___ Ok

[Okular-devel] [okular] [Bug 335852] Multiple tabs session restore fails

2014-06-17 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=335852 --- Comment #2 from Jonathan Doman --- Okay, got it. I'm settled in a new city now, so I'll put up patches as fast as you can review them. -- You are receiving this mail because: You are the assignee f

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-14 Thread Jonathan Doman
not expose the underlying tab bar. Personally, I find this simpler than subclassing KTabWidget or using KTabBar+QStackedLayout. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewbo

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Jonathan Doman
abWidget is a QTabWidget and is setting its tabbar with > > > > setTabBar( new KTabBar( this ) ); > > > > so how would QTabWidget::tabBar not return something valid? That function is protected. I would have

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Jonathan Doman
abWidget is a QTabWidget and is setting its tabbar with > > > > setTabBar( new KTabBar( this ) ); > > > > so how would QTabWidget::tabBar not return something valid? > > Jonathan Doman wrote: > That function is protected. I would have to

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Jonathan Doman
. As before, the tool selections aren't quite coherent, but that's for another patch. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-30 Thread Jonathan Doman
, the tool selections aren't quite coherent, but that's for another patch. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 119550: Use absolute filepath when attaching to existing windows

2014-07-30 Thread Jonathan Doman
bff51 Diff: https://git.reviewboard.kde.org/r/119550/diff/ Testing --- Tested steps described in bug report. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 119550: Use absolute filepath when attaching to existing windows

2014-07-30 Thread Jonathan Doman
shell/main.cpp d2e0ec72fd43b560d25ac7f903462641cdbbff51 Diff: https://git.reviewboard.kde.org/r/119550/diff/ Testing --- Tested steps described in bug report. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kd

[Okular-devel] [okular] [Bug 334510] Opening a second file from shell with a relative folder name when tabs are used fails

2014-07-30 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334510 --- Comment #3 from Jonathan Doman --- Thanks for the tip, Willem. The patch is posted. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel

Re: [Okular-devel] Review Request 119550: Use absolute filepath when attaching to existing windows

2014-08-01 Thread Jonathan Doman
Testing --- Tested steps described in bug report. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 119550: Use absolute filepath when attaching to existing windows

2014-08-02 Thread Jonathan Doman
ments are made absolute. Diffs - shell/main.cpp d2e0ec72fd43b560d25ac7f903462641cdbbff51 Diff: https://git.reviewboard.kde.org/r/119550/diff/ Testing --- Tested steps described in bug report. Thanks, Jonathan Doman ___ Okular-

[Okular-devel] [okular] [Bug 338088] Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=338088 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #2

[Okular-devel] [okular] [Bug 338088] Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=338088 --- Comment #4 from Jonathan Verner --- Thanks for clarifying. Online discussion has the drawback that one can't see non-verbal hints and without them, as I said, your second sentence sounded a bit harsh to me :-) As for the feature, I won'

Re: [Okular-devel] Review Request 119595: Pass the command line options properly when using tabs or unique instances

2014-08-07 Thread Jonathan Doman
code looks good to me. - Jonathan Doman On Aug. 3, 2014, 3 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode

2014-10-12 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334251 --- Comment #3 from Jonathan Doman --- I took some time to look at this and I'm not sure how to fix it. The problem is that changing the mouse mode writes the global Settings, which triggers all the Parts to reload (and potentially overwrite

[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode

2014-10-13 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334251 --- Comment #6 from Jonathan Doman --- So I tested an older version (tag v4.10.97) and this bug exists for multiple windows as well. It's probably been around forever. And there are similar bugs for other settings like continuous view mode. Basica

[Okular-devel] Review Request 120660: Allow each PageView to use a different tool

2014-10-19 Thread Jonathan Doman
diff/ Testing --- Followed steps in bug report for both tabs and windows to make sure different tools are allowed. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 329740] Okular hangs in presentation mode when displaying PDFs when default printer is not accessible

2014-10-29 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=329740 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com -- You are

[Okular-devel] [okular] [Bug 341118] Okular blocks (no display, no menu), when scrolling down or opening pdf document.

2014-11-22 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=341118 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #4

[Okular-devel] [okular] [Bug 341244] Krach de okular lors d' une impression

2014-11-24 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=341244 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #2

Re: [Okular-devel] Review Request 120660: Allow each PageView to use a different tool

2014-12-10 Thread Jonathan Doman
ui/pageview.cpp 17e66f4a3b420bbcaf281532fa9d84379c74d48c Diff: https://git.reviewboard.kde.org/r/120660/diff/ Testing --- Followed steps in bug report for both tabs and windows to make sure different tools are allowed. Thanks, Jonathan Doman ___ Okular-devel mail

[Okular-devel] [okular] [Bug 342548] Okular hang up while printing pdf with state "rendering completed"

2015-01-13 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=342548 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #6

[Okular-devel] [okular] [Bug 343101] Option: rember the vertical position when moving to next/previous page

2015-01-22 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=343101 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #5

[Okular-devel] [okular] [Bug 335852] Multiple tabs session restore fails

2015-02-02 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=335852 --- Comment #5 from Jonathan Doman --- I'm trying to work on this bug but hitting some roadblocks due to the Part plugin design. The Shell needs to get and set some information on each Part (the viewport), and this can't really be done usi

[Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-14 Thread Jonathan Doman
ingle window with tabs enabled. - Restore multiple windows, tabs enabled or disabled. - Restore session config describing multible tabs, even though tabs are disabled Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-16 Thread Jonathan Doman
> On Feb. 16, 2015, 4:43 p.m., Albert Astals Cid wrote: > > How much work would be to add to autotests the manual tests you mention? No idea, never written qt tests before. I'll take a look. - Jonathan --- This is an

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-16 Thread Jonathan Doman
save the viewport, but the code became very complicated, and I couldn't get it working anyway. The viewport is already saved during a normal close, so I will try to figure out how to invoke the same logic during a session shut down. - Jonathan -

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-21 Thread Jonathan Doman
think is how KDE does it behind the scenes. - Restore one or more documents in single window with tabs enabled. - Restore multiple windows, tabs enabled or disabled. - Restore session config describing multible tabs, even though tabs are disabled Thank

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-22 Thread Jonathan Doman
ibing multible tabs, even though tabs are disabled Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-22 Thread Jonathan Doman
eApplication::quit() I think). This just causes app.exec() to return - windows are not closed nor are destructors called. So the only way to respond is to connect to aboutToQuit. Just in case this changes in the future, we can clear the tab list in slotQuit so that it's okay to call

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-22 Thread Jonathan Doman
tiple windows, tabs enabled or disabled. - Restore session config describing multible tabs, even though tabs are disabled Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-28 Thread Jonathan Doman
Restore session config describing multible tabs, even though tabs are disabled Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-28 Thread Jonathan Doman
abled. - Restore session config describing multible tabs, even though tabs are disabled Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

  1   2   3   >