[Okular-devel] Review Request 114958: Remove unused arguments

2014-01-10 Thread Jan Kundrát
--- This fixes a couple of compiler warnings. Diffs - core/fileprinter.cpp 4c7cf99 core/script/kjs_data.cpp 5c76d94 Diff: https://git.reviewboard.kde.org/r/114958/diff/ Testing --- Thanks, Jan Kundrát ___ Okular-devel mailing list Okular

[Okular-devel] Review Request 114959: The doesConsumeX method was defined but never used

2014-01-10 Thread Jan Kundrát
://git.reviewboard.kde.org/r/114959/diff/ Testing --- Thanks, Jan Kundrát ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 114958: Remove unused arguments

2014-01-10 Thread Jan Kundrát
, Jan Kundrát ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 114959: The doesConsumeX method was defined but never used

2014-01-10 Thread Jan Kundrát
second one to make it standalone. Diffs - core/textpage.cpp c1bd1f2 Diff: https://git.reviewboard.kde.org/r/114959/diff/ Testing --- Thanks, Jan Kundrát ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-08 Thread Jan Kundrát
93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. Why not: - -find_package(KF5 CONFIG COMPONENTS Activities) - Jan Kundrát On April 3, 2015, 8:39 p.m., Ivan Čukić wrote: > > --- > This is an automatically ge

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-25 Thread Jan Kundrát
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-25 Thread Jan Kundrát
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS

[Okular-devel] Review Request 124026: Remove leftovers from KUrl -> QUrl port

2015-06-08 Thread Jan Kundrát
the systemwide installation of Okular and to use, e.g., poppler generator from the build directory? Thanks, Jan Kundrát ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 124027: s/auto_ptr/unique_ptr/

2015-06-08 Thread Jan Kundrát
iutils.cpp 3bf3ad64b57396792c3aa33298265561ee35ed1a Diff: https://git.reviewboard.kde.org/r/124027/diff/ Testing --- Thanks, Jan Kundrát ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124026: Remove leftovers from KUrl -> QUrl port

2015-07-18 Thread Jan Kundrát
wboard.kde.org/r/124026/#review82296 ------- On June 8, 2015, 8:59 a.m., Jan Kundrát wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: [Okular-devel] Review Request 124027: s/auto_ptr/unique_ptr/

2015-07-20 Thread Jan Kundrát
marked as submitted. Review request for Okular. Changes --- Submitted with commit abd30fb774f6d0cd5abf93019f652c0ca54778f4 by Jan Kundrát to branch frameworks. Repository: okular Description --- The old auto_ptr was used for simple RAII. None of the auto_ptr flaws were apparent in

Re: [Okular-devel] Review Request 124026: Remove leftovers from KUrl -> QUrl port

2015-07-20 Thread Jan Kundrát
y local dev box. How do I, for example, persuade the KService/whatever to ignore the systemwide installation of Okular and to use, e.g., poppler generator from the build directory? Thanks, Jan Kundrát ___ Okular-devel mailing list Okular-deve

[Okular-devel] Review Request 124842: Fix picking of different view modes

2015-08-20 Thread Jan Kundrát
iewboard.kde.org/r/124842/diff/ Testing --- Thanks, Jan Kundrát ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124842: Fix picking of different view modes

2015-08-25 Thread Jan Kundrát
marked as submitted. Review request for Okular, Albert Astals Cid and Vishesh Handa. Changes --- Submitted with commit cf513f3dd61ceb01069bf8f0614ecb5401452a71 by Albert Astals Cid on behalf of Jan Kundrát to branch frameworks. Repository: okular Description --- This was broken

[Okular-devel] [Bug 310837] New: No upscaling when printing an A4-sized PDF file to an A3-sized paper

2012-11-28 Thread Jan Kundrát
https://bugs.kde.org/show_bug.cgi?id=310837 Bug ID: 310837 Severity: normal Version: 0.15.0 Priority: NOR Assignee: okular-devel@kde.org Summary: No upscaling when printing an A4-sized PDF file to an A3-sized paper

[okular] [Bug 451059] Okular freezes for up to 10 seconds when loading a document or switching windows

2022-06-02 Thread Jan Kundrát
https://bugs.kde.org/show_bug.cgi?id=451059 Jan Kundrát changed: What|Removed |Added CC||j...@kde.org -- You are receiving this mail

[okular] [Bug 283477] Missing language specific characters when filling in forms

2022-10-31 Thread Jan Kundrát
https://bugs.kde.org/show_bug.cgi?id=283477 Jan Kundrát changed: What|Removed |Added CC||j...@kde.org -- You are receiving this mail