D21364: Indicate annotation color in annotation list

jangmarker created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. jangmarker requested review of this revision. REPOSITORY R223 Okular BRANCH indicate-annotation-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D21364 AFFECT

D21364: Indicate annotation color in annotation list

jangmarker added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21364 To: jangmarker, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21364: Indicate annotation color in annotation list

jangmarker added a comment. In D21364#469111 , @davidhurka wrote: > Nice, makes the list more intuitive. :) (Didn’t test this) Thank you :-) Currently it looks like this: F6844393: image.png >

D21364: Indicate annotation color in annotation list

jangmarker added a comment. In D21364#469215 , @davidhurka wrote: > In D21364#469159 , @jangmarker wrote: > > > I think `captionForAnnotation()` does not include the comment's text currently, so th

D21364: Indicate annotation color in annotation list

jangmarker updated this revision to Diff 58563. jangmarker added a comment. Instead of showing colorful rectangles, use same icons as for annotation tool REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21364?vs=58542&id=58563 BRANCH indicate-annotation-col

D21364: Indicate annotation color in annotation list

jangmarker added a comment. Now it looks like this: F6844521: image.png A stamp looks like this: F6844523: image.png I changed the color of this stamp to something blue, but the algorithm that's crea

D21376: RFC: In annotations list show highlighted text

jangmarker created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. jangmarker requested review of this revision. REVISION SUMMARY unfortunately the text detection is not 100 % accurate REPOSITORY R223 Okular BRANCH annotations-show-comments-highlight

D21376: RFC: In annotations list show highlighted text

jangmarker added reviewers: Okular, davidhurka. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21376 To: jangmarker, #okular, davidhurka Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21376: RFC: In annotations list show highlighted text

jangmarker added inline comments. INLINE COMMENTS > guiutils.cpp:77 > +// TODO this does not seem to be very accurate :-( > +text += page->text(page->textArea(&textSelection), > Okular::TextPage::CentralPixelTextAreaInclusionBehaviour); > +} I'd be gr