[Okular-devel] [Bug 224805] Double-clicking pop-up note should open the note

2010-03-20 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=224805 --- Comment #1 from Glen Kaukola 2010-03-20 01:59:32 --- Created an attachment (id=41768) --> (http://bugs.kde.org/attachment.cgi?id=41768) Adds double clicks to pop up notes. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=em

[Okular-devel] [Bug 224805] Double-clicking pop-up note should open the note

2010-03-20 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=224805 Glen Kaukola changed: What|Removed |Added CC||gkauk...@cs.ucr.edu --- Comment #2 from

[Okular-devel] pan mouse icon fix

2010-03-24 Thread Glen Kaukola
Hey, Here's the fix for the pan icon showing up on a double click. Seems to me the timer may last a bit too long though. Yeah? No? Anyway, criticism is certainly appreciated. I also noticed what seems to be a bug with pop up notes. When my zoom is at 100% the whole of my document fits in the

Re: [Okular-devel] pan mouse icon fix

2010-03-25 Thread Glen Kaukola
> Comments on the patch: > * You should make the timer single shot, no need to get the timer called > again and again Done. > * If when dragging happens the timer is still running (dragging happened > earlier than Application::doubleClickInterval() + 10) you should stop the > timer and call slo

[Okular-devel] [Bug 228551] eps picture in dvi is not shown when picture path contains non-latin letters

2010-03-25 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=228551 --- Comment #8 from Glen Kaukola 2010-03-26 02:46:08 --- Created an attachment (id=42268) --> (http://bugs.kde.org/attachment.cgi?id=42268) patch to fix nonlatin eps paths I just dropped the QString::toLatin1() conversion on the eps file pa

[Okular-devel] [Bug 229141] impossible to assign bookmarks in certain pdf files

2010-03-26 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=229141 Glen Kaukola changed: What|Removed |Added CC||gkauk...@cs.ucr.edu --- Comment #3 from

[Okular-devel] [Bug 228551] eps picture in dvi is not shown when picture path contains non-latin letters

2010-03-26 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=228551 Glen Kaukola changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

[Okular-devel] [Bug 229141] impossible to assign bookmarks in certain pdf files

2010-03-26 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=229141 Glen Kaukola changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0

[Okular-devel] [Bug 229141] impossible to assign bookmarks in certain pdf files

2010-03-26 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=229141 --- Comment #6 from Glen Kaukola 2010-03-27 07:00:37 --- Or I may have spoke too soon. Investigating further. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the

[Okular-devel] [Bug 229433] Mouse cursor disappears when is over the control panel in Presentation view

2010-03-29 Thread Glen Kaukola
https://bugs.kde.org/show_bug.cgi?id=229433 Glen Kaukola changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

[Okular-devel] Krazy: Check for strings used improperly or should be i18n

2010-03-30 Thread Glen Kaukola
Hey, Here's the start of a few of krazy fixes. This one passes QLatin1String's to QString::startsWith() and endsWith() methods.Index: okular/core/fileprinter.cpp === --- okular/core/fileprinter.cpp (revision 1109126) +++ okular/core/

[Okular-devel] Krazy: Check for Qt classes that should not be used.

2010-03-30 Thread Glen Kaukola
Patch to turn Q classes in to K classes.Index: okular/conf/dlgeditorbase.ui === --- okular/conf/dlgeditorbase.ui (revision 1109126) +++ okular/conf/dlgeditorbase.ui (working copy) @@ -27,7 +27,7 @@ - +

[Okular-devel] Krazy: Check for spelling errors

2010-03-30 Thread Glen Kaukola
Fixes a few spelling errors in the comments.Index: okular/core/textpage.cpp === --- okular/core/textpage.cpp (revision 1109126) +++ okular/core/textpage.cpp (working copy) @@ -483,7 +483,7 @@ // move the current po

[Okular-devel] Krazy: Check for Qt classes that should not be used.

2010-03-30 Thread Glen Kaukola
More Q classes to K classes.Index: okular/ui/formwidgets.cpp === --- okular/ui/formwidgets.cpp (revision 1109126) +++ okular/ui/formwidgets.cpp (working copy) @@ -299,7 +299,7 @@ FormLineEdit::FormLineEdit( Okular::FormFieldText *

[Okular-devel] Krazy: Check for assignments to QString::null

2010-03-30 Thread Glen Kaukola
Replaces QString() assignments with .clear().Index: okular/extensions.cpp === --- okular/extensions.cpp (revision 1109126) +++ okular/extensions.cpp (working copy) @@ -84,7 +84,7 @@ { type = KParts::LiveConnectExtension::

[Okular-devel] Krazy: Check for C++ ctors that should be declared 'explicit'

2010-03-30 Thread Glen Kaukola
Makes a few ctors explicit.Index: okular/generators/fax/faxdocument.h === --- okular/generators/fax/faxdocument.h (revision 1109126) +++ okular/generators/fax/faxdocument.h (working copy) @@ -33,7 +33,7 @@ * * @param type T

[Okular-devel] Krazy: Check single-char QString operations for efficiency

2010-03-30 Thread Glen Kaukola
Turns single char QStrings into QChars.Index: okular/core/fileprinter.cpp === --- okular/core/fileprinter.cpp (revision 1109224) +++ okular/core/fileprinter.cpp (working copy) @@ -601,7 +601,7 @@ if ( dialogOptions[i+1].isEmpt