[Okular-devel] Review Request 125890: Fix crash on close

2015-10-31 Thread David Rosca
--- Don't try to set invalid (-1) active tab. Add the same check also in removeTab. Diffs - shell/shell.cpp ce5e76c Diff: https://git.reviewboard.kde.org/r/125890/diff/ Testing --- No longer crashes. Thanks, David Rosca ___ Okular-

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-02 Thread David Rosca
reviewboard.kde.org/r/125890/#review87890 ------- On Oct. 31, 2015, 11:52 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-03 Thread David Rosca
. Repository: okular Description (updated) --- Delete m_tabwidget in destructor Diffs - shell/shell.cpp ce5e76c Diff: https://git.reviewboard.kde.org/r/125890/diff/ Testing --- No longer crashes. Thanks, David Rosca ___ Okular-devel

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-03 Thread David Rosca
. Repository: okular Description --- Don't try to set invalid (-1) active tab. Add the same check also in removeTab. Diffs (updated) - shell/shell.cpp ce5e76c Diff: https://git.reviewboard.kde.org/r/125890/diff/ Testing --- No longer crashes. Thanks, David

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-04 Thread David Rosca
marked as submitted. Review request for Okular. Changes --- Submitted with commit c793fb2703bbeaf2847663013b62850fe6d970d3 by David Rosca to branch frameworks. Repository: okular Description --- Delete m_tabwidget in destructor Diffs - shell/shell.cpp ce5e76c Diff: https

[Okular-devel] Review Request 126852: Use kcmshell5 for configure web shortcuts action

2016-01-23 Thread David Rosca
--- ^ Diffs - ui/pageview.cpp ee7aad1 Diff: https://git.reviewboard.kde.org/r/126852/diff/ Testing --- Thanks, David Rosca ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126852: Use kcmshell5 for configure web shortcuts action

2016-03-11 Thread David Rosca
marked as submitted. Review request for Okular. Changes --- Submitted with commit 1335d67259191d8b2949be3e1816f65075ea50ca by David Rosca to branch frameworks. Repository: okular Description --- ^ Diffs - ui/pageview.cpp ee7aad1 Diff: https://git.reviewboard.kde.org/r