I did this because I wanted to be able to set black as the background color.
On 9 Aug. 2017 11:15 am, "Albert Freeman" wrote:
> I have added the ability for the background color in okular to be changed
> via the settings, but currently what I have done is set the default
>
I have added the ability for the background color in okular to be changed
via the settings, but currently what I have done is set the default
background color to the RGB value of QPalette::Dark since I don't think it
is a good idea to construct a QPalette in conf/okular.kcfg just to access
QPalette
https://git.reviewboard.kde.org/r/130219/
On 9 August 2017 at 22:23, Oliver Sander wrote:
> Hi Albert,
>
> can you please upload the patch to
>
>https://git.reviewboard.kde.org/
>
> It is easier to review there.
>
> Thanks,
> Oliver
>
>
.
Repository: okular
Description
---
Enable background color to be changed from settings
Diffs
-
conf/dlggeneralbase.ui cf4ebca0
conf/okular.kcfg 69ea8cf6
ui/pageview.cpp 3d935a2e
Diff: https://git.reviewboard.kde.org/r/130219/diff/
Testing
---
Thanks,
Albert Freeman
f1af2602
ui/pageview.cpp 3d935a2e
ui/pageviewutils.cpp a57712ca
Diff: https://git.reviewboard.kde.org/r/130219/diff/
Testing
---
Thanks,
Albert Freeman
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130219/#review103582
---
On Aug. 11, 2017, 2:50 a.m., Albert Freeman wrote:
>
> -
> On Aug. 9, 2017, 6:24 p.m., Albert Astals Cid wrote:
> > Thanks for contributing to Okular :)
> >
> > Why would you need a different background color?
>
> Albert Freeman wrote:
> I personally much prefer black as a background color.
>
> Albert Ast
f1af2602
ui/pageview.cpp 3d935a2e
ui/pageviewutils.cpp a57712ca
Diff: https://git.reviewboard.kde.org/r/130219/diff/
Testing
---
Thanks,
Albert Freeman
> On Aug. 9, 2017, 6:24 p.m., Albert Astals Cid wrote:
> > Thanks for contributing to Okular :)
> >
> > Why would you need a different background color?
>
> Albert Freeman wrote:
> I personally much prefer black as a background color.
>
> Albert Ast
69ea8cf62
ui/pageview.cpp 9766422b9
Diff: https://git.reviewboard.kde.org/r/130219/diff/4/
Changes: https://git.reviewboard.kde.org/r/130219/diff/3-4/
Testing
---
Thanks,
Albert Freeman
albertfreeman created this revision.
albertfreeman added a reviewer: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
https://git.reviewboard.kde.org/r/130219/
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
AFFECTED FILES
CMakeLists.txt
albertfreeman edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: aacid
albertfreeman edited the summary of this revision.
albertfreeman edited the test plan for this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: ngraham, aacid
albertfreeman retitled this revision from "Enable custom background color to be
enabled and changed from settings" to "Custom background color to be enabled
and changed from settings".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: l
albertfreeman retitled this revision from "Custom background color to be
enabled and changed from settings" to "Custom background color".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: ltoscano, ngraham, aacid
albertfreeman edited the summary of this revision.
albertfreeman added a subscriber: aacid.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham
albertfreeman edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham
albertfreeman edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham
albertfreeman updated this revision to Diff 20077.
albertfreeman added a comment.
Reverted changes of accelerators that my Qt Designer automatically made.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8051?vs=20070&id=20077
REVISION DETAIL
https://phabri
albertfreeman updated this revision to Diff 20143.
albertfreeman added a comment.
Removed blank line from conf/okular.kcfg.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8051?vs=20077&id=20143
REVISION DETAIL
https://phabricator.kde.org/D8051
AFFECTED F
albertfreeman edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx
Cc: aacid, ltoscano, ngraham
albertfreeman updated this revision to Diff 20174.
albertfreeman added a comment.
Rename slot to setCustomBackgroundColorButton.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8051?vs=20143&id=20174
REVISION DETAIL
https://phabricator.kde.org/D8051
AFFEC
/okular.kcfg 69ea8cf62
ui/pageview.cpp 9766422b9
Diff: https://git.reviewboard.kde.org/r/130219/diff/4/
Testing
---
Thanks,
Albert Freeman
69ea8cf62
ui/pageview.cpp 9766422b9
Diff: https://git.reviewboard.kde.org/r/130219/diff/4/
Testing
---
Thanks,
Albert Freeman
albertfreeman added a comment.
I didn't use Arcanist. I recreated it via the phabricator.kde.org interface.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx, ngraham
Cc: aacid, ltoscano, ngraham
25 matches
Mail list logo
