D10566: Add support for code tags in fictionbook

2018-02-15 Thread Abdel-Rahman A .
abogical created this revision. abogical added a reviewer: Okular. Restricted Application added a project: Okular. abogical requested review of this revision. REVISION SUMMARY Fixes https://bugs.kde.org/show_bug.cgi?id=387426 TEST PLAN Open this

D10566: Add support for code tags in fictionbook

2018-02-16 Thread Abdel-Rahman A .
abogical updated this revision to Diff 27335. abogical edited the test plan for this revision. abogical added a comment. Added support for superscript and subscript tags, also fixed formatting issues. Just a question, what tools does the KDE developers use for linting the formatting of their

D10566: Add support for code, superscript, & subscript tags in fictionbook

2018-02-16 Thread Abdel-Rahman A .
abogical retitled this revision from "Add support for code tags in fictionbook" to "Add support for code, superscript, & subscript tags in fictionbook". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular Cc: cfeck, ngraham, michaelweghorn, simgun

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-16 Thread Abdel-Rahman A .
abogical retitled this revision from "Add support for code, superscript, & subscript tags in fictionbook" to "Fictionbook: Add support for code, superscript, & subscript tags". abogical edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-16 Thread Abdel-Rahman A .
abogical edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular Cc: cfeck, ngraham, michaelweghorn, simgunz, aacid

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-16 Thread Abdel-Rahman A .
abogical updated this revision to Diff 27376. abogical added a comment. Used QStringLiteral REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10566?vs=27335&id=27376 REVISION DETAIL https://phabricator.kde.org/D10566 AFFECTED FILES generators/fictionbook/

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-16 Thread Abdel-Rahman A .
abogical updated this revision to Diff 27378. abogical added a comment. Use `QStringLiteral` . CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10566?vs=27376&id=27378 REVISION DETAIL https://phabricator.kde.org/D10566 AFFECTED FILES generators/fictionbook/converter.cpp generat

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Abdel-Rahman A .
abogical added a comment. Name is Abdel-Rahman A. I'll modify my profile. REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Abdel-Rahman A .
abogical added a comment. Full name is 'Abdel-Rahman Abdel-Rahman'. but I just like to hide my last name. REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn