D15580: New annotation toolbar

2019-10-28 Thread Luigi Toscano
ltoscano added a comment. I agree, please don't commit such a big change without updating the documentation at the same time. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham C

D15580: New annotation toolbar

2019-10-28 Thread Simone Gaiarin
simgunz added a comment. In D15580#554972 , @aacid wrote: > Doesn't need this a docbook update? I think that @yurchor is taking care of the documentation. We also need to complete the other reviews on which this one depends, so I am

D15348: Add typewriter autotests

2019-10-28 Thread Oliver Sander
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:8315b72d2735: Add typewriter autotests (authored by tobiasdeiminger, committed by sander). CHANGED PRIOR TO COMMIT h

D13588: Add test for field number formatting

2019-10-28 Thread Oliver Sander
sander added a comment. @aacid , do you have the power to close this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13588 To: aheinecke, aacid Cc: joaonetto, sander, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, kezik, tfella, ngraham, dar

D13588: Add test for field number formatting

2019-10-28 Thread Joao Oliveira
joaonetto added a comment. Sorry, being busy with college and stuff. This diff can be closed, the one at gitlab doesn't need to, I intend to finish it when I have the time. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13588 To: aheinecke, aacid Cc: joaonetto,

D13588: Add test for field number formatting

2019-10-28 Thread Albert Astals Cid
aacid commandeered this revision. aacid edited reviewers, added: aheinecke; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13588 To: aacid, aheinecke Cc: joaonetto, sander, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, kezik, tf

D13588: Add test for field number formatting

2019-10-28 Thread Albert Astals Cid
aacid added a comment. @sander i think everyone can. Just commander the revision and then abandon it REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13588 To: aheinecke, aacid Cc: joaonetto, sander, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampalouk

D13588: Add test for field number formatting

2019-10-28 Thread Albert Astals Cid
aacid abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13588 To: aacid, aheinecke Cc: joaonetto, sander, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, kezik, tfella, ngraham, darcyshen, aacid

[okular] [Bug 413304] Chinese characters instead of Polish diacritical marks

2019-10-28 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=413304 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #14 from Wolfgang Ba

[okular] [Bug 413304] Chinese characters instead of Polish diacritical marks

2019-10-28 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=413304 --- Comment #15 from Wolfgang Bauer --- PS, I get this debug output if I set "Okular (Generator TXT)" to "Full Debug" in kdebugsettings: org.kde.okular.generators.txt: Detected "gb18030" encoding based on 3000 chars -- You are receiving this mail beca