D23037: Add support for cb7 comic book archives

2019-08-09 Thread N. Higa
nhiga updated this revision to Diff 63392. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23037?vs=63385&id=63392 REVISION DETAIL https://phabricator.kde.org/D23037 AFFECTED FILES generators/comicbook/document.cpp generators/comicbook/libokularGenerator_comicbook.json generator

D23037: Add support for cb7 comic book archives

2019-08-09 Thread Kai Uwe Broulik
broulik added a comment. Works well, thanks a lot! Let's wait for Okular maintainer approval. INLINE COMMENTS > okularApplication_comicbook.desktop:168 > NoDisplay=true > -X-KDE-Keywords=cbr, cbz, cbt, Comic Book > -X-KDE-Keywords[ar]=cbr, cbz, cbt, Comic Book > -X-KDE-Keywords[bg]=cbr, cbz,

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Jan Grulich
jgrulich updated this revision to Diff 63393. jgrulich added a comment. Use translatable string REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23027?vs=63387&id=63393 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23027 AFFECTED FILES co

D23037: Add support for cb7 comic book archives

2019-08-09 Thread N. Higa
nhiga removed subscribers: broulik, pino. nhiga abandoned this revision. nhiga marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D23037 To: nhiga, #okular, aacid Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid, broulik,

D23037: Add support for cb7 comic book archives

2019-08-09 Thread N. Higa
nhiga updated this revision to Diff 63394. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23037?vs=63392&id=63394 REVISION DETAIL https://phabricator.kde.org/D23037 AFFECTED FILES generators/comicbook/document.cpp generators/comicbook/libokularGenerator_comicbook.json generator

D23037: Add support for cb7 comic book archives

2019-08-09 Thread Pino Toscano
pino added a comment. why did you abandon this? REVISION DETAIL https://phabricator.kde.org/D23037 To: nhiga, #okular, aacid Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > propertiesdialog.cpp:361 > +if (m_fonts.at( index.row() ).embedType() == > Okular::FontInfo::NotEmbedded && !substituteName.isEmpty() && > !fontname.isEmpty()) { > +return i18nc("Replacing missing font wit

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Jan Grulich
jgrulich updated this revision to Diff 63395. jgrulich added a comment. Better use of i18nc API REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23027?vs=63393&id=63395 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23027 AFFECTED FILES co

D23037: Add support for cb7 comic book archives

2019-08-09 Thread N. Higa
nhiga reclaimed this revision. REVISION DETAIL https://phabricator.kde.org/D23037 To: nhiga, #okular, aacid Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

2019-08-09 Thread N. Higa
nhiga added a subscriber: broulik. nhiga added a comment. Sorry for the mess, I accidentally changed the status and subscriber list. REVISION DETAIL https://phabricator.kde.org/D23037 To: nhiga, #okular, aacid Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfell

[okular] [Bug 163493] 'Full screen mode' is better in View menu than Settings menu (usability)

2019-08-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=163493 madworm_de@spitzenpfeil.org changed: What|Removed |Added CC||madworm_de.kde@spitzenpfeil

D22262: Thumbnails sidebar always open when okular starts

2019-08-09 Thread Mayank Choudhary
mayankchoudhary added a comment. I want to use the mouse to click on the sidebar. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22262 To: mayankchoudhary, aacid, ngraham, #okular Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen

[okular] [Bug 410041] I can not click in a reference if I highlight a text

2019-08-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=410041 --- Comment #3 from Albert Astals Cid --- The context menu should mention both the link and the higlighter. Can you please add the file you're having trouble with? -- You are receiving this mail because: You are the assignee for the bug.

D22262: Thumbnails sidebar always open when okular starts

2019-08-09 Thread Albert Astals Cid
aacid added a comment. Ok, let's see the code you have and tell us where it fails and we'll try to help :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22262 To: mayankchoudhary, aacid, ngraham, #okular Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, t

D23037: Add support for cb7 comic book archives

2019-08-09 Thread Albert Astals Cid
aacid added a comment. In D23037#509088 , @broulik wrote: > Works well, thanks a lot! Let's wait for Okular maintainer approval. If by maintainer you mean me, the code looks sane. Now nhiga, can you give us your full name and email fo

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks, good, i'll commit a slightly modified version that checks substituteName != fontname too, wanted to save us all the roundtrip REPOSITORY R223 Okular BRANCH master REVISION DETAIL

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R223:a738c98c2082: Add information about substituting font into properties dialog (authored by jgrulich, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23027?vs=63395&id=63454#t

D23037: Add support for cb7 comic book archives

2019-08-09 Thread N. Higa
nhiga added a comment. @aacid Please check your email. I noticed that your public key (0x3A6A4DB839EAA6D7) seems to have expired, but I used that key to encrypt my message anyway. REVISION DETAIL https://phabricator.kde.org/D23037 To: nhiga, #okular, aacid Cc: broulik, pino, okular-devel,

[okular] [Bug 410778] New: Okular does not respect EXIF orientation tag

2019-08-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=410778 Bug ID: 410778 Summary: Okular does not respect EXIF orientation tag Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: no