[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-16 Thread Martin Steigerwald
https://bugs.kde.org/show_bug.cgi?id=402015 Martin Steigerwald changed: What|Removed |Added Resolution|WORKSFORME |FIXED --- Comment #4 from Martin Steigerwa

[okular] [Bug 408774] New: Okular refuses to save document when original file has been (re)moved or changed

2019-06-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=408774 Bug ID: 408774 Summary: Okular refuses to save document when original file has been (re)moved or changed Product: okular Version: 1.7.2 Platform: Other OS: Linux

[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=402015 --- Comment #5 from Nate Graham --- Hooray! \o/ -- You are receiving this mail because: You are the assignee for the bug.

D15580: New annotation toolbar

2019-06-16 Thread David Hurka
davidhurka added inline comments. INLINE COMMENTS > toolaction.cpp:71 > } > -button->setToolTip( i18n("Click to use the current selection > tool\nClick and hold to choose another selection tool") ); > } Why remove this tooltip? To make ToolAction (or my inferior ToggleAct

D21755: Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-16 Thread David Hurka
davidhurka added a comment. I couldn’t find a reason why disconnecting my slot at destruction fails, but it indeed fails. Workarround is to use the simpler way: QPointer. (ToolAction already does it that way.) INLINE COMMENTS > davidhurka wrote in toggleactionmenu.cpp:63 > That’s what

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-16 Thread David Hurka
davidhurka retitled this revision from "Replace ToolAction by a more universal “ToggleActionMenu”" to "[WIP] Replace ToolAction by a more universal “ToggleActionMenu”". davidhurka edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21755

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-16 Thread David Hurka
davidhurka updated this revision to Diff 59946. davidhurka added a comment. - Work arround connection problem by using QPointer REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21755?vs=59624&id=59946 BRANCH create-toggleactionmenu REVISION DETAIL https:

D15580: New annotation toolbar

2019-06-16 Thread Simone Gaiarin
simgunz added inline comments. INLINE COMMENTS > davidhurka wrote in toolaction.cpp:71 > Why remove this tooltip? > > To make ToolAction (or my inferior ToggleActionMenu) more universal to use it > for a Change Colors feature, it would be nice if tooltips are not needed > anymore. That toolti

[okular] [Bug 408801] New: Okular crashed when attempting to save a pdf file to another folder

2019-06-16 Thread Dmitry Ivanov
https://bugs.kde.org/show_bug.cgi?id=408801 Bug ID: 408801 Summary: Okular crashed when attempting to save a pdf file to another folder Product: okular Version: 1.7.2 Platform: Neon Packages OS: Linux

D15580: New annotation toolbar

2019-06-16 Thread Simone Gaiarin
simgunz updated this revision to Diff 59954. simgunz added a comment. Added the favorite tools. Now only the stamp tool is missing. PS: As usual, the code is still messy, I'll refactor it. For now I am more interested in feedback on the UI/UX Commits: - Rename XML actions

D15580: New annotation toolbar

2019-06-16 Thread David Hurka
davidhurka added a comment. In D15580#480855 , @simgunz wrote: > For now I am more interested in feedback on the UI/UX Do you have screenshots? INLINE COMMENTS > simgunz wrote in toolaction.cpp:71 > That tooltip does not appear anywhere

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-16 Thread David Hurka
davidhurka updated this revision to Diff 59958. davidhurka added a comment. - Remove accidentally inserted #include - remove repeated calls to QToolButton::setMenu() - Update class documentation REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21755?vs=599

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-16 Thread David Hurka
davidhurka edited the summary of this revision. davidhurka edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21755 To: davidhurka, #okular Cc: aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-16 Thread David Hurka
davidhurka added a subscriber: simgunz. davidhurka added a comment. From my point of view, this is complete now. 3 TODOs left (see revision description at the top). ToolAction used its own tooltip for the toolbar buttons. Tell me if that is still needed. @simgunz you just told that

[okular] [Bug 407583] Save as does anymore work, if the file was edited external

2019-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407583 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|REPORTED

[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted

2019-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=402017 Nate Graham changed: What|Removed |Added CC||martin.marmso...@gmail.com --- Comment #6 from Na

[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted

2019-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=402017 Nate Graham changed: What|Removed |Added CC||gr...@sub.red --- Comment #7 from Nate Graham --

[okular] [Bug 408774] Okular refuses to save document when original file has been (re)moved or changed

2019-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408774 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE CC|