D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > I'd also prefer to leave the current behaviour of a left-click as it is Do you speak for both mouse clicks and touch screen 'clicks'? Because the original wish is really only about touch screens, and the effects of this patch on mouse clicks was at least partia

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

michaelweghorn added a comment. In D18118#391100 , @sander wrote: > Do you speak for both mouse clicks and touch screen 'clicks'? Because the original wish is really only about touch screens, and the effects of this patch on mouse clicks was at

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. I think that swiping is a separate issue. One-finger swipes should actually be easy to implement as the difficult part already exists in the Gwenview patch mentioned above. And we probably all agree that one-finger swipes are better than three-finger ones. Howe

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn updated this revision to Diff 49223. michaelweghorn retitled this revision from "Add option to ignore print margins" to "Add option to ignore print margins for non-PDF generators". michaelweghorn edited the summary of this revision. michaelweghorn edited the test plan for this revis

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn created this revision. michaelweghorn added reviewers: Okular, ngraham, sander. Herald added a project: Okular. michaelweghorn requested review of this revision. REVISION SUMMARY This extends 'FilePrinter::printFile' by an optional parameter to specify whether or not to do scali

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a dependent revision: D18179: PDF: Implement scaling for non-rasterized printing. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, darcyshen

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn added a dependency: D10974: Add option to ignore print margins for non-PDF generators. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: okular-devel, ngraham, darcyshen, aacid

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#388761 , @ngraham wrote: > I agree that the current UI that makes you click "Force Rasterization" first is not ideal. Kudos if you find a technically acceptable way to improve that! :) My approac

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

michaelweghorn added a comment. OK, I understand. I don't have any strong opinion on this then. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: michaelweghorn, aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#389490 , @aacid wrote: > I'd be terribly unhappy about this, i never look at where my mouse is when clicking in presentation view. Perhaps a "pedal mode" for mouse and a pedal needs to be added. I think

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. > Swiping is already implemented. On my machine I can only swipe forward, not backwards in presentation mode. The wheel is too small and inaccurate for quick, rapid, touch control. Swiping left and right would be a acceptable to me, but you need to be able to s

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#389517 , @sander wrote: > Changing pages by swiping on a touchscreen works already (Qt requires you to swipe with three(!) fingers, though). But if I were a piano player using Okular to show me the music sheets

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#389518 , @ngraham wrote: > In D18118#389517 , @sander wrote: > > > Qt requires you to swipe with three(!) fingers, though > > > Oh, no wonder I never discovere

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391065 , @michaelweghorn wrote: > I'd also prefer to leave the current behaviour of a left-click as it is, regardless of the exact position. That is also in line with what e.g. LibreOffice Impress does. Allowi

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391119 , @sander wrote: > I think that swiping is a separate issue. One-finger swipes should actually be easy to implement as the difficult part already exists in the Gwenview patch mentioned above. And we pr

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. If we can implement this for touch only, +1 on touching the left side to go back. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: gbodley, michaelweghorn, aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391388 , @ngraham wrote: > If we can implement this for touch only, +1 on touching the left side to go back. I experimented a bit more with 3 finger swiping. While it works, it's not really great. To

[okular] [Bug 402020] Okular creates temporary files with wrong permissions and cannot print

https://bugs.kde.org/show_bug.cgi?id=402020 --- Comment #2 from pikku42 --- (In reply to Albert Astals Cid from comment #1) > My vote goes to: Your tmp filesystem is broken. > > Since the code for printing has not changed in years and you're the first > person with this problem. > > I doubt i'l

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > It's interesting that swiping down from the top with a single finger brings out the menu' so there does seem to be the potential of single finger swiping. No, that is simply triggered by moving the mouse/your finger on the top two rows of pixels. REPOSITORY

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 49288. sander edited the summary of this revision. sander edited the test plan for this revision. sander added a comment. New patch version: - You can go back by touching on the left half of a touchscreen, touching the right half will go forward - Mo

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Tested with my convertible laptop and it works correctly for both the click and touch use cases. Code looks sensible to me as well. REPOSITORY R223 Okular REVISION DETAIL htt

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. I still object to this, you're changing the default behaviour of the software for the 0.03% of users that use okular to play in a touch screen while playing the piano. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular,

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. The change is an improvement: Right now when using a touchscreen for presentation mode there is no way to go back. Since this doesn't affect the mouse use case at all, I don't understand the problem here. REPOSITORY R223 Okular REVISION DETAIL https://phabricato

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. In D18118#391654 , @ngraham wrote: > The change is an improvement: Right now when using a touchscreen for presentation mode there is no way to go back. Since this doesn't affect the mouse use case at all, I don't understan

D18179: PDF: Implement scaling for non-rasterized printing

aacid added a comment. Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again? INLINE COMMENTS > fileprinter.h:82 >PageSelectPolicy pageSelectPolicy = > FilePrinter::ApplicationSele

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. In D18118#391655 , @aacid wrote: > In D18118#391654 , @ngraham wrote: > > > The change is an improvement: Right now when using a touchscreen for presentation mode there is n

D10974: Add option to ignore print margins for non-PDF generators

aacid added inline comments. INLINE COMMENTS > document.h:728 > */ > -QWidget* printConfigurationWidget() const; > +PrintOptionsWidget* printConfigurationWidget() const; > this is binary incompatible :/ We could just let it be a QWidget but document it has to be a Pr

D18144: Implemented find function from console

aacid added a comment. Doesn't work when opening files from the network, i.e. do okular https://bugs.freedesktop.org/attachment.cgi?id=140739 --find poppler and you'll see that poppler is not highlighted, while if you save the file locally and do the same it'll work REPOSITORY R22

D18144: Implemented find function from console

joaonetto marked an inline comment as done. joaonetto added a comment. It seems that it tries to search before copying the file, so I'm searching an empty string. Let me see what I can do to improve that. Maybe wait until the document is completely copied? REPOSITORY R223 Okular REVISION

D18144: Implemented find function from console

aacid added a comment. In D18144#391700 , @joaonetto wrote: > It seems that it tries to search before copying the file, so I'm searching an empty string. Let me see what I can do to improve that. Maybe wait until the document is completely copi