[okular] [Bug 393478] crash when I exit presentation mode and enter again

https://bugs.kde.org/show_bug.cgi?id=393478 --- Comment #12 from Tobias Deiminger --- Ok, got it. It's this place in PresentationWidget::inhibitPowerManagement m_sleepInhibitCookie = reply.value().fileDescriptor(); We must not store QDBusUnixFileDescriptor::fileDescriptor, but clone it before.

D15574: Avoid undefined behavior due to dangling file descriptor

tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision. REVISION SUMMARY We request a inhibit lock of DBus type UNIX_FD from systemd logind. It's wrapped into (and owned by) a QDBusUnixFil

D15574: Avoid undefined behavior due to dangling file descriptor

anthonyfieroni added inline comments. INLINE COMMENTS > presentationwidget.cpp:1763 > #ifdef Q_OS_LINUX > -if (m_sleepInhibitCookie) { > -::close(m_sleepInhibitCookie); > -m_sleepInhibitCookie = 0; > +if (m_sleepInhibitFd) { > +::close(m_sleepInhibitFd); It shoul

D15574: Avoid undefined behavior due to dangling file descriptor

anthonyfieroni added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15574 To: tobiasdeiminger, aacid Cc: anthonyfieroni, okular-devel, ngraham, aacid

D15574: Avoid undefined behavior due to dangling file descriptor

tobiasdeiminger updated this revision to Diff 41827. tobiasdeiminger added a comment. Fix check for m_sleepInhibitFd REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15574?vs=41824&id=41827 BRANCH fix_dbus_fd REVISION DETAIL https://phabricator.kde.org/D

D15574: Avoid undefined behavior due to dangling file descriptor

tobiasdeiminger marked an inline comment as done. tobiasdeiminger added inline comments. INLINE COMMENTS > anthonyfieroni wrote in presentationwidget.cpp:1763 > It should be != -1 You're right, thanks REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15574 To: tobiasdeim

D15580: New annotation toolbar

simgunz created this revision. simgunz added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. simgunz requested review of this revision. REVISION SUMMARY As discussed in the task T8076 I am proposing a new annotatio

D15580: New annotation toolbar

simgunz added a task: T8076: Fix design of annotation toolbar. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: okular-devel, ngraham, aacid

D15580: New annotation toolbar

simgunz added a comment. To test this code temporary move `.config/okularpartrc` or the annotation tools may not match the ones in the buttons. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: okular-devel, ngraham, aacid

[okular] [Bug 398771] New: EPub backend: changing default font size doesn't update the page number

https://bugs.kde.org/show_bug.cgi?id=398771 Bug ID: 398771 Summary: EPub backend: changing default font size doesn't update the page number Product: okular Version: 1.5.1 Platform: openSUSE RPMs OS: Linux

D15580: New annotation toolbar

tobiasdeiminger added a comment. Nice approach👍 D1204 , D1205 and D15580 conflict somewhat. Not bad, but whoever gets in later will have to adapt. Shall we try to coordinate? REPOSITO

D15580: New annotation toolbar

tobiasdeiminger added a comment. How would the new color picker handle "multi-color" annotations? I ask, because D15205 brings selectable font color for typewriter tool. Inline note is very similar, so I had intended to submit a font color patch for inlin

D15580: New annotation toolbar

tobiasdeiminger added a comment. It took some minutes until I realized how to change from ellipse to polygon (long left press). Now I find it good and easy. Would there be a way to make it even more self explaining? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D155

D15580: New annotation toolbar

simgunz added a comment. @tobiasdeiminger I'll continue the discussion on the task T8076 related to this diff. So we can discuss the more UI related topics there. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz,

[okular] [Bug 396002] Review/Annotation tool selection with double click not persisting on page scroll

https://bugs.kde.org/show_bug.cgi?id=396002 Rajeesh K V changed: What|Removed |Added CC||rajeeshknamb...@gmail.com --- Comment #2 from Raj