D15301: Use std::unique_ptr for two private data members

tobiasdeiminger added inline comments. INLINE COMMENTS > pageviewannotator.cpp:304 > Okular::NormalizedPoint point; > -QPixmap * pixmap; > +std::unique_ptr pixmap; > QString hoverIconName, iconName; +1 for automatic memory management. But is there a reason to no

[okular] [Bug 397059] Printing from Okular creates 31% bigger image on the paper

https://bugs.kde.org/show_bug.cgi?id=397059 --- Comment #6 from k...@mail.orbitel.bg --- Created attachment 114801 --> https://bugs.kde.org/attachment.cgi?id=114801&action=edit PDF file with the needed explanation Please have here some explanation with pictures. -- You are receiving this mail

[okular] [Bug 397059] Printing from Okular creates 31% bigger image on the paper

https://bugs.kde.org/show_bug.cgi?id=397059 --- Comment #7 from k...@mail.orbitel.bg --- I have added a PDF file with some pictures to explain the case. But let me answer also on the questions. 1) If I understood correctly, the original document (or part of it) is enlarged in some way so that not

[okular] [Bug 397059] Printing from Okular creates 31% bigger image on the paper

https://bugs.kde.org/show_bug.cgi?id=397059 --- Comment #8 from k...@mail.orbitel.bg --- Sorry I press a wrong button on the keyboard and answer had been send before to finish. So I need to follow here. 3 Question answer The original documents we have checked have been prepared on A4 format. And

[okular] [Bug 397059] Printing from Okular creates 31% bigger image on the paper

https://bugs.kde.org/show_bug.cgi?id=397059 Christoph Feck changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO

[okular] [Bug 398326] New: Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 Bug ID: 398326 Summary: Letter ž is displayed as š instead Product: okular Version: 1.5.0 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 David Hurka changed: What|Removed |Added CC||david.hu...@mailbox.org --- Comment #1 from David

D15301: Use std::unique_ptr for two private data members

sander updated this revision to Diff 41114. sander added a comment. You are right about QPixmap. The updated diff now uses a QPixmap object directly. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15301?vs=41071&id=41114 REVISION DETAIL https://phabrica

D15301: Use std::unique_ptr for two private data members

sander marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15301 To: sander, #okular Cc: tobiasdeiminger, okular-devel, ngraham, aacid

[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 Yuri Chornoivan changed: What|Removed |Added CC||yurc...@ukr.net --- Comment #2 from Yuri Chor

[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 --- Comment #3 from gal...@gmail.com --- I didn't have Tahoma and I've just installed it and now I've got the same situation as David https://bugsfiles.kde.org/attachment.cgi?id=114814 -- You are receiving this mail because: You are the assignee for th

[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 --- Comment #4 from David Hurka --- Well, I’ve just installed Tahoma and now it’s displayed fine. My Okular action “About Backends” doesn’t work, but in aptitude I have libpoppler 0.41. -- You are receiving this mail because: You are the assignee for

D15279: Store all annotation color attributes as ARGB string

sander added a comment. > When is your new okularpartrc created exactly? Afaikt, it should not be created right on startup, but only when you modify some tool in the config dialog. No. It is created right at program startup. I don't even have to open a document. > Are you su

D15279: Store all annotation color attributes as ARGB string

tobiasdeiminger added a comment. > So what now? The patch seems to do something reasonable, but it does not do what you claim it does. It must work, else we couldn't go on. I've got sneaking suspicion, a wrong tools.xml is loaded in your setup. Can you watch okular in strace $ st

[okular] [Bug 398334] New: Okular crashes while highlighting PDF file

https://bugs.kde.org/show_bug.cgi?id=398334 Bug ID: 398334 Summary: Okular crashes while highlighting PDF file Product: okular Version: unspecified Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED

[okular] [Bug 398334] Okular crashes while un/re highlighting PDF file

https://bugs.kde.org/show_bug.cgi?id=398334 T. Zack Crawford changed: What|Removed |Added Summary|Okular crashes while|Okular crashes while un/re

[okular] [Bug 398338] New: Compilation failure on Musl due to use of vasprintf

https://bugs.kde.org/show_bug.cgi?id=398338 Bug ID: 398338 Summary: Compilation failure on Musl due to use of vasprintf Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Se

D15279: Store all annotation color attributes as ARGB string

sander added a comment. It really does take the file `tools.xml` from my development installation (tested with `strace`). Indeed, I deliberately purged my distro's okular from my computer a while ago, to avoid confusions like this. REPOSITORY R223 Okular REVISION DETAIL https://phabric

[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 Luigi Toscano changed: What|Removed |Added CC||luigi.tosc...@tiscali.it --- Comment #5 from Lu