Re: FreeText typewriter annotation WYSIWYG implementation ideas

2018-07-18 Thread Tobias Deiminger
Hi all, Dileep and me are still hoping for some community participation for how to rework the GUI of inline note and typewriter. It'll need enduring maintenance and support, so our approach should be backed and agreed by community. Please tell us your opinion, be it technical advise or socia

Re: FreeText typewriter annotation WYSIWYG implementation ideas

2018-07-18 Thread Oliver Sander
Hi Tobias, hi Dileep, thanks for all the work you are putting into this. I cannot comment on the technical details of your proposals, but I have some ideas regarding the more organizational side of things: * I'd prefer if work was split up such that as much code as possible will be merged by the

[okular] [Bug 394926] Okular crash

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=394926 --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, please add a comment. -- You are receiving this mail because: You are the assignee for the bu

[okular] [Bug 395765] Crash when closing okular

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=395765 Christoph Feck changed: What|Removed |Added CC||m...@dennis-irrgang.com --- Comment #2 from Ch

[okular] [Bug 395684] Segfault after closing "file not found" dialog after reboot

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=395684 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED

[okular] [Bug 395765] Crash when closing okular

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=395765 --- Comment #3 from Christoph Feck --- *** Bug 395684 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 394707] Okular crashes while showing a file not found dialog box

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=394707 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED

[okular] [Bug 394429] Okular crashed after reboot

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=394429 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[okular] [Bug 395765] Crash when closing okular

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=395765 Christoph Feck changed: What|Removed |Added CC||marcelo.jime...@gmail.com --- Comment #1 from

[okular] [Bug 395765] Crash when closing okular

2018-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=395765 Christoph Feck changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

D13203: Add Typewriter annotation tool in Okular

2018-07-18 Thread Dileep Sankhla
dileepsankhla added inline comments. INLINE COMMENTS > sander wrote in annots.cpp:182 > 1.) yes > > 2. You need to write a test that sets the HAVE_POPPLER_0_67 flag. Have a look > at that CMakeLists.txt file. It contains calls to check_cxx_source_compiles. > Each call contains a small C++ pro

D13203: Add Typewriter annotation tool in Okular

2018-07-18 Thread Oliver Sander
sander added inline comments. INLINE COMMENTS > dileepsankhla wrote in annots.cpp:182 > I have added the following lines in generator/poppler/CMakeLists.txt: > > check_cxx_source_compiles(" > #include > #include > int main() > { > Poppler::TextAnnotation *annot = new Poppler::T

D13203: Add Typewriter annotation tool in Okular

2018-07-18 Thread Tobias Deiminger
tobiasdeiminger added inline comments. INLINE COMMENTS > dileepsankhla wrote in annots.cpp:182 > I have added the following lines in generator/poppler/CMakeLists.txt: > > check_cxx_source_compiles(" > #include > #include > int main() > { > Poppler::TextAnnotation *annot = new P

D13203: Add Typewriter annotation tool in Okular

2018-07-18 Thread Dileep Sankhla
dileepsankhla marked 7 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: sander, ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

2018-07-18 Thread Dileep Sankhla
dileepsankhla updated this revision to Diff 38049. dileepsankhla added a comment. Set flag HAVE_POPPLER_0_67 in generator/poppler REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=37378&id=38049 BRANCH master REVISION DETAIL https://phabricator.k