D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. ahmadosama requested review of this revision. REVISION SUMMARY The highlights were removed when rotating the page, also the RotaionJob::rotationMatrix function wa

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11901 To: ahmadosama, #okular Cc: #okular, michaelweghorn, ngraham, aacid

D10932: [Okular] Option to reset forms

ahmadosama updated this revision to Diff 31204. ahmadosama added a comment. Removing white spaces. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10932?vs=29771&id=31204 REVISION DETAIL https://phabricator.kde.org/D10932 AFFECTED FILES autotests/CMakeL

D11051: Remembering side navigation panel state

tobiasdeiminger added a comment. > One thing that may fix it is changing > > m_sidebar = new Sidebar( parentWidget ); > > to > > m_sidebar = new Sidebar(); > > in part.cpp, this micht change the part/child relationships and get yourself of this problem. can you give it

[okular] [Bug 392671] New: Can not read pdf content in okuler.

https://bugs.kde.org/show_bug.cgi?id=392671 Bug ID: 392671 Summary: Can not read pdf content in okuler. Product: okular Version: 0.26.1 Platform: Debian stable OS: Linux Status: UNCONFIRMED Severity: norma

[okular] [Bug 392671] Can not read pdf content in okuler.

https://bugs.kde.org/show_bug.cgi?id=392671 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[okular] [Bug 392682] New: Okular ignores umask on save file as

https://bugs.kde.org/show_bug.cgi?id=392682 Bug ID: 392682 Summary: Okular ignores umask on save file as Product: okular Version: 1.3.3 Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED Severity: norma

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

https://bugs.kde.org/show_bug.cgi?id=353401 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #26 from Albert A

D11051: Remembering side navigation panel state

aacid added a comment. In D11051#238586 , @dileepsankhla wrote: > I tried but it is still giving me the segfault. The interesting thing, in my opinion, is whenever you open Okular and close it down without changing the sidebar state, it doesn't

D11051: Remembering side navigation panel state

aacid added a comment. In D11051#239040 , @tobiasdeiminger wrote: > > One thing that may fix it is changing > > > > m_sidebar = new Sidebar( parentWidget ); > > > > to > > > > m_sidebar = new Sidebar(); > > > > in part.cpp

[okular] [Bug 392682] Okular ignores umask on save file as

https://bugs.kde.org/show_bug.cgi?id=392682 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC|

[okular] [Bug 392648] search:options:from current page doesn't work

https://bugs.kde.org/show_bug.cgi?id=392648 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Resolution|---

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

aacid added a comment. Isn't that translation breaking RotationJobInternal::run ? Why would you translate the image there? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11901 To: ahmadosama, #okular Cc: aacid, ngraham, #okular, michaelweghorn

D11051: Remembering side navigation panel state

dileepsankhla added a comment. The state can be saved whenever a sidebar item is clicked in Sidebar::itemClicked but again as discussed earlier, it will be asymmetrical as to save in sidebar.cpp. Should I implement a signal slot mechanism in part.cpp to achieve so or should I find another wa