Re: [poppler] General doubts regarding annotations and its poppler support for GSoC project

2018-03-18 Thread Albert Astals Cid
El dissabte, 17 de març de 2018, a les 6:29:45 CET, Oliver Sander va escriure: > Hi Dileep, > > I think I can answer most of your questions. > > > 1. What does Okular use - the core poppler or poppler Qt5 interface > > library? > Okular uses the poppler Qt5 interface library exclusively. That li

[Need immediate help for GSoC project] Implementing FreeText annotation

2018-03-18 Thread Dileep Sankhla
Hello, I have some doubts to clear so that I can begin writing my pending GSoC proposal parts as soon as possible. Please help me. 1. The existing FreeText annotation in a pdf file can be moved and edited in Okular. Is this partial support of FreeText because of the poppler-qt5 library extends t

Re: [Need immediate help for GSoC project] Implementing FreeText annotation

2018-03-18 Thread Albert Astals Cid
El diumenge, 18 de març de 2018, a les 19:42:33 CET, Dileep Sankhla va escriure: > Hello, > > I have some doubts to clear so that I can begin writing my pending GSoC > proposal parts as soon as possible. Please help me. > > 1. The existing FreeText annotation in a pdf file can be moved and edit

Re: [Need immediate help for GSoC project] Implementing FreeText annotation

2018-03-18 Thread Oliver Sander
Hi Albert, hi Dileep, > Honestly I'm going to refer to Oliver here that is the one that proposed the > project, as far as i can see we do support FreeText annotations, so maybe he > can highlight what he thinks is missing? to be honest, I don't know. When trying to come up with interesting GSo

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-18 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > dbusabstractadaptor.h:32 > + */ > +class DBusAbstractAdaptor : public QDBusAbstractAdaptor > +{ This seems like random glue code, wouldn't this make more sense in Qt or in KF5? > mprismediaplayer2player.cpp:50 > +if (flags & Pixmap) { > +

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-18 Thread Friedrich W . H . Kossebau
kossebau added inline comments. INLINE COMMENTS > aacid wrote in dbusabstractadaptor.h:32 > This seems like random glue code, wouldn't this make more sense in Qt or in > KF5? Possibly. Similar code working around the missing Qt feature is found across code. Actually one would expect this indee