D8863: Give warnings when the file is modified externally

2017-11-20 Thread Albert Astals Cid
aacid updated this revision to Diff 22626. aacid added a comment. New text based in suggestions Please aprove ASAP since we're past the message freeze already, the translators have approved for the exception but every day that passes makes it worse for them REPOSITORY R223 Okular CHA

D8863: Give warnings when the file is modified externally

2017-11-20 Thread Albert Astals Cid
aacid updated this revision to Diff 22627. aacid added a comment. And correct diff again :D REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8863?vs=22626&id=22627 BRANCH file_modified_externally REVISION DETAIL https://phabricator.kde.org/D8863 AFFECTE

D8863: Give warnings when the file is modified externally

2017-11-20 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D8863#169475, @ngraham wrote: > > This is in stark contrast to Kate and LibreOffice, where you are allowed to save back to disk: > > Right, that's what I originally thought this was all about. If the user can't, then this whole in

D8863: Give warnings when the file is modified externally

2017-11-20 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, looks good. You missed a single spot, but I guess you just wanted to test whether I check everything indeed ;) INLINE COMMENTS > rkflx wrote in part.cpp:1721 > Use title case. Ping

D8863: Give warnings when the file is modified externally

2017-11-20 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R223:559836c39270: Give warnings when the file is modified externally (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8863?vs=22627&id=22653#toc REPOSITORY R223 Okular CHANGE

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 12 - Fixed!

2017-11-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/12/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Mon, 20 Nov 2017 13:54:13 + Build duration: 5 min 14 sec and counting JUnit Tests Name

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 8 - Still Failing!

2017-11-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/8/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Mon, 20 Nov 2017 13:53:40 + Build duration: 6 min 56 sec and counting CONSOLE O

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 9 - Still Failing!

2017-11-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/9/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Mon, 20 Nov 2017 14:00:38 + Build duration: 2 min 24 sec and counting CONSOLE O

KDE CI: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 - Build # 20 - Fixed!

2017-11-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20WindowsMSVCQt5.9/20/ Project: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 20 Nov 2017 13:53:40 + Build duration: 18 min and counting

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 67 - Fixed!

2017-11-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/67/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 20 Nov 2017 13:54:13 + Build duration: 45 min and counting JUnit Tests

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 13 - Fixed!

2017-11-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/13/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Tue, 21 Nov 2017 01:59:44 + Build duration: 8 min 12 sec and counting JUnit Tests Name

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 68 - Fixed!

2017-11-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/68/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 21 Nov 2017 01:59:45 + Build duration: 53 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 10 - Still Failing!

2017-11-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/10/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Tue, 21 Nov 2017 04:10:01 + Build duration: 4 min 36 sec and counting CONSOLE

KDE CI: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 - Build # 21 - Fixed!

2017-11-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20WindowsMSVCQt5.9/21/ Project: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 21 Nov 2017 04:10:01 + Build duration: 23 min and counting

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 11 - Still Failing!

2017-11-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/11/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Tue, 21 Nov 2017 07:41:38 + Build duration: 3 min 49 sec and counting CONSOLE