rkflx added a comment.
Most of my final checks passed, there is one more serious problem though:
23. Data loss on external change despite trying to save: Open, add
annotation, change file externally, wait for warning, Save. Instead of
overwriting, there is an error in the UI ("Could not
rkflx added a comment.
> 2. Got several "Lost annotation on document save, something went wrong" on
the console. However, to prevent data loss this should show a warning in the UI
and allow aborting (just show the warning dialog from below and amend the list
appropriately). I'll try to add s
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/1/
Project:
Applications okular kf5-qt5 SUSEQt5.9
Date of build:
Sat, 11 Nov 2017 18:05:16 +
Build duration:
1 hr 14 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/1/
Project:
Applications okular stable-kf5-qt5 SUSEQt5.9
Date of build:
Sat, 11 Nov 2017 21:00:12 +
Build duration:
10 min and counting
JUnit Tests
https://bugs.kde.org/show_bug.cgi?id=386408
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |UNCONFIRMED
Resolution|WAITINGFORIN
aacid added inline comments.
INLINE COMMENTS
> progwolff wrote in part.cpp:1400
> I changed the order here.
> Now mime types defined by OpenUrlArguments are prefered. This allows opening
> files with wrong endings by forcing the right mime type.
I don't think this is a good idea, do you have an
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Sure, commit it, but when you do can you please emit a warning() message
saying something like "the file has some errors we're showing the best we can"?
REPOSITORY
R223 Okular
REVISION DET
ngraham added a comment.
That's a good idea. @trufanov, can you add that?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8415
To: trufanov, ngraham, #okular, aacid
Cc: aacid, progwolff, ngraham
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R223 Okular
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8704
To: elvisangelaccio, #okular, aacid
Cc: ngraham, okular-devel, aacid
Hello,
KDE is under no legal obligation to distribute source code or software
that enforces PDF's copy&paste restriction flags. In fact, not even
Google Drive's Android PDF viewer enforces this. The Okular source
code calls this, 'DRM'. Put this way, the current situation appears
even more dubious
10 matches
Mail list logo
