https://bugs.kde.org/show_bug.cgi?id=386600
Julian Wolff changed:
What|Removed |Added
CC||wo...@julianwolff.de
--- Comment #1 from Julian
https://bugs.kde.org/show_bug.cgi?id=386600
Julian Wolff changed:
What|Removed |Added
CC||kosse...@kde.org
--- Comment #2 from Julian Wolf
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:01ce40b955f9: Update okular docbook (authored by lueck).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8677?vs=21953&id=22017#toc
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://
https://bugs.kde.org/show_bug.cgi?id=386600
--- Comment #3 from Friedrich W. H. Kossebau ---
I do not have Okular from master branch, so cannot test this myself for
Markdown documents.
But the KParts plugin used should know about the mimetype, it is passed both
when loading via a file and when l
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FedoraQt5.8/96/
Project:
Applications okular kf5-qt5 FedoraQt5.8
Date of build:
Tue, 07 Nov 2017 10:03:08 +
Build duration:
10 min and counting
JUnit Tests
Name:
https://bugs.kde.org/show_bug.cgi?id=386600
Julian Wolff changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0
progwolff created this revision.
progwolff added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
BUG: 386600
Applications using Okular as a KPart might set a file's mime type in the
OpenUrlArguments.
O
progwolff edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8690
To: progwolff, aacid
Cc: #okular, aacid
aacid added a comment.
interesting, could you try to add an autotest for this? Seems like something
that is a bit fragile and may break in the future depending on how we rework
stuff in part.cpp (there's a big-ish rework coming for saveas)
REPOSITORY
R223 Okular
REVISION DETAIL
https://
progwolff updated this revision to Diff 22028.
progwolff added a comment.
- add autotest
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8690?vs=22020&id=22028
BRANCH
Applications/17.08
REVISION DETAIL
https://phabricator.kde.org/D8690
AFFECTED FILES
aacid added a comment.
Not sure that's the test we really want, i mean what we really want to check
is that the proper backend was opened, no?
I mean maybe what makes sense is to set the mimetype to txt and then giving
it a pdf file and checking that the txt backend was used instead of t
progwolff added a comment.
Right, this might be worth a test too.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8690
To: progwolff, aacid
Cc: #okular, aacid
progwolff added inline comments.
INLINE COMMENTS
> part.cpp:1400
> {
> -mimes << pathMime << argMime;
> +mimes << argMime << pathMime;
> }
I changed the order here.
Now mime types defined by OpenUrlArguments are prefered. This allows opening
files with
https://bugs.kde.org/show_bug.cgi?id=385384
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
--
You are receiving thi
progwolff updated this revision to Diff 22039.
progwolff added a comment.
- prefer mime type given by OpenUrlArguments
- add test for choosing backend by mime type
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8690?vs=22028&id=22039
BRANCH
Applications
https://bugs.kde.org/show_bug.cgi?id=385384
--- Comment #2 from Alexander Trufanov ---
The workaround is proposed on https://phabricator.kde.org/D8415
--
You are receiving this mail because:
You are the assignee for the bug.
ngraham added a comment.
Could we add the local workaround here, and include a FIXME comment urging an
upstream fix later? Gwenview already has this workaround...
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8415
To: trufanov, ngraham, #okular
Cc: aacid, progwolff
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
exec() is blocking and should not be used if possible.
Currently it makes impossible to interact with a 2nd okular window
if the first window h
elvisangelaccio added a subscriber: okular-devel.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8704
To: elvisangelaccio, #okular
Cc: okular-devel, aacid
michaelweghorn added a comment.
> Open pdf file, add anotation, close app
> You get dialog about losing changes, check that save, discard, cancel all
do what they say
This works as described. One additional thought on that:
Some users may want to save the modified version to a new fi
20 matches
Mail list logo
