mwolff added inline comments.
INLINE COMMENTS
> generator.cpp:407
> +{
> +request->page()->setPixmap( request->observer(), new QPixmap(
> QPixmap::fromImage( image ) ), request->normalizedRect() );
> +
is `setPixmap` old API? Why create a QPixmap on the heap? That should not be
done, pass
rkflx created this revision.
rkflx added a reviewer: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
When porting from `add_library` to `okular_add_generator`,
https://phabricator.kde.org/R223:2f9246ae42ce6276002641ac02d9c6b880bcf7a3
missed to remove `MODULE` for spec
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R223 Okular
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8612
To: rkflx, #okular, ngraham
Cc: aacid
